瀏覽代碼

mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal

The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
(shifted and or'ed with chip select), so it's incorrect to pass
that macro directly as an argument to gpio_direction_output() call.

Also, SPI driver sets the direction and initial value of a gpio,
used as a chip select signal, before any actual activity happens
on the bus.

So, it is safe to just remove the gpio_direction_output call,
that works incorrectly, thus making no effect, anyway.

Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Tested-by: Robert Winkler <robert.winkler@boundarydevices.com>
Acked-by: Dirk Behme <dirk.behme@de.bosch.com>
Andrew Gabbasov 12 年之前
父節點
當前提交
0c54f4b7c8
共有 2 個文件被更改,包括 0 次插入2 次删除
  1. 0 1
      board/boundary/nitrogen6x/nitrogen6x.c
  2. 0 1
      board/freescale/mx6qsabrelite/mx6qsabrelite.c

+ 0 - 1
board/boundary/nitrogen6x/nitrogen6x.c

@@ -336,7 +336,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
 
 
 void setup_spi(void)
 void setup_spi(void)
 {
 {
-	gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
 	imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
 	imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
 					 ARRAY_SIZE(ecspi1_pads));
 					 ARRAY_SIZE(ecspi1_pads));
 }
 }

+ 0 - 1
board/freescale/mx6qsabrelite/mx6qsabrelite.c

@@ -308,7 +308,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
 
 
 void setup_spi(void)
 void setup_spi(void)
 {
 {
-	gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
 	imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
 	imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
 					 ARRAY_SIZE(ecspi1_pads));
 					 ARRAY_SIZE(ecspi1_pads));
 }
 }