Browse Source

asus-wmi: potential NULL dereference in show_call()

In the earlier check we assumed that "obj" could be NULL.  I looked at
some of the other places that call evaluate_object() and they check
for NULL as well.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Dan Carpenter 14 năm trước cách đây
mục cha
commit
a1d6086739
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      drivers/platform/x86/asus-wmi.c

+ 1 - 1
drivers/platform/x86/asus-wmi.c

@@ -1343,7 +1343,7 @@ static int show_call(struct seq_file *m, void *data)
 	else
 		seq_printf(m, "%#x(%#x, %#x) = t:%d\n", asus->debug.method_id,
 			   asus->debug.dev_id, asus->debug.ctrl_param,
-			   obj->type);
+			   obj ? obj->type : -1);
 
 	kfree(obj);