Răsfoiți Sursa

asus-wmi: signedness bug in read_brightness()

"err" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Dan Carpenter 14 ani în urmă
părinte
comite
0986f25fbb
1 a modificat fișierele cu 2 adăugiri și 1 ștergeri
  1. 2 1
      drivers/platform/x86/asus-wmi.c

+ 2 - 1
drivers/platform/x86/asus-wmi.c

@@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
 static int read_brightness(struct backlight_device *bd)
 {
 	struct asus_wmi *asus = bl_get_data(bd);
-	u32 retval, err;
+	u32 retval;
+	int err;
 
 	err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);