瀏覽代碼

env: throw an error when an empty key is used

If the environment contains an entry like "=value" "\0" we should throw
an error when parsing the environment. Otherwise, U-Boot will enter in
an infinite loop.

Signed-off-by: Lucian Cojocar <cojocar@gmail.com>
Lucian Cojocar 12 年之前
父節點
當前提交
e4fdcadd8a
共有 1 個文件被更改,包括 6 次插入0 次删除
  1. 6 0
      lib/hashtable.c

+ 6 - 0
lib/hashtable.c

@@ -901,6 +901,12 @@ int himport_r(struct hsearch_data *htab,
 		*sp++ = '\0';	/* terminate value */
 		++dp;
 
+		if (*name == 0) {
+			debug("INSERT: unable to use an empty key\n");
+			__set_errno(EINVAL);
+			return 0;
+		}
+
 		/* Skip variables which are not supposed to be processed */
 		if (!drop_var_from_set(name, nvars, localvars))
 			continue;