Преглед на файлове

Common/command: Guard strchr/strlen from NULL pointer

Guard strchr/strlen from being called with NULL pointer.
This line is crashing when command "env" is called without subcommand.

The cmd is NULL in this case because the calling function "do_env"
decremented the argc without checking if there are still arguments available.

Signed-off-by: Thomas Weber <weber@corscience.de>
Thomas Weber преди 14 години
родител
ревизия
7013c06124
променени са 1 файла, в които са добавени 2 реда и са изтрити 0 реда
  1. 2 0
      common/command.c

+ 2 - 0
common/command.c

@@ -108,6 +108,8 @@ cmd_tbl_t *find_cmd_tbl (const char *cmd, cmd_tbl_t *table, int table_len)
 	int len;
 	int len;
 	int n_found = 0;
 	int n_found = 0;
 
 
+	if (!cmd)
+		return NULL;
 	/*
 	/*
 	 * Some commands allow length modifiers (like "cp.b");
 	 * Some commands allow length modifiers (like "cp.b");
 	 * compare command name only until first dot.
 	 * compare command name only until first dot.