فهرست منبع

patman: Make "Reviewed-by" an important tag

Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag
used by upstream.  Stripping it is undesirable.  In fact, we should
treat it as important.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
Acked-by: Simon Glass <sjg@chromium.org>
Doug Anderson 12 سال پیش
والد
کامیت
28b3594eb9
2فایلهای تغییر یافته به همراه4 افزوده شده و 4 حذف شده
  1. 2 2
      tools/patman/README
  2. 2 2
      tools/patman/patchstream.py

+ 2 - 2
tools/patman/README

@@ -198,8 +198,9 @@ END
 	override the default signoff that patman automatically adds.
 	override the default signoff that patman automatically adds.
 
 
  Tested-by: Their Name <email>
  Tested-by: Their Name <email>
+ Reviewed-by: Their Name <email>
  Acked-by: Their Name <email>
  Acked-by: Their Name <email>
-	These indicate that someone has acked or tested your patch.
+	These indicate that someone has tested/reviewed/acked your patch.
 	When you get this reply on the mailing list, you can add this
 	When you get this reply on the mailing list, you can add this
 	tag to the relevant commit and the script will include it when
 	tag to the relevant commit and the script will include it when
 	you send out the next version. If 'Tested-by:' is set to
 	you send out the next version. If 'Tested-by:' is set to
@@ -231,7 +232,6 @@ TEST=...
 Change-Id:
 Change-Id:
 Review URL:
 Review URL:
 Reviewed-on:
 Reviewed-on:
-Reviewed-by:
 
 
 
 
 Exercise for the reader: Try adding some tags to one of your current
 Exercise for the reader: Try adding some tags to one of your current

+ 2 - 2
tools/patman/patchstream.py

@@ -31,7 +31,7 @@ from series import Series
 
 
 # Tags that we detect and remove
 # Tags that we detect and remove
 re_remove = re.compile('^BUG=|^TEST=|^BRANCH=|^Change-Id:|^Review URL:'
 re_remove = re.compile('^BUG=|^TEST=|^BRANCH=|^Change-Id:|^Review URL:'
-    '|Reviewed-on:|Reviewed-by:|Commit-Ready:')
+    '|Reviewed-on:|Commit-Ready:')
 
 
 # Lines which are allowed after a TEST= line
 # Lines which are allowed after a TEST= line
 re_allowed_after_test = re.compile('^Signed-off-by:')
 re_allowed_after_test = re.compile('^Signed-off-by:')
@@ -46,7 +46,7 @@ re_cover = re.compile('^Cover-letter:')
 re_series = re.compile('^Series-(\w*): *(.*)')
 re_series = re.compile('^Series-(\w*): *(.*)')
 
 
 # Commit tags that we want to collect and keep
 # Commit tags that we want to collect and keep
-re_tag = re.compile('^(Tested-by|Acked-by|Cc): (.*)')
+re_tag = re.compile('^(Tested-by|Acked-by|Reviewed-by|Cc): (.*)')
 
 
 # The start of a new commit in the git log
 # The start of a new commit in the git log
 re_commit = re.compile('^commit (.*)')
 re_commit = re.compile('^commit (.*)')