feature-removal-schedule.txt 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578
  1. The following is a list of files and features that are going to be
  2. removed in the kernel source tree. Every entry should contain what
  3. exactly is going away, why it is happening, and who is going to be doing
  4. the work. When the feature is removed from the kernel, it should also
  5. be removed from this file.
  6. ---------------------------
  7. What: PRISM54
  8. When: 2.6.34
  9. Why: prism54 FullMAC PCI / Cardbus devices used to be supported only by the
  10. prism54 wireless driver. After Intersil stopped selling these
  11. devices in preference for the newer more flexible SoftMAC devices
  12. a SoftMAC device driver was required and prism54 did not support
  13. them. The p54pci driver now exists and has been present in the kernel for
  14. a while. This driver supports both SoftMAC devices and FullMAC devices.
  15. The main difference between these devices was the amount of memory which
  16. could be used for the firmware. The SoftMAC devices support a smaller
  17. amount of memory. Because of this the SoftMAC firmware fits into FullMAC
  18. devices's memory. p54pci supports not only PCI / Cardbus but also USB
  19. and SPI. Since p54pci supports all devices prism54 supports
  20. you will have a conflict. I'm not quite sure how distributions are
  21. handling this conflict right now. prism54 was kept around due to
  22. claims users may experience issues when using the SoftMAC driver.
  23. Time has passed users have not reported issues. If you use prism54
  24. and for whatever reason you cannot use p54pci please let us know!
  25. E-mail us at: linux-wireless@vger.kernel.org
  26. For more information see the p54 wiki page:
  27. http://wireless.kernel.org/en/users/Drivers/p54
  28. Who: Luis R. Rodriguez <lrodriguez@atheros.com>
  29. ---------------------------
  30. What: IRQF_SAMPLE_RANDOM
  31. Check: IRQF_SAMPLE_RANDOM
  32. When: July 2009
  33. Why: Many of IRQF_SAMPLE_RANDOM users are technically bogus as entropy
  34. sources in the kernel's current entropy model. To resolve this, every
  35. input point to the kernel's entropy pool needs to better document the
  36. type of entropy source it actually is. This will be replaced with
  37. additional add_*_randomness functions in drivers/char/random.c
  38. Who: Robin Getz <rgetz@blackfin.uclinux.org> & Matt Mackall <mpm@selenic.com>
  39. ---------------------------
  40. What: Deprecated snapshot ioctls
  41. When: 2.6.36
  42. Why: The ioctls in kernel/power/user.c were marked as deprecated long time
  43. ago. Now they notify users about that so that they need to replace
  44. their userspace. After some more time, remove them completely.
  45. Who: Jiri Slaby <jirislaby@gmail.com>
  46. ---------------------------
  47. What: The ieee80211_regdom module parameter
  48. When: March 2010 / desktop catchup
  49. Why: This was inherited by the CONFIG_WIRELESS_OLD_REGULATORY code,
  50. and currently serves as an option for users to define an
  51. ISO / IEC 3166 alpha2 code for the country they are currently
  52. present in. Although there are userspace API replacements for this
  53. through nl80211 distributions haven't yet caught up with implementing
  54. decent alternatives through standard GUIs. Although available as an
  55. option through iw or wpa_supplicant its just a matter of time before
  56. distributions pick up good GUI options for this. The ideal solution
  57. would actually consist of intelligent designs which would do this for
  58. the user automatically even when travelling through different countries.
  59. Until then we leave this module parameter as a compromise.
  60. When userspace improves with reasonable widely-available alternatives for
  61. this we will no longer need this module parameter. This entry hopes that
  62. by the super-futuristically looking date of "March 2010" we will have
  63. such replacements widely available.
  64. Who: Luis R. Rodriguez <lrodriguez@atheros.com>
  65. ---------------------------
  66. What: dev->power.power_state
  67. When: July 2007
  68. Why: Broken design for runtime control over driver power states, confusing
  69. driver-internal runtime power management with: mechanisms to support
  70. system-wide sleep state transitions; event codes that distinguish
  71. different phases of swsusp "sleep" transitions; and userspace policy
  72. inputs. This framework was never widely used, and most attempts to
  73. use it were broken. Drivers should instead be exposing domain-specific
  74. interfaces either to kernel or to userspace.
  75. Who: Pavel Machek <pavel@ucw.cz>
  76. ---------------------------
  77. What: Video4Linux obsolete drivers using V4L1 API
  78. When: kernel 2.6.39
  79. Files: drivers/staging/se401/* drivers/staging/usbvideo/*
  80. Check: drivers/staging/se401/se401.c drivers/staging/usbvideo/usbvideo.c
  81. Why: There are some drivers still using V4L1 API, despite all efforts we've done
  82. to migrate. Those drivers are for obsolete hardware that the old maintainer
  83. didn't care (or not have the hardware anymore), and that no other developer
  84. could find any hardware to buy. They probably have no practical usage today,
  85. and people with such old hardware could probably keep using an older version
  86. of the kernel. Those drivers will be moved to staging on 2.6.38 and, if nobody
  87. cares enough to port and test them with V4L2 API, they'll be removed on 2.6.39.
  88. Who: Mauro Carvalho Chehab <mchehab@infradead.org>
  89. ---------------------------
  90. What: Video4Linux: Remove obsolete ioctl's
  91. When: kernel 2.6.39
  92. Files: include/media/videodev2.h
  93. Why: Some ioctl's were defined wrong on 2.6.2 and 2.6.6, using the wrong
  94. type of R/W arguments. They were fixed, but the old ioctl names are
  95. still there, maintained to avoid breaking binary compatibility:
  96. #define VIDIOC_OVERLAY_OLD _IOWR('V', 14, int)
  97. #define VIDIOC_S_PARM_OLD _IOW('V', 22, struct v4l2_streamparm)
  98. #define VIDIOC_S_CTRL_OLD _IOW('V', 28, struct v4l2_control)
  99. #define VIDIOC_G_AUDIO_OLD _IOWR('V', 33, struct v4l2_audio)
  100. #define VIDIOC_G_AUDOUT_OLD _IOWR('V', 49, struct v4l2_audioout)
  101. #define VIDIOC_CROPCAP_OLD _IOR('V', 58, struct v4l2_cropcap)
  102. There's no sense on preserving those forever, as it is very doubtful
  103. that someone would try to use a such old binary with a modern kernel.
  104. Removing them will allow us to remove some magic done at the V4L ioctl
  105. handler.
  106. Who: Mauro Carvalho Chehab <mchehab@infradead.org>
  107. ---------------------------
  108. What: sys_sysctl
  109. When: September 2010
  110. Option: CONFIG_SYSCTL_SYSCALL
  111. Why: The same information is available in a more convenient from
  112. /proc/sys, and none of the sysctl variables appear to be
  113. important performance wise.
  114. Binary sysctls are a long standing source of subtle kernel
  115. bugs and security issues.
  116. When I looked several months ago all I could find after
  117. searching several distributions were 5 user space programs and
  118. glibc (which falls back to /proc/sys) using this syscall.
  119. The man page for sysctl(2) documents it as unusable for user
  120. space programs.
  121. sysctl(2) is not generally ABI compatible to a 32bit user
  122. space application on a 64bit and a 32bit kernel.
  123. For the last several months the policy has been no new binary
  124. sysctls and no one has put forward an argument to use them.
  125. Binary sysctls issues seem to keep happening appearing so
  126. properly deprecating them (with a warning to user space) and a
  127. 2 year grace warning period will mean eventually we can kill
  128. them and end the pain.
  129. In the mean time individual binary sysctls can be dealt with
  130. in a piecewise fashion.
  131. Who: Eric Biederman <ebiederm@xmission.com>
  132. ---------------------------
  133. What: /proc/<pid>/oom_adj
  134. When: August 2012
  135. Why: /proc/<pid>/oom_adj allows userspace to influence the oom killer's
  136. badness heuristic used to determine which task to kill when the kernel
  137. is out of memory.
  138. The badness heuristic has since been rewritten since the introduction of
  139. this tunable such that its meaning is deprecated. The value was
  140. implemented as a bitshift on a score generated by the badness()
  141. function that did not have any precise units of measure. With the
  142. rewrite, the score is given as a proportion of available memory to the
  143. task allocating pages, so using a bitshift which grows the score
  144. exponentially is, thus, impossible to tune with fine granularity.
  145. A much more powerful interface, /proc/<pid>/oom_score_adj, was
  146. introduced with the oom killer rewrite that allows users to increase or
  147. decrease the badness() score linearly. This interface will replace
  148. /proc/<pid>/oom_adj.
  149. A warning will be emitted to the kernel log if an application uses this
  150. deprecated interface. After it is printed once, future warnings will be
  151. suppressed until the kernel is rebooted.
  152. ---------------------------
  153. What: remove EXPORT_SYMBOL(kernel_thread)
  154. When: August 2006
  155. Files: arch/*/kernel/*_ksyms.c
  156. Check: kernel_thread
  157. Why: kernel_thread is a low-level implementation detail. Drivers should
  158. use the <linux/kthread.h> API instead which shields them from
  159. implementation details and provides a higherlevel interface that
  160. prevents bugs and code duplication
  161. Who: Christoph Hellwig <hch@lst.de>
  162. ---------------------------
  163. What: Unused EXPORT_SYMBOL/EXPORT_SYMBOL_GPL exports
  164. (temporary transition config option provided until then)
  165. The transition config option will also be removed at the same time.
  166. When: before 2.6.19
  167. Why: Unused symbols are both increasing the size of the kernel binary
  168. and are often a sign of "wrong API"
  169. Who: Arjan van de Ven <arjan@linux.intel.com>
  170. ---------------------------
  171. What: PHYSDEVPATH, PHYSDEVBUS, PHYSDEVDRIVER in the uevent environment
  172. When: October 2008
  173. Why: The stacking of class devices makes these values misleading and
  174. inconsistent.
  175. Class devices should not carry any of these properties, and bus
  176. devices have SUBSYTEM and DRIVER as a replacement.
  177. Who: Kay Sievers <kay.sievers@suse.de>
  178. ---------------------------
  179. What: ACPI procfs interface
  180. When: July 2008
  181. Why: ACPI sysfs conversion should be finished by January 2008.
  182. ACPI procfs interface will be removed in July 2008 so that
  183. there is enough time for the user space to catch up.
  184. Who: Zhang Rui <rui.zhang@intel.com>
  185. ---------------------------
  186. What: /proc/acpi/button
  187. When: August 2007
  188. Why: /proc/acpi/button has been replaced by events to the input layer
  189. since 2.6.20.
  190. Who: Len Brown <len.brown@intel.com>
  191. ---------------------------
  192. What: /proc/acpi/event
  193. When: February 2008
  194. Why: /proc/acpi/event has been replaced by events via the input layer
  195. and netlink since 2.6.23.
  196. Who: Len Brown <len.brown@intel.com>
  197. ---------------------------
  198. What: i386/x86_64 bzImage symlinks
  199. When: April 2010
  200. Why: The i386/x86_64 merge provides a symlink to the old bzImage
  201. location so not yet updated user space tools, e.g. package
  202. scripts, do not break.
  203. Who: Thomas Gleixner <tglx@linutronix.de>
  204. ---------------------------
  205. What: GPIO autorequest on gpio_direction_{input,output}() in gpiolib
  206. When: February 2010
  207. Why: All callers should use explicit gpio_request()/gpio_free().
  208. The autorequest mechanism in gpiolib was provided mostly as a
  209. migration aid for legacy GPIO interfaces (for SOC based GPIOs).
  210. Those users have now largely migrated. Platforms implementing
  211. the GPIO interfaces without using gpiolib will see no changes.
  212. Who: David Brownell <dbrownell@users.sourceforge.net>
  213. ---------------------------
  214. What: b43 support for firmware revision < 410
  215. When: The schedule was July 2008, but it was decided that we are going to keep the
  216. code as long as there are no major maintanance headaches.
  217. So it _could_ be removed _any_ time now, if it conflicts with something new.
  218. Why: The support code for the old firmware hurts code readability/maintainability
  219. and slightly hurts runtime performance. Bugfixes for the old firmware
  220. are not provided by Broadcom anymore.
  221. Who: Michael Buesch <mb@bu3sch.de>
  222. ---------------------------
  223. What: /sys/o2cb symlink
  224. When: January 2010
  225. Why: /sys/fs/o2cb is the proper location for this information - /sys/o2cb
  226. exists as a symlink for backwards compatibility for old versions of
  227. ocfs2-tools. 2 years should be sufficient time to phase in new versions
  228. which know to look in /sys/fs/o2cb.
  229. Who: ocfs2-devel@oss.oracle.com
  230. ---------------------------
  231. What: Ability for non root users to shm_get hugetlb pages based on mlock
  232. resource limits
  233. When: 2.6.31
  234. Why: Non root users need to be part of /proc/sys/vm/hugetlb_shm_group or
  235. have CAP_IPC_LOCK to be able to allocate shm segments backed by
  236. huge pages. The mlock based rlimit check to allow shm hugetlb is
  237. inconsistent with mmap based allocations. Hence it is being
  238. deprecated.
  239. Who: Ravikiran Thirumalai <kiran@scalex86.org>
  240. ---------------------------
  241. What: CONFIG_THERMAL_HWMON
  242. When: January 2009
  243. Why: This option was introduced just to allow older lm-sensors userspace
  244. to keep working over the upgrade to 2.6.26. At the scheduled time of
  245. removal fixed lm-sensors (2.x or 3.x) should be readily available.
  246. Who: Rene Herman <rene.herman@gmail.com>
  247. ---------------------------
  248. What: Code that is now under CONFIG_WIRELESS_EXT_SYSFS
  249. (in net/core/net-sysfs.c)
  250. When: After the only user (hal) has seen a release with the patches
  251. for enough time, probably some time in 2010.
  252. Why: Over 1K .text/.data size reduction, data is available in other
  253. ways (ioctls)
  254. Who: Johannes Berg <johannes@sipsolutions.net>
  255. ---------------------------
  256. What: sysfs ui for changing p4-clockmod parameters
  257. When: September 2009
  258. Why: See commits 129f8ae9b1b5be94517da76009ea956e89104ce8 and
  259. e088e4c9cdb618675874becb91b2fd581ee707e6.
  260. Removal is subject to fixing any remaining bugs in ACPI which may
  261. cause the thermal throttling not to happen at the right time.
  262. Who: Dave Jones <davej@redhat.com>, Matthew Garrett <mjg@redhat.com>
  263. -----------------------------
  264. What: __do_IRQ all in one fits nothing interrupt handler
  265. When: 2.6.32
  266. Why: __do_IRQ was kept for easy migration to the type flow handlers.
  267. More than two years of migration time is enough.
  268. Who: Thomas Gleixner <tglx@linutronix.de>
  269. -----------------------------
  270. What: fakephp and associated sysfs files in /sys/bus/pci/slots/
  271. When: 2011
  272. Why: In 2.6.27, the semantics of /sys/bus/pci/slots was redefined to
  273. represent a machine's physical PCI slots. The change in semantics
  274. had userspace implications, as the hotplug core no longer allowed
  275. drivers to create multiple sysfs files per physical slot (required
  276. for multi-function devices, e.g.). fakephp was seen as a developer's
  277. tool only, and its interface changed. Too late, we learned that
  278. there were some users of the fakephp interface.
  279. In 2.6.30, the original fakephp interface was restored. At the same
  280. time, the PCI core gained the ability that fakephp provided, namely
  281. function-level hot-remove and hot-add.
  282. Since the PCI core now provides the same functionality, exposed in:
  283. /sys/bus/pci/rescan
  284. /sys/bus/pci/devices/.../remove
  285. /sys/bus/pci/devices/.../rescan
  286. there is no functional reason to maintain fakephp as well.
  287. We will keep the existing module so that 'modprobe fakephp' will
  288. present the old /sys/bus/pci/slots/... interface for compatibility,
  289. but users are urged to migrate their applications to the API above.
  290. After a reasonable transition period, we will remove the legacy
  291. fakephp interface.
  292. Who: Alex Chiang <achiang@hp.com>
  293. ---------------------------
  294. What: CONFIG_RFKILL_INPUT
  295. When: 2.6.33
  296. Why: Should be implemented in userspace, policy daemon.
  297. Who: Johannes Berg <johannes@sipsolutions.net>
  298. ----------------------------
  299. What: sound-slot/service-* module aliases and related clutters in
  300. sound/sound_core.c
  301. When: August 2010
  302. Why: OSS sound_core grabs all legacy minors (0-255) of SOUND_MAJOR
  303. (14) and requests modules using custom sound-slot/service-*
  304. module aliases. The only benefit of doing this is allowing
  305. use of custom module aliases which might as well be considered
  306. a bug at this point. This preemptive claiming prevents
  307. alternative OSS implementations.
  308. Till the feature is removed, the kernel will be requesting
  309. both sound-slot/service-* and the standard char-major-* module
  310. aliases and allow turning off the pre-claiming selectively via
  311. CONFIG_SOUND_OSS_CORE_PRECLAIM and soundcore.preclaim_oss
  312. kernel parameter.
  313. After the transition phase is complete, both the custom module
  314. aliases and switches to disable it will go away. This removal
  315. will also allow making ALSA OSS emulation independent of
  316. sound_core. The dependency will be broken then too.
  317. Who: Tejun Heo <tj@kernel.org>
  318. ----------------------------
  319. What: Support for lcd_switch and display_get in asus-laptop driver
  320. When: March 2010
  321. Why: These two features use non-standard interfaces. There are the
  322. only features that really need multiple path to guess what's
  323. the right method name on a specific laptop.
  324. Removing them will allow to remove a lot of code an significantly
  325. clean the drivers.
  326. This will affect the backlight code which won't be able to know
  327. if the backlight is on or off. The platform display file will also be
  328. write only (like the one in eeepc-laptop).
  329. This should'nt affect a lot of user because they usually know
  330. when their display is on or off.
  331. Who: Corentin Chary <corentin.chary@gmail.com>
  332. ----------------------------
  333. What: sysfs-class-rfkill state file
  334. When: Feb 2014
  335. Files: net/rfkill/core.c
  336. Why: Documented as obsolete since Feb 2010. This file is limited to 3
  337. states while the rfkill drivers can have 4 states.
  338. Who: anybody or Florian Mickler <florian@mickler.org>
  339. ----------------------------
  340. What: sysfs-class-rfkill claim file
  341. When: Feb 2012
  342. Files: net/rfkill/core.c
  343. Why: It is not possible to claim an rfkill driver since 2007. This is
  344. Documented as obsolete since Feb 2010.
  345. Who: anybody or Florian Mickler <florian@mickler.org>
  346. ----------------------------
  347. What: capifs
  348. When: February 2011
  349. Files: drivers/isdn/capi/capifs.*
  350. Why: udev fully replaces this special file system that only contains CAPI
  351. NCCI TTY device nodes. User space (pppdcapiplugin) works without
  352. noticing the difference.
  353. Who: Jan Kiszka <jan.kiszka@web.de>
  354. ----------------------------
  355. What: KVM paravirt mmu host support
  356. When: January 2011
  357. Why: The paravirt mmu host support is slower than non-paravirt mmu, both
  358. on newer and older hardware. It is already not exposed to the guest,
  359. and kept only for live migration purposes.
  360. Who: Avi Kivity <avi@redhat.com>
  361. ----------------------------
  362. What: iwlwifi 50XX module parameters
  363. When: 2.6.40
  364. Why: The "..50" modules parameters were used to configure 5000 series and
  365. up devices; different set of module parameters also available for 4965
  366. with same functionalities. Consolidate both set into single place
  367. in drivers/net/wireless/iwlwifi/iwl-agn.c
  368. Who: Wey-Yi Guy <wey-yi.w.guy@intel.com>
  369. ----------------------------
  370. What: iwl4965 alias support
  371. When: 2.6.40
  372. Why: Internal alias support has been present in module-init-tools for some
  373. time, the MODULE_ALIAS("iwl4965") boilerplate aliases can be removed
  374. with no impact.
  375. Who: Wey-Yi Guy <wey-yi.w.guy@intel.com>
  376. ---------------------------
  377. What: xt_NOTRACK
  378. Files: net/netfilter/xt_NOTRACK.c
  379. When: April 2011
  380. Why: Superseded by xt_CT
  381. Who: Netfilter developer team <netfilter-devel@vger.kernel.org>
  382. ----------------------------
  383. What: IRQF_DISABLED
  384. When: 2.6.36
  385. Why: The flag is a NOOP as we run interrupt handlers with interrupts disabled
  386. Who: Thomas Gleixner <tglx@linutronix.de>
  387. ----------------------------
  388. What: The acpi_sleep=s4_nonvs command line option
  389. When: 2.6.37
  390. Files: arch/x86/kernel/acpi/sleep.c
  391. Why: superseded by acpi_sleep=nonvs
  392. Who: Rafael J. Wysocki <rjw@sisk.pl>
  393. ----------------------------
  394. What: PCI DMA unmap state API
  395. When: August 2012
  396. Why: PCI DMA unmap state API (include/linux/pci-dma.h) was replaced
  397. with DMA unmap state API (DMA unmap state API can be used for
  398. any bus).
  399. Who: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
  400. ----------------------------
  401. What: DMA_xxBIT_MASK macros
  402. When: Jun 2011
  403. Why: DMA_xxBIT_MASK macros were replaced with DMA_BIT_MASK() macros.
  404. Who: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
  405. ----------------------------
  406. What: namespace cgroup (ns_cgroup)
  407. When: 2.6.38
  408. Why: The ns_cgroup leads to some problems:
  409. * cgroup creation is out-of-control
  410. * cgroup name can conflict when pids are looping
  411. * it is not possible to have a single process handling
  412. a lot of namespaces without falling in a exponential creation time
  413. * we may want to create a namespace without creating a cgroup
  414. The ns_cgroup is replaced by a compatibility flag 'clone_children',
  415. where a newly created cgroup will copy the parent cgroup values.
  416. The userspace has to manually create a cgroup and add a task to
  417. the 'tasks' file.
  418. Who: Daniel Lezcano <daniel.lezcano@free.fr>
  419. ----------------------------
  420. What: iwlwifi disable_hw_scan module parameters
  421. When: 2.6.40
  422. Why: Hareware scan is the prefer method for iwlwifi devices for
  423. scanning operation. Remove software scan support for all the
  424. iwlwifi devices.
  425. Who: Wey-Yi Guy <wey-yi.w.guy@intel.com>
  426. ----------------------------
  427. What: access to nfsd auth cache through sys_nfsservctl or '.' files
  428. in the 'nfsd' filesystem.
  429. When: 2.6.40
  430. Why: This is a legacy interface which have been replaced by a more
  431. dynamic cache. Continuing to maintain this interface is an
  432. unnecessary burden.
  433. Who: NeilBrown <neilb@suse.de>
  434. ----------------------------
  435. What: i2c_adapter.id
  436. When: June 2011
  437. Why: This field is deprecated. I2C device drivers shouldn't change their
  438. behavior based on the underlying I2C adapter. Instead, the I2C
  439. adapter driver should instantiate the I2C devices and provide the
  440. needed platform-specific information.
  441. Who: Jean Delvare <khali@linux-fr.org>
  442. ----------------------------
  443. What: cancel_rearming_delayed_work[queue]()
  444. When: 2.6.39
  445. Why: The functions have been superceded by cancel_delayed_work_sync()
  446. quite some time ago. The conversion is trivial and there is no
  447. in-kernel user left.
  448. Who: Tejun Heo <tj@kernel.org>
  449. ----------------------------