udl_fb.c 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629
  1. /*
  2. * Copyright (C) 2012 Red Hat
  3. *
  4. * based in parts on udlfb.c:
  5. * Copyright (C) 2009 Roberto De Ioris <roberto@unbit.it>
  6. * Copyright (C) 2009 Jaya Kumar <jayakumar.lkml@gmail.com>
  7. * Copyright (C) 2009 Bernie Thompson <bernie@plugable.com>
  8. *
  9. * This file is subject to the terms and conditions of the GNU General Public
  10. * License v2. See the file COPYING in the main directory of this archive for
  11. * more details.
  12. */
  13. #include <linux/module.h>
  14. #include <linux/slab.h>
  15. #include <linux/fb.h>
  16. #include "drmP.h"
  17. #include "drm.h"
  18. #include "drm_crtc.h"
  19. #include "drm_crtc_helper.h"
  20. #include "udl_drv.h"
  21. #include "drm_fb_helper.h"
  22. #define DL_DEFIO_WRITE_DELAY 5 /* fb_deferred_io.delay in jiffies */
  23. static int fb_defio = 1; /* Optionally enable experimental fb_defio mmap support */
  24. static int fb_bpp = 16;
  25. module_param(fb_bpp, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP);
  26. module_param(fb_defio, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP);
  27. struct udl_fbdev {
  28. struct drm_fb_helper helper;
  29. struct udl_framebuffer ufb;
  30. struct list_head fbdev_list;
  31. int fb_count;
  32. };
  33. #define DL_ALIGN_UP(x, a) ALIGN(x, a)
  34. #define DL_ALIGN_DOWN(x, a) ALIGN(x-(a-1), a)
  35. /** Read the red component (0..255) of a 32 bpp colour. */
  36. #define DLO_RGB_GETRED(col) (uint8_t)((col) & 0xFF)
  37. /** Read the green component (0..255) of a 32 bpp colour. */
  38. #define DLO_RGB_GETGRN(col) (uint8_t)(((col) >> 8) & 0xFF)
  39. /** Read the blue component (0..255) of a 32 bpp colour. */
  40. #define DLO_RGB_GETBLU(col) (uint8_t)(((col) >> 16) & 0xFF)
  41. /** Return red/green component of a 16 bpp colour number. */
  42. #define DLO_RG16(red, grn) (uint8_t)((((red) & 0xF8) | ((grn) >> 5)) & 0xFF)
  43. /** Return green/blue component of a 16 bpp colour number. */
  44. #define DLO_GB16(grn, blu) (uint8_t)(((((grn) & 0x1C) << 3) | ((blu) >> 3)) & 0xFF)
  45. /** Return 8 bpp colour number from red, green and blue components. */
  46. #define DLO_RGB8(red, grn, blu) ((((red) << 5) | (((grn) & 3) << 3) | ((blu) & 7)) & 0xFF)
  47. #if 0
  48. static uint8_t rgb8(uint32_t col)
  49. {
  50. uint8_t red = DLO_RGB_GETRED(col);
  51. uint8_t grn = DLO_RGB_GETGRN(col);
  52. uint8_t blu = DLO_RGB_GETBLU(col);
  53. return DLO_RGB8(red, grn, blu);
  54. }
  55. static uint16_t rgb16(uint32_t col)
  56. {
  57. uint8_t red = DLO_RGB_GETRED(col);
  58. uint8_t grn = DLO_RGB_GETGRN(col);
  59. uint8_t blu = DLO_RGB_GETBLU(col);
  60. return (DLO_RG16(red, grn) << 8) + DLO_GB16(grn, blu);
  61. }
  62. #endif
  63. /*
  64. * NOTE: fb_defio.c is holding info->fbdefio.mutex
  65. * Touching ANY framebuffer memory that triggers a page fault
  66. * in fb_defio will cause a deadlock, when it also tries to
  67. * grab the same mutex.
  68. */
  69. static void udlfb_dpy_deferred_io(struct fb_info *info,
  70. struct list_head *pagelist)
  71. {
  72. struct page *cur;
  73. struct fb_deferred_io *fbdefio = info->fbdefio;
  74. struct udl_fbdev *ufbdev = info->par;
  75. struct drm_device *dev = ufbdev->ufb.base.dev;
  76. struct udl_device *udl = dev->dev_private;
  77. struct urb *urb;
  78. char *cmd;
  79. cycles_t start_cycles, end_cycles;
  80. int bytes_sent = 0;
  81. int bytes_identical = 0;
  82. int bytes_rendered = 0;
  83. if (!fb_defio)
  84. return;
  85. start_cycles = get_cycles();
  86. urb = udl_get_urb(dev);
  87. if (!urb)
  88. return;
  89. cmd = urb->transfer_buffer;
  90. /* walk the written page list and render each to device */
  91. list_for_each_entry(cur, &fbdefio->pagelist, lru) {
  92. if (udl_render_hline(dev, (ufbdev->ufb.base.bits_per_pixel / 8),
  93. &urb, (char *) info->fix.smem_start,
  94. &cmd, cur->index << PAGE_SHIFT,
  95. PAGE_SIZE, &bytes_identical, &bytes_sent))
  96. goto error;
  97. bytes_rendered += PAGE_SIZE;
  98. }
  99. if (cmd > (char *) urb->transfer_buffer) {
  100. /* Send partial buffer remaining before exiting */
  101. int len = cmd - (char *) urb->transfer_buffer;
  102. udl_submit_urb(dev, urb, len);
  103. bytes_sent += len;
  104. } else
  105. udl_urb_completion(urb);
  106. error:
  107. atomic_add(bytes_sent, &udl->bytes_sent);
  108. atomic_add(bytes_identical, &udl->bytes_identical);
  109. atomic_add(bytes_rendered, &udl->bytes_rendered);
  110. end_cycles = get_cycles();
  111. atomic_add(((unsigned int) ((end_cycles - start_cycles)
  112. >> 10)), /* Kcycles */
  113. &udl->cpu_kcycles_used);
  114. }
  115. int udl_handle_damage(struct udl_framebuffer *fb, int x, int y,
  116. int width, int height)
  117. {
  118. struct drm_device *dev = fb->base.dev;
  119. struct udl_device *udl = dev->dev_private;
  120. int i, ret;
  121. char *cmd;
  122. cycles_t start_cycles, end_cycles;
  123. int bytes_sent = 0;
  124. int bytes_identical = 0;
  125. struct urb *urb;
  126. int aligned_x;
  127. int bpp = (fb->base.bits_per_pixel / 8);
  128. if (!fb->active_16)
  129. return 0;
  130. if (!fb->obj->vmapping) {
  131. ret = udl_gem_vmap(fb->obj);
  132. if (ret == -ENOMEM) {
  133. DRM_ERROR("failed to vmap fb\n");
  134. return 0;
  135. }
  136. if (!fb->obj->vmapping) {
  137. DRM_ERROR("failed to vmapping\n");
  138. return 0;
  139. }
  140. }
  141. start_cycles = get_cycles();
  142. aligned_x = DL_ALIGN_DOWN(x, sizeof(unsigned long));
  143. width = DL_ALIGN_UP(width + (x-aligned_x), sizeof(unsigned long));
  144. x = aligned_x;
  145. if ((width <= 0) ||
  146. (x + width > fb->base.width) ||
  147. (y + height > fb->base.height))
  148. return -EINVAL;
  149. urb = udl_get_urb(dev);
  150. if (!urb)
  151. return 0;
  152. cmd = urb->transfer_buffer;
  153. for (i = y; i < y + height ; i++) {
  154. const int line_offset = fb->base.pitches[0] * i;
  155. const int byte_offset = line_offset + (x * bpp);
  156. if (udl_render_hline(dev, bpp, &urb,
  157. (char *) fb->obj->vmapping,
  158. &cmd, byte_offset, width * bpp,
  159. &bytes_identical, &bytes_sent))
  160. goto error;
  161. }
  162. if (cmd > (char *) urb->transfer_buffer) {
  163. /* Send partial buffer remaining before exiting */
  164. int len = cmd - (char *) urb->transfer_buffer;
  165. ret = udl_submit_urb(dev, urb, len);
  166. bytes_sent += len;
  167. } else
  168. udl_urb_completion(urb);
  169. error:
  170. atomic_add(bytes_sent, &udl->bytes_sent);
  171. atomic_add(bytes_identical, &udl->bytes_identical);
  172. atomic_add(width*height*bpp, &udl->bytes_rendered);
  173. end_cycles = get_cycles();
  174. atomic_add(((unsigned int) ((end_cycles - start_cycles)
  175. >> 10)), /* Kcycles */
  176. &udl->cpu_kcycles_used);
  177. return 0;
  178. }
  179. static int udl_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
  180. {
  181. unsigned long start = vma->vm_start;
  182. unsigned long size = vma->vm_end - vma->vm_start;
  183. unsigned long offset = vma->vm_pgoff << PAGE_SHIFT;
  184. unsigned long page, pos;
  185. if (offset + size > info->fix.smem_len)
  186. return -EINVAL;
  187. pos = (unsigned long)info->fix.smem_start + offset;
  188. pr_notice("mmap() framebuffer addr:%lu size:%lu\n",
  189. pos, size);
  190. while (size > 0) {
  191. page = vmalloc_to_pfn((void *)pos);
  192. if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
  193. return -EAGAIN;
  194. start += PAGE_SIZE;
  195. pos += PAGE_SIZE;
  196. if (size > PAGE_SIZE)
  197. size -= PAGE_SIZE;
  198. else
  199. size = 0;
  200. }
  201. vma->vm_flags |= VM_RESERVED; /* avoid to swap out this VMA */
  202. return 0;
  203. }
  204. static void udl_fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
  205. {
  206. struct udl_fbdev *ufbdev = info->par;
  207. sys_fillrect(info, rect);
  208. udl_handle_damage(&ufbdev->ufb, rect->dx, rect->dy, rect->width,
  209. rect->height);
  210. }
  211. static void udl_fb_copyarea(struct fb_info *info, const struct fb_copyarea *region)
  212. {
  213. struct udl_fbdev *ufbdev = info->par;
  214. sys_copyarea(info, region);
  215. udl_handle_damage(&ufbdev->ufb, region->dx, region->dy, region->width,
  216. region->height);
  217. }
  218. static void udl_fb_imageblit(struct fb_info *info, const struct fb_image *image)
  219. {
  220. struct udl_fbdev *ufbdev = info->par;
  221. sys_imageblit(info, image);
  222. udl_handle_damage(&ufbdev->ufb, image->dx, image->dy, image->width,
  223. image->height);
  224. }
  225. /*
  226. * It's common for several clients to have framebuffer open simultaneously.
  227. * e.g. both fbcon and X. Makes things interesting.
  228. * Assumes caller is holding info->lock (for open and release at least)
  229. */
  230. static int udl_fb_open(struct fb_info *info, int user)
  231. {
  232. struct udl_fbdev *ufbdev = info->par;
  233. struct drm_device *dev = ufbdev->ufb.base.dev;
  234. struct udl_device *udl = dev->dev_private;
  235. /* If the USB device is gone, we don't accept new opens */
  236. if (drm_device_is_unplugged(udl->ddev))
  237. return -ENODEV;
  238. ufbdev->fb_count++;
  239. if (fb_defio && (info->fbdefio == NULL)) {
  240. /* enable defio at last moment if not disabled by client */
  241. struct fb_deferred_io *fbdefio;
  242. fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);
  243. if (fbdefio) {
  244. fbdefio->delay = DL_DEFIO_WRITE_DELAY;
  245. fbdefio->deferred_io = udlfb_dpy_deferred_io;
  246. }
  247. info->fbdefio = fbdefio;
  248. fb_deferred_io_init(info);
  249. }
  250. pr_notice("open /dev/fb%d user=%d fb_info=%p count=%d\n",
  251. info->node, user, info, ufbdev->fb_count);
  252. return 0;
  253. }
  254. /*
  255. * Assumes caller is holding info->lock mutex (for open and release at least)
  256. */
  257. static int udl_fb_release(struct fb_info *info, int user)
  258. {
  259. struct udl_fbdev *ufbdev = info->par;
  260. ufbdev->fb_count--;
  261. if ((ufbdev->fb_count == 0) && (info->fbdefio)) {
  262. fb_deferred_io_cleanup(info);
  263. kfree(info->fbdefio);
  264. info->fbdefio = NULL;
  265. info->fbops->fb_mmap = udl_fb_mmap;
  266. }
  267. pr_warn("released /dev/fb%d user=%d count=%d\n",
  268. info->node, user, ufbdev->fb_count);
  269. return 0;
  270. }
  271. static struct fb_ops udlfb_ops = {
  272. .owner = THIS_MODULE,
  273. .fb_check_var = drm_fb_helper_check_var,
  274. .fb_set_par = drm_fb_helper_set_par,
  275. .fb_fillrect = udl_fb_fillrect,
  276. .fb_copyarea = udl_fb_copyarea,
  277. .fb_imageblit = udl_fb_imageblit,
  278. .fb_pan_display = drm_fb_helper_pan_display,
  279. .fb_blank = drm_fb_helper_blank,
  280. .fb_setcmap = drm_fb_helper_setcmap,
  281. .fb_debug_enter = drm_fb_helper_debug_enter,
  282. .fb_debug_leave = drm_fb_helper_debug_leave,
  283. .fb_mmap = udl_fb_mmap,
  284. .fb_open = udl_fb_open,
  285. .fb_release = udl_fb_release,
  286. };
  287. void udl_crtc_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green,
  288. u16 blue, int regno)
  289. {
  290. }
  291. void udl_crtc_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
  292. u16 *blue, int regno)
  293. {
  294. *red = 0;
  295. *green = 0;
  296. *blue = 0;
  297. }
  298. static int udl_user_framebuffer_dirty(struct drm_framebuffer *fb,
  299. struct drm_file *file,
  300. unsigned flags, unsigned color,
  301. struct drm_clip_rect *clips,
  302. unsigned num_clips)
  303. {
  304. struct udl_framebuffer *ufb = to_udl_fb(fb);
  305. int i;
  306. if (!ufb->active_16)
  307. return 0;
  308. for (i = 0; i < num_clips; i++) {
  309. udl_handle_damage(ufb, clips[i].x1, clips[i].y1,
  310. clips[i].x2 - clips[i].x1,
  311. clips[i].y2 - clips[i].y1);
  312. }
  313. return 0;
  314. }
  315. static void udl_user_framebuffer_destroy(struct drm_framebuffer *fb)
  316. {
  317. struct udl_framebuffer *ufb = to_udl_fb(fb);
  318. if (ufb->obj)
  319. drm_gem_object_unreference_unlocked(&ufb->obj->base);
  320. drm_framebuffer_cleanup(fb);
  321. kfree(ufb);
  322. }
  323. static const struct drm_framebuffer_funcs udlfb_funcs = {
  324. .destroy = udl_user_framebuffer_destroy,
  325. .dirty = udl_user_framebuffer_dirty,
  326. .create_handle = NULL,
  327. };
  328. static int
  329. udl_framebuffer_init(struct drm_device *dev,
  330. struct udl_framebuffer *ufb,
  331. struct drm_mode_fb_cmd2 *mode_cmd,
  332. struct udl_gem_object *obj)
  333. {
  334. int ret;
  335. ufb->obj = obj;
  336. ret = drm_framebuffer_init(dev, &ufb->base, &udlfb_funcs);
  337. drm_helper_mode_fill_fb_struct(&ufb->base, mode_cmd);
  338. return ret;
  339. }
  340. static int udlfb_create(struct udl_fbdev *ufbdev,
  341. struct drm_fb_helper_surface_size *sizes)
  342. {
  343. struct drm_device *dev = ufbdev->helper.dev;
  344. struct fb_info *info;
  345. struct device *device = &dev->usbdev->dev;
  346. struct drm_framebuffer *fb;
  347. struct drm_mode_fb_cmd2 mode_cmd;
  348. struct udl_gem_object *obj;
  349. uint32_t size;
  350. int ret = 0;
  351. if (sizes->surface_bpp == 24)
  352. sizes->surface_bpp = 32;
  353. mode_cmd.width = sizes->surface_width;
  354. mode_cmd.height = sizes->surface_height;
  355. mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7) / 8);
  356. mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
  357. sizes->surface_depth);
  358. size = mode_cmd.pitches[0] * mode_cmd.height;
  359. size = ALIGN(size, PAGE_SIZE);
  360. obj = udl_gem_alloc_object(dev, size);
  361. if (!obj)
  362. goto out;
  363. ret = udl_gem_vmap(obj);
  364. if (ret) {
  365. DRM_ERROR("failed to vmap fb\n");
  366. goto out_gfree;
  367. }
  368. info = framebuffer_alloc(0, device);
  369. if (!info) {
  370. ret = -ENOMEM;
  371. goto out_gfree;
  372. }
  373. info->par = ufbdev;
  374. ret = udl_framebuffer_init(dev, &ufbdev->ufb, &mode_cmd, obj);
  375. if (ret)
  376. goto out_gfree;
  377. fb = &ufbdev->ufb.base;
  378. ufbdev->helper.fb = fb;
  379. ufbdev->helper.fbdev = info;
  380. strcpy(info->fix.id, "udldrmfb");
  381. info->screen_base = ufbdev->ufb.obj->vmapping;
  382. info->fix.smem_len = size;
  383. info->fix.smem_start = (unsigned long)ufbdev->ufb.obj->vmapping;
  384. info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
  385. info->fbops = &udlfb_ops;
  386. drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
  387. drm_fb_helper_fill_var(info, &ufbdev->helper, sizes->fb_width, sizes->fb_height);
  388. ret = fb_alloc_cmap(&info->cmap, 256, 0);
  389. if (ret) {
  390. ret = -ENOMEM;
  391. goto out_gfree;
  392. }
  393. DRM_DEBUG_KMS("allocated %dx%d vmal %p\n",
  394. fb->width, fb->height,
  395. ufbdev->ufb.obj->vmapping);
  396. return ret;
  397. out_gfree:
  398. drm_gem_object_unreference(&ufbdev->ufb.obj->base);
  399. out:
  400. return ret;
  401. }
  402. static int udl_fb_find_or_create_single(struct drm_fb_helper *helper,
  403. struct drm_fb_helper_surface_size *sizes)
  404. {
  405. struct udl_fbdev *ufbdev = (struct udl_fbdev *)helper;
  406. int new_fb = 0;
  407. int ret;
  408. if (!helper->fb) {
  409. ret = udlfb_create(ufbdev, sizes);
  410. if (ret)
  411. return ret;
  412. new_fb = 1;
  413. }
  414. return new_fb;
  415. }
  416. static struct drm_fb_helper_funcs udl_fb_helper_funcs = {
  417. .gamma_set = udl_crtc_fb_gamma_set,
  418. .gamma_get = udl_crtc_fb_gamma_get,
  419. .fb_probe = udl_fb_find_or_create_single,
  420. };
  421. static void udl_fbdev_destroy(struct drm_device *dev,
  422. struct udl_fbdev *ufbdev)
  423. {
  424. struct fb_info *info;
  425. if (ufbdev->helper.fbdev) {
  426. info = ufbdev->helper.fbdev;
  427. unregister_framebuffer(info);
  428. if (info->cmap.len)
  429. fb_dealloc_cmap(&info->cmap);
  430. framebuffer_release(info);
  431. }
  432. drm_fb_helper_fini(&ufbdev->helper);
  433. drm_framebuffer_cleanup(&ufbdev->ufb.base);
  434. drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base);
  435. }
  436. int udl_fbdev_init(struct drm_device *dev)
  437. {
  438. struct udl_device *udl = dev->dev_private;
  439. int bpp_sel = fb_bpp;
  440. struct udl_fbdev *ufbdev;
  441. int ret;
  442. ufbdev = kzalloc(sizeof(struct udl_fbdev), GFP_KERNEL);
  443. if (!ufbdev)
  444. return -ENOMEM;
  445. udl->fbdev = ufbdev;
  446. ufbdev->helper.funcs = &udl_fb_helper_funcs;
  447. ret = drm_fb_helper_init(dev, &ufbdev->helper,
  448. 1, 1);
  449. if (ret) {
  450. kfree(ufbdev);
  451. return ret;
  452. }
  453. drm_fb_helper_single_add_all_connectors(&ufbdev->helper);
  454. drm_fb_helper_initial_config(&ufbdev->helper, bpp_sel);
  455. return 0;
  456. }
  457. void udl_fbdev_cleanup(struct drm_device *dev)
  458. {
  459. struct udl_device *udl = dev->dev_private;
  460. if (!udl->fbdev)
  461. return;
  462. udl_fbdev_destroy(dev, udl->fbdev);
  463. kfree(udl->fbdev);
  464. udl->fbdev = NULL;
  465. }
  466. void udl_fbdev_unplug(struct drm_device *dev)
  467. {
  468. struct udl_device *udl = dev->dev_private;
  469. struct udl_fbdev *ufbdev;
  470. if (!udl->fbdev)
  471. return;
  472. ufbdev = udl->fbdev;
  473. if (ufbdev->helper.fbdev) {
  474. struct fb_info *info;
  475. info = ufbdev->helper.fbdev;
  476. unlink_framebuffer(info);
  477. }
  478. }
  479. struct drm_framebuffer *
  480. udl_fb_user_fb_create(struct drm_device *dev,
  481. struct drm_file *file,
  482. struct drm_mode_fb_cmd2 *mode_cmd)
  483. {
  484. struct drm_gem_object *obj;
  485. struct udl_framebuffer *ufb;
  486. int ret;
  487. uint32_t size;
  488. obj = drm_gem_object_lookup(dev, file, mode_cmd->handles[0]);
  489. if (obj == NULL)
  490. return ERR_PTR(-ENOENT);
  491. size = mode_cmd->pitches[0] * mode_cmd->height;
  492. size = ALIGN(size, PAGE_SIZE);
  493. if (size > obj->size) {
  494. DRM_ERROR("object size not sufficient for fb %d %zu %d %d\n", size, obj->size, mode_cmd->pitches[0], mode_cmd->height);
  495. return ERR_PTR(-ENOMEM);
  496. }
  497. ufb = kzalloc(sizeof(*ufb), GFP_KERNEL);
  498. if (ufb == NULL)
  499. return ERR_PTR(-ENOMEM);
  500. ret = udl_framebuffer_init(dev, ufb, mode_cmd, to_udl_bo(obj));
  501. if (ret) {
  502. kfree(ufb);
  503. return ERR_PTR(-EINVAL);
  504. }
  505. return &ufb->base;
  506. }