drbd_state.c 46 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610
  1. /*
  2. drbd_state.c
  3. This file is part of DRBD by Philipp Reisner and Lars Ellenberg.
  4. Copyright (C) 2001-2008, LINBIT Information Technologies GmbH.
  5. Copyright (C) 1999-2008, Philipp Reisner <philipp.reisner@linbit.com>.
  6. Copyright (C) 2002-2008, Lars Ellenberg <lars.ellenberg@linbit.com>.
  7. Thanks to Carter Burden, Bart Grantham and Gennadiy Nerubayev
  8. from Logicworks, Inc. for making SDP replication support possible.
  9. drbd is free software; you can redistribute it and/or modify
  10. it under the terms of the GNU General Public License as published by
  11. the Free Software Foundation; either version 2, or (at your option)
  12. any later version.
  13. drbd is distributed in the hope that it will be useful,
  14. but WITHOUT ANY WARRANTY; without even the implied warranty of
  15. MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  16. GNU General Public License for more details.
  17. You should have received a copy of the GNU General Public License
  18. along with drbd; see the file COPYING. If not, write to
  19. the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
  20. */
  21. #include <linux/drbd_limits.h>
  22. #include "drbd_int.h"
  23. #include "drbd_req.h"
  24. struct after_state_chg_work {
  25. struct drbd_work w;
  26. union drbd_state os;
  27. union drbd_state ns;
  28. enum chg_state_flags flags;
  29. struct completion *done;
  30. };
  31. static int w_after_state_ch(struct drbd_work *w, int unused);
  32. static void after_state_ch(struct drbd_conf *mdev, union drbd_state os,
  33. union drbd_state ns, enum chg_state_flags flags);
  34. static void after_all_state_ch(struct drbd_tconn *tconn);
  35. static enum drbd_state_rv is_valid_state(struct drbd_conf *, union drbd_state);
  36. static enum drbd_state_rv is_valid_soft_transition(union drbd_state, union drbd_state);
  37. static enum drbd_state_rv is_valid_transition(union drbd_state os, union drbd_state ns);
  38. static union drbd_state sanitize_state(struct drbd_conf *mdev, union drbd_state ns,
  39. const char **warn_sync_abort);
  40. static inline bool is_susp(union drbd_state s)
  41. {
  42. return s.susp || s.susp_nod || s.susp_fen;
  43. }
  44. bool conn_all_vols_unconf(struct drbd_tconn *tconn)
  45. {
  46. struct drbd_conf *mdev;
  47. int vnr;
  48. idr_for_each_entry(&tconn->volumes, mdev, vnr) {
  49. if (mdev->state.disk != D_DISKLESS ||
  50. mdev->state.conn != C_STANDALONE ||
  51. mdev->state.role != R_SECONDARY)
  52. return false;
  53. }
  54. return true;
  55. }
  56. /* Unfortunately the states where not correctly ordered, when
  57. they where defined. therefore can not use max_t() here. */
  58. static enum drbd_role max_role(enum drbd_role role1, enum drbd_role role2)
  59. {
  60. if (role1 == R_PRIMARY || role2 == R_PRIMARY)
  61. return R_PRIMARY;
  62. if (role1 == R_SECONDARY || role2 == R_SECONDARY)
  63. return R_SECONDARY;
  64. return R_UNKNOWN;
  65. }
  66. static enum drbd_role min_role(enum drbd_role role1, enum drbd_role role2)
  67. {
  68. if (role1 == R_UNKNOWN || role2 == R_UNKNOWN)
  69. return R_UNKNOWN;
  70. if (role1 == R_SECONDARY || role2 == R_SECONDARY)
  71. return R_SECONDARY;
  72. return R_PRIMARY;
  73. }
  74. enum drbd_role conn_highest_role(struct drbd_tconn *tconn)
  75. {
  76. enum drbd_role role = R_UNKNOWN;
  77. struct drbd_conf *mdev;
  78. int vnr;
  79. idr_for_each_entry(&tconn->volumes, mdev, vnr)
  80. role = max_role(role, mdev->state.role);
  81. return role;
  82. }
  83. enum drbd_role conn_highest_peer(struct drbd_tconn *tconn)
  84. {
  85. enum drbd_role peer = R_UNKNOWN;
  86. struct drbd_conf *mdev;
  87. int vnr;
  88. idr_for_each_entry(&tconn->volumes, mdev, vnr)
  89. peer = max_role(peer, mdev->state.peer);
  90. return peer;
  91. }
  92. enum drbd_disk_state conn_highest_disk(struct drbd_tconn *tconn)
  93. {
  94. enum drbd_disk_state ds = D_DISKLESS;
  95. struct drbd_conf *mdev;
  96. int vnr;
  97. idr_for_each_entry(&tconn->volumes, mdev, vnr)
  98. ds = max_t(enum drbd_disk_state, ds, mdev->state.disk);
  99. return ds;
  100. }
  101. enum drbd_disk_state conn_highest_pdsk(struct drbd_tconn *tconn)
  102. {
  103. enum drbd_disk_state ds = D_DISKLESS;
  104. struct drbd_conf *mdev;
  105. int vnr;
  106. idr_for_each_entry(&tconn->volumes, mdev, vnr)
  107. ds = max_t(enum drbd_disk_state, ds, mdev->state.pdsk);
  108. return ds;
  109. }
  110. /**
  111. * cl_wide_st_chg() - true if the state change is a cluster wide one
  112. * @mdev: DRBD device.
  113. * @os: old (current) state.
  114. * @ns: new (wanted) state.
  115. */
  116. static int cl_wide_st_chg(struct drbd_conf *mdev,
  117. union drbd_state os, union drbd_state ns)
  118. {
  119. return (os.conn >= C_CONNECTED && ns.conn >= C_CONNECTED &&
  120. ((os.role != R_PRIMARY && ns.role == R_PRIMARY) ||
  121. (os.conn != C_STARTING_SYNC_T && ns.conn == C_STARTING_SYNC_T) ||
  122. (os.conn != C_STARTING_SYNC_S && ns.conn == C_STARTING_SYNC_S) ||
  123. (os.disk != D_DISKLESS && ns.disk == D_DISKLESS))) ||
  124. (os.conn >= C_CONNECTED && ns.conn == C_DISCONNECTING) ||
  125. (os.conn == C_CONNECTED && ns.conn == C_VERIFY_S);
  126. }
  127. static union drbd_state
  128. apply_mask_val(union drbd_state os, union drbd_state mask, union drbd_state val)
  129. {
  130. union drbd_state ns;
  131. ns.i = (os.i & ~mask.i) | val.i;
  132. return ns;
  133. }
  134. enum drbd_state_rv
  135. drbd_change_state(struct drbd_conf *mdev, enum chg_state_flags f,
  136. union drbd_state mask, union drbd_state val)
  137. {
  138. unsigned long flags;
  139. union drbd_state ns;
  140. enum drbd_state_rv rv;
  141. spin_lock_irqsave(&mdev->tconn->req_lock, flags);
  142. ns = apply_mask_val(drbd_read_state(mdev), mask, val);
  143. rv = _drbd_set_state(mdev, ns, f, NULL);
  144. spin_unlock_irqrestore(&mdev->tconn->req_lock, flags);
  145. return rv;
  146. }
  147. /**
  148. * drbd_force_state() - Impose a change which happens outside our control on our state
  149. * @mdev: DRBD device.
  150. * @mask: mask of state bits to change.
  151. * @val: value of new state bits.
  152. */
  153. void drbd_force_state(struct drbd_conf *mdev,
  154. union drbd_state mask, union drbd_state val)
  155. {
  156. drbd_change_state(mdev, CS_HARD, mask, val);
  157. }
  158. static enum drbd_state_rv
  159. _req_st_cond(struct drbd_conf *mdev, union drbd_state mask,
  160. union drbd_state val)
  161. {
  162. union drbd_state os, ns;
  163. unsigned long flags;
  164. enum drbd_state_rv rv;
  165. if (test_and_clear_bit(CL_ST_CHG_SUCCESS, &mdev->flags))
  166. return SS_CW_SUCCESS;
  167. if (test_and_clear_bit(CL_ST_CHG_FAIL, &mdev->flags))
  168. return SS_CW_FAILED_BY_PEER;
  169. spin_lock_irqsave(&mdev->tconn->req_lock, flags);
  170. os = drbd_read_state(mdev);
  171. ns = sanitize_state(mdev, apply_mask_val(os, mask, val), NULL);
  172. rv = is_valid_transition(os, ns);
  173. if (rv == SS_SUCCESS)
  174. rv = SS_UNKNOWN_ERROR; /* cont waiting, otherwise fail. */
  175. if (!cl_wide_st_chg(mdev, os, ns))
  176. rv = SS_CW_NO_NEED;
  177. if (rv == SS_UNKNOWN_ERROR) {
  178. rv = is_valid_state(mdev, ns);
  179. if (rv == SS_SUCCESS) {
  180. rv = is_valid_soft_transition(os, ns);
  181. if (rv == SS_SUCCESS)
  182. rv = SS_UNKNOWN_ERROR; /* cont waiting, otherwise fail. */
  183. }
  184. }
  185. spin_unlock_irqrestore(&mdev->tconn->req_lock, flags);
  186. return rv;
  187. }
  188. /**
  189. * drbd_req_state() - Perform an eventually cluster wide state change
  190. * @mdev: DRBD device.
  191. * @mask: mask of state bits to change.
  192. * @val: value of new state bits.
  193. * @f: flags
  194. *
  195. * Should not be called directly, use drbd_request_state() or
  196. * _drbd_request_state().
  197. */
  198. static enum drbd_state_rv
  199. drbd_req_state(struct drbd_conf *mdev, union drbd_state mask,
  200. union drbd_state val, enum chg_state_flags f)
  201. {
  202. struct completion done;
  203. unsigned long flags;
  204. union drbd_state os, ns;
  205. enum drbd_state_rv rv;
  206. init_completion(&done);
  207. if (f & CS_SERIALIZE)
  208. mutex_lock(mdev->state_mutex);
  209. spin_lock_irqsave(&mdev->tconn->req_lock, flags);
  210. os = drbd_read_state(mdev);
  211. ns = sanitize_state(mdev, apply_mask_val(os, mask, val), NULL);
  212. rv = is_valid_transition(os, ns);
  213. if (rv < SS_SUCCESS) {
  214. spin_unlock_irqrestore(&mdev->tconn->req_lock, flags);
  215. goto abort;
  216. }
  217. if (cl_wide_st_chg(mdev, os, ns)) {
  218. rv = is_valid_state(mdev, ns);
  219. if (rv == SS_SUCCESS)
  220. rv = is_valid_soft_transition(os, ns);
  221. spin_unlock_irqrestore(&mdev->tconn->req_lock, flags);
  222. if (rv < SS_SUCCESS) {
  223. if (f & CS_VERBOSE)
  224. print_st_err(mdev, os, ns, rv);
  225. goto abort;
  226. }
  227. if (drbd_send_state_req(mdev, mask, val)) {
  228. rv = SS_CW_FAILED_BY_PEER;
  229. if (f & CS_VERBOSE)
  230. print_st_err(mdev, os, ns, rv);
  231. goto abort;
  232. }
  233. wait_event(mdev->state_wait,
  234. (rv = _req_st_cond(mdev, mask, val)));
  235. if (rv < SS_SUCCESS) {
  236. if (f & CS_VERBOSE)
  237. print_st_err(mdev, os, ns, rv);
  238. goto abort;
  239. }
  240. spin_lock_irqsave(&mdev->tconn->req_lock, flags);
  241. ns = apply_mask_val(drbd_read_state(mdev), mask, val);
  242. rv = _drbd_set_state(mdev, ns, f, &done);
  243. } else {
  244. rv = _drbd_set_state(mdev, ns, f, &done);
  245. }
  246. spin_unlock_irqrestore(&mdev->tconn->req_lock, flags);
  247. if (f & CS_WAIT_COMPLETE && rv == SS_SUCCESS) {
  248. D_ASSERT(current != mdev->tconn->worker.task);
  249. wait_for_completion(&done);
  250. }
  251. abort:
  252. if (f & CS_SERIALIZE)
  253. mutex_unlock(mdev->state_mutex);
  254. return rv;
  255. }
  256. /**
  257. * _drbd_request_state() - Request a state change (with flags)
  258. * @mdev: DRBD device.
  259. * @mask: mask of state bits to change.
  260. * @val: value of new state bits.
  261. * @f: flags
  262. *
  263. * Cousin of drbd_request_state(), useful with the CS_WAIT_COMPLETE
  264. * flag, or when logging of failed state change requests is not desired.
  265. */
  266. enum drbd_state_rv
  267. _drbd_request_state(struct drbd_conf *mdev, union drbd_state mask,
  268. union drbd_state val, enum chg_state_flags f)
  269. {
  270. enum drbd_state_rv rv;
  271. wait_event(mdev->state_wait,
  272. (rv = drbd_req_state(mdev, mask, val, f)) != SS_IN_TRANSIENT_STATE);
  273. return rv;
  274. }
  275. static void print_st(struct drbd_conf *mdev, char *name, union drbd_state ns)
  276. {
  277. dev_err(DEV, " %s = { cs:%s ro:%s/%s ds:%s/%s %c%c%c%c%c%c }\n",
  278. name,
  279. drbd_conn_str(ns.conn),
  280. drbd_role_str(ns.role),
  281. drbd_role_str(ns.peer),
  282. drbd_disk_str(ns.disk),
  283. drbd_disk_str(ns.pdsk),
  284. is_susp(ns) ? 's' : 'r',
  285. ns.aftr_isp ? 'a' : '-',
  286. ns.peer_isp ? 'p' : '-',
  287. ns.user_isp ? 'u' : '-',
  288. ns.susp_fen ? 'F' : '-',
  289. ns.susp_nod ? 'N' : '-'
  290. );
  291. }
  292. void print_st_err(struct drbd_conf *mdev, union drbd_state os,
  293. union drbd_state ns, enum drbd_state_rv err)
  294. {
  295. if (err == SS_IN_TRANSIENT_STATE)
  296. return;
  297. dev_err(DEV, "State change failed: %s\n", drbd_set_st_err_str(err));
  298. print_st(mdev, " state", os);
  299. print_st(mdev, "wanted", ns);
  300. }
  301. static long print_state_change(char *pb, union drbd_state os, union drbd_state ns,
  302. enum chg_state_flags flags)
  303. {
  304. char *pbp;
  305. pbp = pb;
  306. *pbp = 0;
  307. if (ns.role != os.role && flags & CS_DC_ROLE)
  308. pbp += sprintf(pbp, "role( %s -> %s ) ",
  309. drbd_role_str(os.role),
  310. drbd_role_str(ns.role));
  311. if (ns.peer != os.peer && flags & CS_DC_PEER)
  312. pbp += sprintf(pbp, "peer( %s -> %s ) ",
  313. drbd_role_str(os.peer),
  314. drbd_role_str(ns.peer));
  315. if (ns.conn != os.conn && flags & CS_DC_CONN)
  316. pbp += sprintf(pbp, "conn( %s -> %s ) ",
  317. drbd_conn_str(os.conn),
  318. drbd_conn_str(ns.conn));
  319. if (ns.disk != os.disk && flags & CS_DC_DISK)
  320. pbp += sprintf(pbp, "disk( %s -> %s ) ",
  321. drbd_disk_str(os.disk),
  322. drbd_disk_str(ns.disk));
  323. if (ns.pdsk != os.pdsk && flags & CS_DC_PDSK)
  324. pbp += sprintf(pbp, "pdsk( %s -> %s ) ",
  325. drbd_disk_str(os.pdsk),
  326. drbd_disk_str(ns.pdsk));
  327. if (is_susp(ns) != is_susp(os))
  328. pbp += sprintf(pbp, "susp( %d -> %d ) ",
  329. is_susp(os),
  330. is_susp(ns));
  331. if (ns.aftr_isp != os.aftr_isp)
  332. pbp += sprintf(pbp, "aftr_isp( %d -> %d ) ",
  333. os.aftr_isp,
  334. ns.aftr_isp);
  335. if (ns.peer_isp != os.peer_isp)
  336. pbp += sprintf(pbp, "peer_isp( %d -> %d ) ",
  337. os.peer_isp,
  338. ns.peer_isp);
  339. if (ns.user_isp != os.user_isp)
  340. pbp += sprintf(pbp, "user_isp( %d -> %d ) ",
  341. os.user_isp,
  342. ns.user_isp);
  343. return pbp - pb;
  344. }
  345. static void drbd_pr_state_change(struct drbd_conf *mdev, union drbd_state os, union drbd_state ns,
  346. enum chg_state_flags flags)
  347. {
  348. char pb[300];
  349. if (print_state_change(pb, os, ns, flags ^ CS_DC_MASK))
  350. dev_info(DEV, "%s\n", pb);
  351. }
  352. static void conn_pr_state_change(struct drbd_tconn *tconn, union drbd_state os, union drbd_state ns,
  353. enum chg_state_flags flags)
  354. {
  355. char pb[300];
  356. if (print_state_change(pb, os, ns, flags))
  357. conn_info(tconn, "%s\n", pb);
  358. }
  359. /**
  360. * is_valid_state() - Returns an SS_ error code if ns is not valid
  361. * @mdev: DRBD device.
  362. * @ns: State to consider.
  363. */
  364. static enum drbd_state_rv
  365. is_valid_state(struct drbd_conf *mdev, union drbd_state ns)
  366. {
  367. /* See drbd_state_sw_errors in drbd_strings.c */
  368. enum drbd_fencing_p fp;
  369. enum drbd_state_rv rv = SS_SUCCESS;
  370. fp = FP_DONT_CARE;
  371. if (get_ldev(mdev)) {
  372. fp = mdev->ldev->dc.fencing;
  373. put_ldev(mdev);
  374. }
  375. if (get_net_conf(mdev->tconn)) {
  376. if (!mdev->tconn->net_conf->two_primaries && ns.role == R_PRIMARY) {
  377. if (ns.peer == R_PRIMARY)
  378. rv = SS_TWO_PRIMARIES;
  379. else if (conn_highest_peer(mdev->tconn) == R_PRIMARY)
  380. rv = SS_O_VOL_PEER_PRI;
  381. }
  382. put_net_conf(mdev->tconn);
  383. }
  384. if (rv <= 0)
  385. /* already found a reason to abort */;
  386. else if (ns.role == R_SECONDARY && mdev->open_cnt)
  387. rv = SS_DEVICE_IN_USE;
  388. else if (ns.role == R_PRIMARY && ns.conn < C_CONNECTED && ns.disk < D_UP_TO_DATE)
  389. rv = SS_NO_UP_TO_DATE_DISK;
  390. else if (fp >= FP_RESOURCE &&
  391. ns.role == R_PRIMARY && ns.conn < C_CONNECTED && ns.pdsk >= D_UNKNOWN)
  392. rv = SS_PRIMARY_NOP;
  393. else if (ns.role == R_PRIMARY && ns.disk <= D_INCONSISTENT && ns.pdsk <= D_INCONSISTENT)
  394. rv = SS_NO_UP_TO_DATE_DISK;
  395. else if (ns.conn > C_CONNECTED && ns.disk < D_INCONSISTENT)
  396. rv = SS_NO_LOCAL_DISK;
  397. else if (ns.conn > C_CONNECTED && ns.pdsk < D_INCONSISTENT)
  398. rv = SS_NO_REMOTE_DISK;
  399. else if (ns.conn > C_CONNECTED && ns.disk < D_UP_TO_DATE && ns.pdsk < D_UP_TO_DATE)
  400. rv = SS_NO_UP_TO_DATE_DISK;
  401. else if ((ns.conn == C_CONNECTED ||
  402. ns.conn == C_WF_BITMAP_S ||
  403. ns.conn == C_SYNC_SOURCE ||
  404. ns.conn == C_PAUSED_SYNC_S) &&
  405. ns.disk == D_OUTDATED)
  406. rv = SS_CONNECTED_OUTDATES;
  407. else if ((ns.conn == C_VERIFY_S || ns.conn == C_VERIFY_T) &&
  408. (mdev->tconn->net_conf->verify_alg[0] == 0))
  409. rv = SS_NO_VERIFY_ALG;
  410. else if ((ns.conn == C_VERIFY_S || ns.conn == C_VERIFY_T) &&
  411. mdev->tconn->agreed_pro_version < 88)
  412. rv = SS_NOT_SUPPORTED;
  413. else if (ns.conn >= C_CONNECTED && ns.pdsk == D_UNKNOWN)
  414. rv = SS_CONNECTED_OUTDATES;
  415. return rv;
  416. }
  417. /**
  418. * is_valid_soft_transition() - Returns an SS_ error code if the state transition is not possible
  419. * This function limits state transitions that may be declined by DRBD. I.e.
  420. * user requests (aka soft transitions).
  421. * @mdev: DRBD device.
  422. * @ns: new state.
  423. * @os: old state.
  424. */
  425. static enum drbd_state_rv
  426. is_valid_soft_transition(union drbd_state os, union drbd_state ns)
  427. {
  428. enum drbd_state_rv rv = SS_SUCCESS;
  429. if ((ns.conn == C_STARTING_SYNC_T || ns.conn == C_STARTING_SYNC_S) &&
  430. os.conn > C_CONNECTED)
  431. rv = SS_RESYNC_RUNNING;
  432. if (ns.conn == C_DISCONNECTING && os.conn == C_STANDALONE)
  433. rv = SS_ALREADY_STANDALONE;
  434. if (ns.disk > D_ATTACHING && os.disk == D_DISKLESS)
  435. rv = SS_IS_DISKLESS;
  436. if (ns.conn == C_WF_CONNECTION && os.conn < C_UNCONNECTED)
  437. rv = SS_NO_NET_CONFIG;
  438. if (ns.disk == D_OUTDATED && os.disk < D_OUTDATED && os.disk != D_ATTACHING)
  439. rv = SS_LOWER_THAN_OUTDATED;
  440. if (ns.conn == C_DISCONNECTING && os.conn == C_UNCONNECTED)
  441. rv = SS_IN_TRANSIENT_STATE;
  442. /* if (ns.conn == os.conn && ns.conn == C_WF_REPORT_PARAMS)
  443. rv = SS_IN_TRANSIENT_STATE; */
  444. if ((ns.conn == C_VERIFY_S || ns.conn == C_VERIFY_T) && os.conn < C_CONNECTED)
  445. rv = SS_NEED_CONNECTION;
  446. if ((ns.conn == C_VERIFY_S || ns.conn == C_VERIFY_T) &&
  447. ns.conn != os.conn && os.conn > C_CONNECTED)
  448. rv = SS_RESYNC_RUNNING;
  449. if ((ns.conn == C_STARTING_SYNC_S || ns.conn == C_STARTING_SYNC_T) &&
  450. os.conn < C_CONNECTED)
  451. rv = SS_NEED_CONNECTION;
  452. if ((ns.conn == C_SYNC_TARGET || ns.conn == C_SYNC_SOURCE)
  453. && os.conn < C_WF_REPORT_PARAMS)
  454. rv = SS_NEED_CONNECTION; /* No NetworkFailure -> SyncTarget etc... */
  455. return rv;
  456. }
  457. static enum drbd_state_rv
  458. is_valid_conn_transition(enum drbd_conns oc, enum drbd_conns nc)
  459. {
  460. enum drbd_state_rv rv = SS_SUCCESS;
  461. /* Disallow Network errors to configure a device's network part */
  462. if ((nc >= C_TIMEOUT && nc <= C_TEAR_DOWN) && oc <= C_DISCONNECTING)
  463. rv = SS_NEED_CONNECTION;
  464. /* After a network error only C_UNCONNECTED or C_DISCONNECTING may follow. */
  465. if (oc >= C_TIMEOUT && oc <= C_TEAR_DOWN && nc != C_UNCONNECTED && nc != C_DISCONNECTING)
  466. rv = SS_IN_TRANSIENT_STATE;
  467. /* After C_DISCONNECTING only C_STANDALONE may follow */
  468. if (oc == C_DISCONNECTING && nc != C_STANDALONE)
  469. rv = SS_IN_TRANSIENT_STATE;
  470. return rv;
  471. }
  472. /**
  473. * is_valid_transition() - Returns an SS_ error code if the state transition is not possible
  474. * This limits hard state transitions. Hard state transitions are facts there are
  475. * imposed on DRBD by the environment. E.g. disk broke or network broke down.
  476. * But those hard state transitions are still not allowed to do everything.
  477. * @ns: new state.
  478. * @os: old state.
  479. */
  480. static enum drbd_state_rv
  481. is_valid_transition(union drbd_state os, union drbd_state ns)
  482. {
  483. enum drbd_state_rv rv;
  484. rv = is_valid_conn_transition(os.conn, ns.conn);
  485. /* we cannot fail (again) if we already detached */
  486. if (ns.disk == D_FAILED && os.disk == D_DISKLESS)
  487. rv = SS_IS_DISKLESS;
  488. /* if we are only D_ATTACHING yet,
  489. * we can (and should) go directly to D_DISKLESS. */
  490. if (ns.disk == D_FAILED && os.disk == D_ATTACHING) {
  491. printk("TODO: FIX ME\n");
  492. rv = SS_IS_DISKLESS;
  493. }
  494. return rv;
  495. }
  496. /**
  497. * sanitize_state() - Resolves implicitly necessary additional changes to a state transition
  498. * @mdev: DRBD device.
  499. * @os: old state.
  500. * @ns: new state.
  501. * @warn_sync_abort:
  502. *
  503. * When we loose connection, we have to set the state of the peers disk (pdsk)
  504. * to D_UNKNOWN. This rule and many more along those lines are in this function.
  505. */
  506. static union drbd_state sanitize_state(struct drbd_conf *mdev, union drbd_state ns,
  507. const char **warn_sync_abort)
  508. {
  509. enum drbd_fencing_p fp;
  510. enum drbd_disk_state disk_min, disk_max, pdsk_min, pdsk_max;
  511. fp = FP_DONT_CARE;
  512. if (get_ldev(mdev)) {
  513. fp = mdev->ldev->dc.fencing;
  514. put_ldev(mdev);
  515. }
  516. /* Implications from connection to peer and peer_isp */
  517. if (ns.conn < C_CONNECTED) {
  518. ns.peer_isp = 0;
  519. ns.peer = R_UNKNOWN;
  520. if (ns.pdsk > D_UNKNOWN || ns.pdsk < D_INCONSISTENT)
  521. ns.pdsk = D_UNKNOWN;
  522. }
  523. /* Clear the aftr_isp when becoming unconfigured */
  524. if (ns.conn == C_STANDALONE && ns.disk == D_DISKLESS && ns.role == R_SECONDARY)
  525. ns.aftr_isp = 0;
  526. /* An implication of the disk states onto the connection state */
  527. /* Abort resync if a disk fails/detaches */
  528. if (ns.conn > C_CONNECTED && (ns.disk <= D_FAILED || ns.pdsk <= D_FAILED)) {
  529. if (warn_sync_abort)
  530. *warn_sync_abort =
  531. ns.conn == C_VERIFY_S || ns.conn == C_VERIFY_T ?
  532. "Online-verify" : "Resync";
  533. ns.conn = C_CONNECTED;
  534. }
  535. /* Connection breaks down before we finished "Negotiating" */
  536. if (ns.conn < C_CONNECTED && ns.disk == D_NEGOTIATING &&
  537. get_ldev_if_state(mdev, D_NEGOTIATING)) {
  538. if (mdev->ed_uuid == mdev->ldev->md.uuid[UI_CURRENT]) {
  539. ns.disk = mdev->new_state_tmp.disk;
  540. ns.pdsk = mdev->new_state_tmp.pdsk;
  541. } else {
  542. dev_alert(DEV, "Connection lost while negotiating, no data!\n");
  543. ns.disk = D_DISKLESS;
  544. ns.pdsk = D_UNKNOWN;
  545. }
  546. put_ldev(mdev);
  547. }
  548. /* D_CONSISTENT and D_OUTDATED vanish when we get connected */
  549. if (ns.conn >= C_CONNECTED && ns.conn < C_AHEAD) {
  550. if (ns.disk == D_CONSISTENT || ns.disk == D_OUTDATED)
  551. ns.disk = D_UP_TO_DATE;
  552. if (ns.pdsk == D_CONSISTENT || ns.pdsk == D_OUTDATED)
  553. ns.pdsk = D_UP_TO_DATE;
  554. }
  555. /* Implications of the connection stat on the disk states */
  556. disk_min = D_DISKLESS;
  557. disk_max = D_UP_TO_DATE;
  558. pdsk_min = D_INCONSISTENT;
  559. pdsk_max = D_UNKNOWN;
  560. switch ((enum drbd_conns)ns.conn) {
  561. case C_WF_BITMAP_T:
  562. case C_PAUSED_SYNC_T:
  563. case C_STARTING_SYNC_T:
  564. case C_WF_SYNC_UUID:
  565. case C_BEHIND:
  566. disk_min = D_INCONSISTENT;
  567. disk_max = D_OUTDATED;
  568. pdsk_min = D_UP_TO_DATE;
  569. pdsk_max = D_UP_TO_DATE;
  570. break;
  571. case C_VERIFY_S:
  572. case C_VERIFY_T:
  573. disk_min = D_UP_TO_DATE;
  574. disk_max = D_UP_TO_DATE;
  575. pdsk_min = D_UP_TO_DATE;
  576. pdsk_max = D_UP_TO_DATE;
  577. break;
  578. case C_CONNECTED:
  579. disk_min = D_DISKLESS;
  580. disk_max = D_UP_TO_DATE;
  581. pdsk_min = D_DISKLESS;
  582. pdsk_max = D_UP_TO_DATE;
  583. break;
  584. case C_WF_BITMAP_S:
  585. case C_PAUSED_SYNC_S:
  586. case C_STARTING_SYNC_S:
  587. case C_AHEAD:
  588. disk_min = D_UP_TO_DATE;
  589. disk_max = D_UP_TO_DATE;
  590. pdsk_min = D_INCONSISTENT;
  591. pdsk_max = D_CONSISTENT; /* D_OUTDATED would be nice. But explicit outdate necessary*/
  592. break;
  593. case C_SYNC_TARGET:
  594. disk_min = D_INCONSISTENT;
  595. disk_max = D_INCONSISTENT;
  596. pdsk_min = D_UP_TO_DATE;
  597. pdsk_max = D_UP_TO_DATE;
  598. break;
  599. case C_SYNC_SOURCE:
  600. disk_min = D_UP_TO_DATE;
  601. disk_max = D_UP_TO_DATE;
  602. pdsk_min = D_INCONSISTENT;
  603. pdsk_max = D_INCONSISTENT;
  604. break;
  605. case C_STANDALONE:
  606. case C_DISCONNECTING:
  607. case C_UNCONNECTED:
  608. case C_TIMEOUT:
  609. case C_BROKEN_PIPE:
  610. case C_NETWORK_FAILURE:
  611. case C_PROTOCOL_ERROR:
  612. case C_TEAR_DOWN:
  613. case C_WF_CONNECTION:
  614. case C_WF_REPORT_PARAMS:
  615. case C_MASK:
  616. break;
  617. }
  618. if (ns.disk > disk_max)
  619. ns.disk = disk_max;
  620. if (ns.disk < disk_min) {
  621. dev_warn(DEV, "Implicitly set disk from %s to %s\n",
  622. drbd_disk_str(ns.disk), drbd_disk_str(disk_min));
  623. ns.disk = disk_min;
  624. }
  625. if (ns.pdsk > pdsk_max)
  626. ns.pdsk = pdsk_max;
  627. if (ns.pdsk < pdsk_min) {
  628. dev_warn(DEV, "Implicitly set pdsk from %s to %s\n",
  629. drbd_disk_str(ns.pdsk), drbd_disk_str(pdsk_min));
  630. ns.pdsk = pdsk_min;
  631. }
  632. if (fp == FP_STONITH &&
  633. (ns.role == R_PRIMARY && ns.conn < C_CONNECTED && ns.pdsk > D_OUTDATED))
  634. ns.susp_fen = 1; /* Suspend IO while fence-peer handler runs (peer lost) */
  635. if (mdev->tconn->res_opts.on_no_data == OND_SUSPEND_IO &&
  636. (ns.role == R_PRIMARY && ns.disk < D_UP_TO_DATE && ns.pdsk < D_UP_TO_DATE))
  637. ns.susp_nod = 1; /* Suspend IO while no data available (no accessible data available) */
  638. if (ns.aftr_isp || ns.peer_isp || ns.user_isp) {
  639. if (ns.conn == C_SYNC_SOURCE)
  640. ns.conn = C_PAUSED_SYNC_S;
  641. if (ns.conn == C_SYNC_TARGET)
  642. ns.conn = C_PAUSED_SYNC_T;
  643. } else {
  644. if (ns.conn == C_PAUSED_SYNC_S)
  645. ns.conn = C_SYNC_SOURCE;
  646. if (ns.conn == C_PAUSED_SYNC_T)
  647. ns.conn = C_SYNC_TARGET;
  648. }
  649. return ns;
  650. }
  651. void drbd_resume_al(struct drbd_conf *mdev)
  652. {
  653. if (test_and_clear_bit(AL_SUSPENDED, &mdev->flags))
  654. dev_info(DEV, "Resumed AL updates\n");
  655. }
  656. /* helper for __drbd_set_state */
  657. static void set_ov_position(struct drbd_conf *mdev, enum drbd_conns cs)
  658. {
  659. if (mdev->tconn->agreed_pro_version < 90)
  660. mdev->ov_start_sector = 0;
  661. mdev->rs_total = drbd_bm_bits(mdev);
  662. mdev->ov_position = 0;
  663. if (cs == C_VERIFY_T) {
  664. /* starting online verify from an arbitrary position
  665. * does not fit well into the existing protocol.
  666. * on C_VERIFY_T, we initialize ov_left and friends
  667. * implicitly in receive_DataRequest once the
  668. * first P_OV_REQUEST is received */
  669. mdev->ov_start_sector = ~(sector_t)0;
  670. } else {
  671. unsigned long bit = BM_SECT_TO_BIT(mdev->ov_start_sector);
  672. if (bit >= mdev->rs_total) {
  673. mdev->ov_start_sector =
  674. BM_BIT_TO_SECT(mdev->rs_total - 1);
  675. mdev->rs_total = 1;
  676. } else
  677. mdev->rs_total -= bit;
  678. mdev->ov_position = mdev->ov_start_sector;
  679. }
  680. mdev->ov_left = mdev->rs_total;
  681. }
  682. /**
  683. * __drbd_set_state() - Set a new DRBD state
  684. * @mdev: DRBD device.
  685. * @ns: new state.
  686. * @flags: Flags
  687. * @done: Optional completion, that will get completed after the after_state_ch() finished
  688. *
  689. * Caller needs to hold req_lock, and global_state_lock. Do not call directly.
  690. */
  691. enum drbd_state_rv
  692. __drbd_set_state(struct drbd_conf *mdev, union drbd_state ns,
  693. enum chg_state_flags flags, struct completion *done)
  694. {
  695. union drbd_state os;
  696. enum drbd_state_rv rv = SS_SUCCESS;
  697. const char *warn_sync_abort = NULL;
  698. struct after_state_chg_work *ascw;
  699. os = drbd_read_state(mdev);
  700. ns = sanitize_state(mdev, ns, &warn_sync_abort);
  701. if (ns.i == os.i)
  702. return SS_NOTHING_TO_DO;
  703. rv = is_valid_transition(os, ns);
  704. if (rv < SS_SUCCESS)
  705. return rv;
  706. if (!(flags & CS_HARD)) {
  707. /* pre-state-change checks ; only look at ns */
  708. /* See drbd_state_sw_errors in drbd_strings.c */
  709. rv = is_valid_state(mdev, ns);
  710. if (rv < SS_SUCCESS) {
  711. /* If the old state was illegal as well, then let
  712. this happen...*/
  713. if (is_valid_state(mdev, os) == rv)
  714. rv = is_valid_soft_transition(os, ns);
  715. } else
  716. rv = is_valid_soft_transition(os, ns);
  717. }
  718. if (rv < SS_SUCCESS) {
  719. if (flags & CS_VERBOSE)
  720. print_st_err(mdev, os, ns, rv);
  721. return rv;
  722. }
  723. if (warn_sync_abort)
  724. dev_warn(DEV, "%s aborted.\n", warn_sync_abort);
  725. drbd_pr_state_change(mdev, os, ns, flags);
  726. /* if we are going -> D_FAILED or D_DISKLESS, grab one extra reference
  727. * on the ldev here, to be sure the transition -> D_DISKLESS resp.
  728. * drbd_ldev_destroy() won't happen before our corresponding
  729. * after_state_ch works run, where we put_ldev again. */
  730. if ((os.disk != D_FAILED && ns.disk == D_FAILED) ||
  731. (os.disk != D_DISKLESS && ns.disk == D_DISKLESS))
  732. atomic_inc(&mdev->local_cnt);
  733. mdev->state = ns;
  734. mdev->tconn->susp = ns.susp;
  735. mdev->tconn->susp_nod = ns.susp_nod;
  736. mdev->tconn->susp_fen = ns.susp_fen;
  737. /* solve the race between becoming unconfigured,
  738. * worker doing the cleanup, and
  739. * admin reconfiguring us:
  740. * on (re)configure, first set CONFIG_PENDING,
  741. * then wait for a potentially exiting worker,
  742. * start the worker, and schedule one no_op.
  743. * then proceed with configuration.
  744. */
  745. if(conn_all_vols_unconf(mdev->tconn) &&
  746. !test_and_set_bit(CONFIG_PENDING, &mdev->tconn->flags))
  747. set_bit(OBJECT_DYING, &mdev->tconn->flags);
  748. if (os.disk == D_ATTACHING && ns.disk >= D_NEGOTIATING)
  749. drbd_print_uuids(mdev, "attached to UUIDs");
  750. wake_up(&mdev->misc_wait);
  751. wake_up(&mdev->state_wait);
  752. wake_up(&mdev->tconn->ping_wait);
  753. /* aborted verify run. log the last position */
  754. if ((os.conn == C_VERIFY_S || os.conn == C_VERIFY_T) &&
  755. ns.conn < C_CONNECTED) {
  756. mdev->ov_start_sector =
  757. BM_BIT_TO_SECT(drbd_bm_bits(mdev) - mdev->ov_left);
  758. dev_info(DEV, "Online Verify reached sector %llu\n",
  759. (unsigned long long)mdev->ov_start_sector);
  760. }
  761. if ((os.conn == C_PAUSED_SYNC_T || os.conn == C_PAUSED_SYNC_S) &&
  762. (ns.conn == C_SYNC_TARGET || ns.conn == C_SYNC_SOURCE)) {
  763. dev_info(DEV, "Syncer continues.\n");
  764. mdev->rs_paused += (long)jiffies
  765. -(long)mdev->rs_mark_time[mdev->rs_last_mark];
  766. if (ns.conn == C_SYNC_TARGET)
  767. mod_timer(&mdev->resync_timer, jiffies);
  768. }
  769. if ((os.conn == C_SYNC_TARGET || os.conn == C_SYNC_SOURCE) &&
  770. (ns.conn == C_PAUSED_SYNC_T || ns.conn == C_PAUSED_SYNC_S)) {
  771. dev_info(DEV, "Resync suspended\n");
  772. mdev->rs_mark_time[mdev->rs_last_mark] = jiffies;
  773. }
  774. if (os.conn == C_CONNECTED &&
  775. (ns.conn == C_VERIFY_S || ns.conn == C_VERIFY_T)) {
  776. unsigned long now = jiffies;
  777. int i;
  778. set_ov_position(mdev, ns.conn);
  779. mdev->rs_start = now;
  780. mdev->rs_last_events = 0;
  781. mdev->rs_last_sect_ev = 0;
  782. mdev->ov_last_oos_size = 0;
  783. mdev->ov_last_oos_start = 0;
  784. for (i = 0; i < DRBD_SYNC_MARKS; i++) {
  785. mdev->rs_mark_left[i] = mdev->ov_left;
  786. mdev->rs_mark_time[i] = now;
  787. }
  788. drbd_rs_controller_reset(mdev);
  789. if (ns.conn == C_VERIFY_S) {
  790. dev_info(DEV, "Starting Online Verify from sector %llu\n",
  791. (unsigned long long)mdev->ov_position);
  792. mod_timer(&mdev->resync_timer, jiffies);
  793. }
  794. }
  795. if (get_ldev(mdev)) {
  796. u32 mdf = mdev->ldev->md.flags & ~(MDF_CONSISTENT|MDF_PRIMARY_IND|
  797. MDF_CONNECTED_IND|MDF_WAS_UP_TO_DATE|
  798. MDF_PEER_OUT_DATED|MDF_CRASHED_PRIMARY);
  799. if (test_bit(CRASHED_PRIMARY, &mdev->flags))
  800. mdf |= MDF_CRASHED_PRIMARY;
  801. if (mdev->state.role == R_PRIMARY ||
  802. (mdev->state.pdsk < D_INCONSISTENT && mdev->state.peer == R_PRIMARY))
  803. mdf |= MDF_PRIMARY_IND;
  804. if (mdev->state.conn > C_WF_REPORT_PARAMS)
  805. mdf |= MDF_CONNECTED_IND;
  806. if (mdev->state.disk > D_INCONSISTENT)
  807. mdf |= MDF_CONSISTENT;
  808. if (mdev->state.disk > D_OUTDATED)
  809. mdf |= MDF_WAS_UP_TO_DATE;
  810. if (mdev->state.pdsk <= D_OUTDATED && mdev->state.pdsk >= D_INCONSISTENT)
  811. mdf |= MDF_PEER_OUT_DATED;
  812. if (mdf != mdev->ldev->md.flags) {
  813. mdev->ldev->md.flags = mdf;
  814. drbd_md_mark_dirty(mdev);
  815. }
  816. if (os.disk < D_CONSISTENT && ns.disk >= D_CONSISTENT)
  817. drbd_set_ed_uuid(mdev, mdev->ldev->md.uuid[UI_CURRENT]);
  818. put_ldev(mdev);
  819. }
  820. /* Peer was forced D_UP_TO_DATE & R_PRIMARY, consider to resync */
  821. if (os.disk == D_INCONSISTENT && os.pdsk == D_INCONSISTENT &&
  822. os.peer == R_SECONDARY && ns.peer == R_PRIMARY)
  823. set_bit(CONSIDER_RESYNC, &mdev->flags);
  824. /* Receiver should clean up itself */
  825. if (os.conn != C_DISCONNECTING && ns.conn == C_DISCONNECTING)
  826. drbd_thread_stop_nowait(&mdev->tconn->receiver);
  827. /* Now the receiver finished cleaning up itself, it should die */
  828. if (os.conn != C_STANDALONE && ns.conn == C_STANDALONE)
  829. drbd_thread_stop_nowait(&mdev->tconn->receiver);
  830. /* Upon network failure, we need to restart the receiver. */
  831. if (os.conn > C_TEAR_DOWN &&
  832. ns.conn <= C_TEAR_DOWN && ns.conn >= C_TIMEOUT)
  833. drbd_thread_restart_nowait(&mdev->tconn->receiver);
  834. /* Resume AL writing if we get a connection */
  835. if (os.conn < C_CONNECTED && ns.conn >= C_CONNECTED)
  836. drbd_resume_al(mdev);
  837. ascw = kmalloc(sizeof(*ascw), GFP_ATOMIC);
  838. if (ascw) {
  839. ascw->os = os;
  840. ascw->ns = ns;
  841. ascw->flags = flags;
  842. ascw->w.cb = w_after_state_ch;
  843. ascw->w.mdev = mdev;
  844. ascw->done = done;
  845. drbd_queue_work(&mdev->tconn->data.work, &ascw->w);
  846. } else {
  847. dev_err(DEV, "Could not kmalloc an ascw\n");
  848. }
  849. return rv;
  850. }
  851. static int w_after_state_ch(struct drbd_work *w, int unused)
  852. {
  853. struct after_state_chg_work *ascw =
  854. container_of(w, struct after_state_chg_work, w);
  855. struct drbd_conf *mdev = w->mdev;
  856. after_state_ch(mdev, ascw->os, ascw->ns, ascw->flags);
  857. if (ascw->flags & CS_WAIT_COMPLETE) {
  858. D_ASSERT(ascw->done != NULL);
  859. complete(ascw->done);
  860. }
  861. kfree(ascw);
  862. return 0;
  863. }
  864. static void abw_start_sync(struct drbd_conf *mdev, int rv)
  865. {
  866. if (rv) {
  867. dev_err(DEV, "Writing the bitmap failed not starting resync.\n");
  868. _drbd_request_state(mdev, NS(conn, C_CONNECTED), CS_VERBOSE);
  869. return;
  870. }
  871. switch (mdev->state.conn) {
  872. case C_STARTING_SYNC_T:
  873. _drbd_request_state(mdev, NS(conn, C_WF_SYNC_UUID), CS_VERBOSE);
  874. break;
  875. case C_STARTING_SYNC_S:
  876. drbd_start_resync(mdev, C_SYNC_SOURCE);
  877. break;
  878. }
  879. }
  880. int drbd_bitmap_io_from_worker(struct drbd_conf *mdev,
  881. int (*io_fn)(struct drbd_conf *),
  882. char *why, enum bm_flag flags)
  883. {
  884. int rv;
  885. D_ASSERT(current == mdev->tconn->worker.task);
  886. /* open coded non-blocking drbd_suspend_io(mdev); */
  887. set_bit(SUSPEND_IO, &mdev->flags);
  888. drbd_bm_lock(mdev, why, flags);
  889. rv = io_fn(mdev);
  890. drbd_bm_unlock(mdev);
  891. drbd_resume_io(mdev);
  892. return rv;
  893. }
  894. /**
  895. * after_state_ch() - Perform after state change actions that may sleep
  896. * @mdev: DRBD device.
  897. * @os: old state.
  898. * @ns: new state.
  899. * @flags: Flags
  900. */
  901. static void after_state_ch(struct drbd_conf *mdev, union drbd_state os,
  902. union drbd_state ns, enum chg_state_flags flags)
  903. {
  904. enum drbd_fencing_p fp;
  905. enum drbd_req_event what = NOTHING;
  906. union drbd_state nsm;
  907. struct sib_info sib;
  908. sib.sib_reason = SIB_STATE_CHANGE;
  909. sib.os = os;
  910. sib.ns = ns;
  911. if (os.conn != C_CONNECTED && ns.conn == C_CONNECTED) {
  912. clear_bit(CRASHED_PRIMARY, &mdev->flags);
  913. if (mdev->p_uuid)
  914. mdev->p_uuid[UI_FLAGS] &= ~((u64)2);
  915. }
  916. fp = FP_DONT_CARE;
  917. if (get_ldev(mdev)) {
  918. fp = mdev->ldev->dc.fencing;
  919. put_ldev(mdev);
  920. }
  921. /* Inform userspace about the change... */
  922. drbd_bcast_event(mdev, &sib);
  923. if (!(os.role == R_PRIMARY && os.disk < D_UP_TO_DATE && os.pdsk < D_UP_TO_DATE) &&
  924. (ns.role == R_PRIMARY && ns.disk < D_UP_TO_DATE && ns.pdsk < D_UP_TO_DATE))
  925. drbd_khelper(mdev, "pri-on-incon-degr");
  926. /* Here we have the actions that are performed after a
  927. state change. This function might sleep */
  928. nsm.i = -1;
  929. if (ns.susp_nod) {
  930. if (os.conn < C_CONNECTED && ns.conn >= C_CONNECTED)
  931. what = RESEND;
  932. if (os.disk == D_ATTACHING && ns.disk > D_ATTACHING)
  933. what = RESTART_FROZEN_DISK_IO;
  934. if (what != NOTHING)
  935. nsm.susp_nod = 0;
  936. }
  937. if (ns.susp_fen) {
  938. /* case1: The outdate peer handler is successful: */
  939. if (os.pdsk > D_OUTDATED && ns.pdsk <= D_OUTDATED) {
  940. tl_clear(mdev->tconn);
  941. if (test_bit(NEW_CUR_UUID, &mdev->flags)) {
  942. drbd_uuid_new_current(mdev);
  943. clear_bit(NEW_CUR_UUID, &mdev->flags);
  944. }
  945. spin_lock_irq(&mdev->tconn->req_lock);
  946. _drbd_set_state(_NS(mdev, susp_fen, 0), CS_VERBOSE, NULL);
  947. spin_unlock_irq(&mdev->tconn->req_lock);
  948. }
  949. /* case2: The connection was established again: */
  950. if (os.conn < C_CONNECTED && ns.conn >= C_CONNECTED) {
  951. clear_bit(NEW_CUR_UUID, &mdev->flags);
  952. what = RESEND;
  953. nsm.susp_fen = 0;
  954. }
  955. }
  956. if (what != NOTHING) {
  957. spin_lock_irq(&mdev->tconn->req_lock);
  958. _tl_restart(mdev->tconn, what);
  959. nsm.i &= mdev->state.i;
  960. _drbd_set_state(mdev, nsm, CS_VERBOSE, NULL);
  961. spin_unlock_irq(&mdev->tconn->req_lock);
  962. }
  963. /* Became sync source. With protocol >= 96, we still need to send out
  964. * the sync uuid now. Need to do that before any drbd_send_state, or
  965. * the other side may go "paused sync" before receiving the sync uuids,
  966. * which is unexpected. */
  967. if ((os.conn != C_SYNC_SOURCE && os.conn != C_PAUSED_SYNC_S) &&
  968. (ns.conn == C_SYNC_SOURCE || ns.conn == C_PAUSED_SYNC_S) &&
  969. mdev->tconn->agreed_pro_version >= 96 && get_ldev(mdev)) {
  970. drbd_gen_and_send_sync_uuid(mdev);
  971. put_ldev(mdev);
  972. }
  973. /* Do not change the order of the if above and the two below... */
  974. if (os.pdsk == D_DISKLESS && ns.pdsk > D_DISKLESS) { /* attach on the peer */
  975. drbd_send_uuids(mdev);
  976. drbd_send_state(mdev);
  977. }
  978. /* No point in queuing send_bitmap if we don't have a connection
  979. * anymore, so check also the _current_ state, not only the new state
  980. * at the time this work was queued. */
  981. if (os.conn != C_WF_BITMAP_S && ns.conn == C_WF_BITMAP_S &&
  982. mdev->state.conn == C_WF_BITMAP_S)
  983. drbd_queue_bitmap_io(mdev, &drbd_send_bitmap, NULL,
  984. "send_bitmap (WFBitMapS)",
  985. BM_LOCKED_TEST_ALLOWED);
  986. /* Lost contact to peer's copy of the data */
  987. if ((os.pdsk >= D_INCONSISTENT &&
  988. os.pdsk != D_UNKNOWN &&
  989. os.pdsk != D_OUTDATED)
  990. && (ns.pdsk < D_INCONSISTENT ||
  991. ns.pdsk == D_UNKNOWN ||
  992. ns.pdsk == D_OUTDATED)) {
  993. if (get_ldev(mdev)) {
  994. if ((ns.role == R_PRIMARY || ns.peer == R_PRIMARY) &&
  995. mdev->ldev->md.uuid[UI_BITMAP] == 0 && ns.disk >= D_UP_TO_DATE) {
  996. if (drbd_suspended(mdev)) {
  997. set_bit(NEW_CUR_UUID, &mdev->flags);
  998. } else {
  999. drbd_uuid_new_current(mdev);
  1000. drbd_send_uuids(mdev);
  1001. }
  1002. }
  1003. put_ldev(mdev);
  1004. }
  1005. }
  1006. if (ns.pdsk < D_INCONSISTENT && get_ldev(mdev)) {
  1007. if (ns.peer == R_PRIMARY && mdev->ldev->md.uuid[UI_BITMAP] == 0) {
  1008. drbd_uuid_new_current(mdev);
  1009. drbd_send_uuids(mdev);
  1010. }
  1011. /* D_DISKLESS Peer becomes secondary */
  1012. if (os.peer == R_PRIMARY && ns.peer == R_SECONDARY)
  1013. /* We may still be Primary ourselves.
  1014. * No harm done if the bitmap still changes,
  1015. * redirtied pages will follow later. */
  1016. drbd_bitmap_io_from_worker(mdev, &drbd_bm_write,
  1017. "demote diskless peer", BM_LOCKED_SET_ALLOWED);
  1018. put_ldev(mdev);
  1019. }
  1020. /* Write out all changed bits on demote.
  1021. * Though, no need to da that just yet
  1022. * if there is a resync going on still */
  1023. if (os.role == R_PRIMARY && ns.role == R_SECONDARY &&
  1024. mdev->state.conn <= C_CONNECTED && get_ldev(mdev)) {
  1025. /* No changes to the bitmap expected this time, so assert that,
  1026. * even though no harm was done if it did change. */
  1027. drbd_bitmap_io_from_worker(mdev, &drbd_bm_write,
  1028. "demote", BM_LOCKED_TEST_ALLOWED);
  1029. put_ldev(mdev);
  1030. }
  1031. /* Last part of the attaching process ... */
  1032. if (ns.conn >= C_CONNECTED &&
  1033. os.disk == D_ATTACHING && ns.disk == D_NEGOTIATING) {
  1034. drbd_send_sizes(mdev, 0, 0); /* to start sync... */
  1035. drbd_send_uuids(mdev);
  1036. drbd_send_state(mdev);
  1037. }
  1038. /* We want to pause/continue resync, tell peer. */
  1039. if (ns.conn >= C_CONNECTED &&
  1040. ((os.aftr_isp != ns.aftr_isp) ||
  1041. (os.user_isp != ns.user_isp)))
  1042. drbd_send_state(mdev);
  1043. /* In case one of the isp bits got set, suspend other devices. */
  1044. if ((!os.aftr_isp && !os.peer_isp && !os.user_isp) &&
  1045. (ns.aftr_isp || ns.peer_isp || ns.user_isp))
  1046. suspend_other_sg(mdev);
  1047. /* Make sure the peer gets informed about eventual state
  1048. changes (ISP bits) while we were in WFReportParams. */
  1049. if (os.conn == C_WF_REPORT_PARAMS && ns.conn >= C_CONNECTED)
  1050. drbd_send_state(mdev);
  1051. if (os.conn != C_AHEAD && ns.conn == C_AHEAD)
  1052. drbd_send_state(mdev);
  1053. /* We are in the progress to start a full sync... */
  1054. if ((os.conn != C_STARTING_SYNC_T && ns.conn == C_STARTING_SYNC_T) ||
  1055. (os.conn != C_STARTING_SYNC_S && ns.conn == C_STARTING_SYNC_S))
  1056. /* no other bitmap changes expected during this phase */
  1057. drbd_queue_bitmap_io(mdev,
  1058. &drbd_bmio_set_n_write, &abw_start_sync,
  1059. "set_n_write from StartingSync", BM_LOCKED_TEST_ALLOWED);
  1060. /* We are invalidating our self... */
  1061. if (os.conn < C_CONNECTED && ns.conn < C_CONNECTED &&
  1062. os.disk > D_INCONSISTENT && ns.disk == D_INCONSISTENT)
  1063. /* other bitmap operation expected during this phase */
  1064. drbd_queue_bitmap_io(mdev, &drbd_bmio_set_n_write, NULL,
  1065. "set_n_write from invalidate", BM_LOCKED_MASK);
  1066. /* first half of local IO error, failure to attach,
  1067. * or administrative detach */
  1068. if (os.disk != D_FAILED && ns.disk == D_FAILED) {
  1069. enum drbd_io_error_p eh;
  1070. int was_io_error;
  1071. /* corresponding get_ldev was in __drbd_set_state, to serialize
  1072. * our cleanup here with the transition to D_DISKLESS,
  1073. * so it is safe to dreference ldev here. */
  1074. eh = mdev->ldev->dc.on_io_error;
  1075. was_io_error = test_and_clear_bit(WAS_IO_ERROR, &mdev->flags);
  1076. /* current state still has to be D_FAILED,
  1077. * there is only one way out: to D_DISKLESS,
  1078. * and that may only happen after our put_ldev below. */
  1079. if (mdev->state.disk != D_FAILED)
  1080. dev_err(DEV,
  1081. "ASSERT FAILED: disk is %s during detach\n",
  1082. drbd_disk_str(mdev->state.disk));
  1083. if (!drbd_send_state(mdev))
  1084. dev_warn(DEV, "Notified peer that I am detaching my disk\n");
  1085. else
  1086. dev_err(DEV, "Sending state for detaching disk failed\n");
  1087. drbd_rs_cancel_all(mdev);
  1088. /* In case we want to get something to stable storage still,
  1089. * this may be the last chance.
  1090. * Following put_ldev may transition to D_DISKLESS. */
  1091. drbd_md_sync(mdev);
  1092. put_ldev(mdev);
  1093. if (was_io_error && eh == EP_CALL_HELPER)
  1094. drbd_khelper(mdev, "local-io-error");
  1095. }
  1096. /* second half of local IO error, failure to attach,
  1097. * or administrative detach,
  1098. * after local_cnt references have reached zero again */
  1099. if (os.disk != D_DISKLESS && ns.disk == D_DISKLESS) {
  1100. /* We must still be diskless,
  1101. * re-attach has to be serialized with this! */
  1102. if (mdev->state.disk != D_DISKLESS)
  1103. dev_err(DEV,
  1104. "ASSERT FAILED: disk is %s while going diskless\n",
  1105. drbd_disk_str(mdev->state.disk));
  1106. mdev->rs_total = 0;
  1107. mdev->rs_failed = 0;
  1108. atomic_set(&mdev->rs_pending_cnt, 0);
  1109. if (!drbd_send_state(mdev))
  1110. dev_warn(DEV, "Notified peer that I'm now diskless.\n");
  1111. /* corresponding get_ldev in __drbd_set_state
  1112. * this may finally trigger drbd_ldev_destroy. */
  1113. put_ldev(mdev);
  1114. }
  1115. /* Notify peer that I had a local IO error, and did not detached.. */
  1116. if (os.disk == D_UP_TO_DATE && ns.disk == D_INCONSISTENT)
  1117. drbd_send_state(mdev);
  1118. /* Disks got bigger while they were detached */
  1119. if (ns.disk > D_NEGOTIATING && ns.pdsk > D_NEGOTIATING &&
  1120. test_and_clear_bit(RESYNC_AFTER_NEG, &mdev->flags)) {
  1121. if (ns.conn == C_CONNECTED)
  1122. resync_after_online_grow(mdev);
  1123. }
  1124. /* A resync finished or aborted, wake paused devices... */
  1125. if ((os.conn > C_CONNECTED && ns.conn <= C_CONNECTED) ||
  1126. (os.peer_isp && !ns.peer_isp) ||
  1127. (os.user_isp && !ns.user_isp))
  1128. resume_next_sg(mdev);
  1129. /* sync target done with resync. Explicitly notify peer, even though
  1130. * it should (at least for non-empty resyncs) already know itself. */
  1131. if (os.disk < D_UP_TO_DATE && os.conn >= C_SYNC_SOURCE && ns.conn == C_CONNECTED)
  1132. drbd_send_state(mdev);
  1133. /* This triggers bitmap writeout of potentially still unwritten pages
  1134. * if the resync finished cleanly, or aborted because of peer disk
  1135. * failure, or because of connection loss.
  1136. * For resync aborted because of local disk failure, we cannot do
  1137. * any bitmap writeout anymore.
  1138. * No harm done if some bits change during this phase.
  1139. */
  1140. if (os.conn > C_CONNECTED && ns.conn <= C_CONNECTED && get_ldev(mdev)) {
  1141. drbd_queue_bitmap_io(mdev, &drbd_bm_write, NULL,
  1142. "write from resync_finished", BM_LOCKED_SET_ALLOWED);
  1143. put_ldev(mdev);
  1144. }
  1145. if (ns.disk == D_DISKLESS &&
  1146. ns.conn == C_STANDALONE &&
  1147. ns.role == R_SECONDARY) {
  1148. if (os.aftr_isp != ns.aftr_isp)
  1149. resume_next_sg(mdev);
  1150. }
  1151. after_all_state_ch(mdev->tconn);
  1152. drbd_md_sync(mdev);
  1153. }
  1154. struct after_conn_state_chg_work {
  1155. struct drbd_work w;
  1156. enum drbd_conns oc;
  1157. union drbd_state nms; /* new, max state, over all mdevs */
  1158. enum chg_state_flags flags;
  1159. };
  1160. static void after_all_state_ch(struct drbd_tconn *tconn)
  1161. {
  1162. if (conn_all_vols_unconf(tconn) &&
  1163. test_bit(OBJECT_DYING, &tconn->flags)) {
  1164. drbd_thread_stop_nowait(&tconn->worker);
  1165. }
  1166. }
  1167. static int w_after_conn_state_ch(struct drbd_work *w, int unused)
  1168. {
  1169. struct after_conn_state_chg_work *acscw =
  1170. container_of(w, struct after_conn_state_chg_work, w);
  1171. struct drbd_tconn *tconn = w->tconn;
  1172. enum drbd_conns oc = acscw->oc;
  1173. union drbd_state nms = acscw->nms;
  1174. kfree(acscw);
  1175. /* Upon network configuration, we need to start the receiver */
  1176. if (oc == C_STANDALONE && nms.conn == C_UNCONNECTED)
  1177. drbd_thread_start(&tconn->receiver);
  1178. //conn_err(tconn, STATE_FMT, STATE_ARGS("nms", nms));
  1179. after_all_state_ch(tconn);
  1180. return 0;
  1181. }
  1182. void conn_old_common_state(struct drbd_tconn *tconn, union drbd_state *pcs, enum chg_state_flags *pf)
  1183. {
  1184. enum chg_state_flags flags = ~0;
  1185. union drbd_state os, cs = {}; /* old_state, common_state */
  1186. struct drbd_conf *mdev;
  1187. int vnr, first_vol = 1;
  1188. idr_for_each_entry(&tconn->volumes, mdev, vnr) {
  1189. os = mdev->state;
  1190. if (first_vol) {
  1191. cs = os;
  1192. first_vol = 0;
  1193. continue;
  1194. }
  1195. if (cs.role != os.role)
  1196. flags &= ~CS_DC_ROLE;
  1197. if (cs.peer != os.peer)
  1198. flags &= ~CS_DC_PEER;
  1199. if (cs.conn != os.conn)
  1200. flags &= ~CS_DC_CONN;
  1201. if (cs.disk != os.disk)
  1202. flags &= ~CS_DC_DISK;
  1203. if (cs.pdsk != os.pdsk)
  1204. flags &= ~CS_DC_PDSK;
  1205. }
  1206. *pf |= CS_DC_MASK;
  1207. *pf &= flags;
  1208. *pcs = cs;
  1209. }
  1210. static enum drbd_state_rv
  1211. conn_is_valid_transition(struct drbd_tconn *tconn, union drbd_state mask, union drbd_state val,
  1212. enum chg_state_flags flags)
  1213. {
  1214. enum drbd_state_rv rv = SS_SUCCESS;
  1215. union drbd_state ns, os;
  1216. struct drbd_conf *mdev;
  1217. int vnr;
  1218. idr_for_each_entry(&tconn->volumes, mdev, vnr) {
  1219. os = drbd_read_state(mdev);
  1220. ns = sanitize_state(mdev, apply_mask_val(os, mask, val), NULL);
  1221. if (flags & CS_IGN_OUTD_FAIL && ns.disk == D_OUTDATED && os.disk < D_OUTDATED)
  1222. ns.disk = os.disk;
  1223. if (ns.i == os.i)
  1224. continue;
  1225. rv = is_valid_transition(os, ns);
  1226. if (rv < SS_SUCCESS)
  1227. break;
  1228. if (!(flags & CS_HARD)) {
  1229. rv = is_valid_state(mdev, ns);
  1230. if (rv < SS_SUCCESS) {
  1231. if (is_valid_state(mdev, os) == rv)
  1232. rv = is_valid_soft_transition(os, ns);
  1233. } else
  1234. rv = is_valid_soft_transition(os, ns);
  1235. }
  1236. if (rv < SS_SUCCESS)
  1237. break;
  1238. }
  1239. if (rv < SS_SUCCESS && flags & CS_VERBOSE)
  1240. print_st_err(mdev, os, ns, rv);
  1241. return rv;
  1242. }
  1243. static union drbd_state
  1244. conn_set_state(struct drbd_tconn *tconn, union drbd_state mask, union drbd_state val,
  1245. enum chg_state_flags flags)
  1246. {
  1247. union drbd_state ns, os, ms = { };
  1248. struct drbd_conf *mdev;
  1249. enum drbd_state_rv rv;
  1250. int vnr;
  1251. if (mask.conn == C_MASK)
  1252. tconn->cstate = val.conn;
  1253. idr_for_each_entry(&tconn->volumes, mdev, vnr) {
  1254. os = drbd_read_state(mdev);
  1255. ns = apply_mask_val(os, mask, val);
  1256. ns = sanitize_state(mdev, ns, NULL);
  1257. if (flags & CS_IGN_OUTD_FAIL && ns.disk == D_OUTDATED && os.disk < D_OUTDATED)
  1258. ns.disk = os.disk;
  1259. rv = __drbd_set_state(mdev, ns, flags, NULL);
  1260. if (rv < SS_SUCCESS)
  1261. BUG();
  1262. ms.role = max_role(mdev->state.role, ms.role);
  1263. ms.peer = max_role(mdev->state.peer, ms.peer);
  1264. ms.disk = max_t(enum drbd_disk_state, mdev->state.disk, ms.disk);
  1265. ms.pdsk = max_t(enum drbd_disk_state, mdev->state.pdsk, ms.pdsk);
  1266. }
  1267. return ms;
  1268. }
  1269. static enum drbd_state_rv
  1270. _conn_rq_cond(struct drbd_tconn *tconn, union drbd_state mask, union drbd_state val)
  1271. {
  1272. enum drbd_state_rv rv;
  1273. if (test_and_clear_bit(CONN_WD_ST_CHG_OKAY, &tconn->flags))
  1274. return SS_CW_SUCCESS;
  1275. if (test_and_clear_bit(CONN_WD_ST_CHG_FAIL, &tconn->flags))
  1276. return SS_CW_FAILED_BY_PEER;
  1277. spin_lock_irq(&tconn->req_lock);
  1278. rv = tconn->cstate != C_WF_REPORT_PARAMS ? SS_CW_NO_NEED : SS_UNKNOWN_ERROR;
  1279. if (rv == SS_UNKNOWN_ERROR)
  1280. rv = conn_is_valid_transition(tconn, mask, val, 0);
  1281. if (rv == SS_SUCCESS)
  1282. rv = SS_UNKNOWN_ERROR; /* cont waiting, otherwise fail. */
  1283. spin_unlock_irq(&tconn->req_lock);
  1284. return rv;
  1285. }
  1286. static enum drbd_state_rv
  1287. conn_cl_wide(struct drbd_tconn *tconn, union drbd_state mask, union drbd_state val,
  1288. enum chg_state_flags f)
  1289. {
  1290. enum drbd_state_rv rv;
  1291. spin_unlock_irq(&tconn->req_lock);
  1292. mutex_lock(&tconn->cstate_mutex);
  1293. if (conn_send_state_req(tconn, mask, val)) {
  1294. rv = SS_CW_FAILED_BY_PEER;
  1295. /* if (f & CS_VERBOSE)
  1296. print_st_err(mdev, os, ns, rv); */
  1297. goto abort;
  1298. }
  1299. wait_event(tconn->ping_wait, (rv = _conn_rq_cond(tconn, mask, val)));
  1300. abort:
  1301. mutex_unlock(&tconn->cstate_mutex);
  1302. spin_lock_irq(&tconn->req_lock);
  1303. return rv;
  1304. }
  1305. enum drbd_state_rv
  1306. _conn_request_state(struct drbd_tconn *tconn, union drbd_state mask, union drbd_state val,
  1307. enum chg_state_flags flags)
  1308. {
  1309. enum drbd_state_rv rv = SS_SUCCESS;
  1310. struct after_conn_state_chg_work *acscw;
  1311. enum drbd_conns oc = tconn->cstate;
  1312. union drbd_state ms, os;
  1313. rv = is_valid_conn_transition(oc, val.conn);
  1314. if (rv < SS_SUCCESS)
  1315. goto abort;
  1316. rv = conn_is_valid_transition(tconn, mask, val, flags);
  1317. if (rv < SS_SUCCESS)
  1318. goto abort;
  1319. if (oc == C_WF_REPORT_PARAMS && val.conn == C_DISCONNECTING &&
  1320. !(flags & (CS_LOCAL_ONLY | CS_HARD))) {
  1321. rv = conn_cl_wide(tconn, mask, val, flags);
  1322. if (rv < SS_SUCCESS)
  1323. goto abort;
  1324. }
  1325. conn_old_common_state(tconn, &os, &flags);
  1326. ms = conn_set_state(tconn, mask, val, flags);
  1327. ms.conn = val.conn;
  1328. conn_pr_state_change(tconn, os, ms, flags);
  1329. acscw = kmalloc(sizeof(*acscw), GFP_ATOMIC);
  1330. if (acscw) {
  1331. acscw->oc = os.conn;
  1332. acscw->nms = ms;
  1333. acscw->flags = flags;
  1334. acscw->w.cb = w_after_conn_state_ch;
  1335. acscw->w.tconn = tconn;
  1336. drbd_queue_work(&tconn->data.work, &acscw->w);
  1337. } else {
  1338. conn_err(tconn, "Could not kmalloc an acscw\n");
  1339. }
  1340. abort:
  1341. return rv;
  1342. }
  1343. enum drbd_state_rv
  1344. conn_request_state(struct drbd_tconn *tconn, union drbd_state mask, union drbd_state val,
  1345. enum chg_state_flags flags)
  1346. {
  1347. enum drbd_state_rv rv;
  1348. spin_lock_irq(&tconn->req_lock);
  1349. rv = _conn_request_state(tconn, mask, val, flags);
  1350. spin_unlock_irq(&tconn->req_lock);
  1351. return rv;
  1352. }