fwsignal.c 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567
  1. /*
  2. * Copyright (c) 2010 Broadcom Corporation
  3. *
  4. * Permission to use, copy, modify, and/or distribute this software for any
  5. * purpose with or without fee is hereby granted, provided that the above
  6. * copyright notice and this permission notice appear in all copies.
  7. *
  8. * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
  9. * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
  10. * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
  11. * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
  12. * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
  13. * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
  14. * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  15. */
  16. #include <linux/types.h>
  17. #include <linux/if_ether.h>
  18. #include <linux/spinlock.h>
  19. #include <linux/skbuff.h>
  20. #include <linux/netdevice.h>
  21. #include <linux/err.h>
  22. #include <uapi/linux/nl80211.h>
  23. #include <brcmu_utils.h>
  24. #include <brcmu_wifi.h>
  25. #include "dhd.h"
  26. #include "dhd_dbg.h"
  27. #include "fwil.h"
  28. #include "fweh.h"
  29. #include "fwsignal.h"
  30. /**
  31. * DOC: Firmware Signalling
  32. *
  33. * Firmware can send signals to host and vice versa, which are passed in the
  34. * data packets using TLV based header. This signalling layer is on top of the
  35. * BDC bus protocol layer.
  36. */
  37. /*
  38. * single definition for firmware-driver flow control tlv's.
  39. *
  40. * each tlv is specified by BRCMF_FWS_TLV_DEF(name, ID, length).
  41. * A length value 0 indicates variable length tlv.
  42. */
  43. #define BRCMF_FWS_TLV_DEFLIST \
  44. BRCMF_FWS_TLV_DEF(MAC_OPEN, 1, 1) \
  45. BRCMF_FWS_TLV_DEF(MAC_CLOSE, 2, 1) \
  46. BRCMF_FWS_TLV_DEF(MAC_REQUEST_CREDIT, 3, 2) \
  47. BRCMF_FWS_TLV_DEF(TXSTATUS, 4, 4) \
  48. BRCMF_FWS_TLV_DEF(PKTTAG, 5, 4) \
  49. BRCMF_FWS_TLV_DEF(MACDESC_ADD, 6, 8) \
  50. BRCMF_FWS_TLV_DEF(MACDESC_DEL, 7, 8) \
  51. BRCMF_FWS_TLV_DEF(RSSI, 8, 1) \
  52. BRCMF_FWS_TLV_DEF(INTERFACE_OPEN, 9, 1) \
  53. BRCMF_FWS_TLV_DEF(INTERFACE_CLOSE, 10, 1) \
  54. BRCMF_FWS_TLV_DEF(FIFO_CREDITBACK, 11, 8) \
  55. BRCMF_FWS_TLV_DEF(PENDING_TRAFFIC_BMP, 12, 2) \
  56. BRCMF_FWS_TLV_DEF(MAC_REQUEST_PACKET, 13, 3) \
  57. BRCMF_FWS_TLV_DEF(HOST_REORDER_RXPKTS, 14, 10) \
  58. BRCMF_FWS_TLV_DEF(TRANS_ID, 18, 6) \
  59. BRCMF_FWS_TLV_DEF(COMP_TXSTATUS, 19, 1) \
  60. BRCMF_FWS_TLV_DEF(FILLER, 255, 0)
  61. /**
  62. * enum brcmf_fws_tlv_type - definition of tlv identifiers.
  63. */
  64. #define BRCMF_FWS_TLV_DEF(name, id, len) \
  65. BRCMF_FWS_TYPE_ ## name = id,
  66. enum brcmf_fws_tlv_type {
  67. BRCMF_FWS_TLV_DEFLIST
  68. BRCMF_FWS_TYPE_INVALID
  69. };
  70. #undef BRCMF_FWS_TLV_DEF
  71. #ifdef DEBUG
  72. /**
  73. * brcmf_fws_tlv_names - array of tlv names.
  74. */
  75. #define BRCMF_FWS_TLV_DEF(name, id, len) \
  76. { id, #name },
  77. static struct {
  78. enum brcmf_fws_tlv_type id;
  79. const char *name;
  80. } brcmf_fws_tlv_names[] = {
  81. BRCMF_FWS_TLV_DEFLIST
  82. };
  83. #undef BRCMF_FWS_TLV_DEF
  84. static const char *brcmf_fws_get_tlv_name(enum brcmf_fws_tlv_type id)
  85. {
  86. int i;
  87. for (i = 0; i < ARRAY_SIZE(brcmf_fws_tlv_names); i++)
  88. if (brcmf_fws_tlv_names[i].id == id)
  89. return brcmf_fws_tlv_names[i].name;
  90. return "INVALID";
  91. }
  92. #else
  93. static const char *brcmf_fws_get_tlv_name(enum brcmf_fws_tlv_type id)
  94. {
  95. return "NODEBUG";
  96. }
  97. #endif /* DEBUG */
  98. /**
  99. * flags used to enable tlv signalling from firmware.
  100. */
  101. #define BRCMF_FWS_FLAGS_RSSI_SIGNALS 0x0001
  102. #define BRCMF_FWS_FLAGS_XONXOFF_SIGNALS 0x0002
  103. #define BRCMF_FWS_FLAGS_CREDIT_STATUS_SIGNALS 0x0004
  104. #define BRCMF_FWS_FLAGS_HOST_PROPTXSTATUS_ACTIVE 0x0008
  105. #define BRCMF_FWS_FLAGS_PSQ_GENERATIONFSM_ENABLE 0x0010
  106. #define BRCMF_FWS_FLAGS_PSQ_ZERO_BUFFER_ENABLE 0x0020
  107. #define BRCMF_FWS_FLAGS_HOST_RXREORDER_ACTIVE 0x0040
  108. #define BRCMF_FWS_HANGER_MAXITEMS 1024
  109. #define BRCMF_FWS_HANGER_ITEM_STATE_FREE 1
  110. #define BRCMF_FWS_HANGER_ITEM_STATE_INUSE 2
  111. #define BRCMF_FWS_HANGER_ITEM_STATE_INUSE_SUPPRESSED 3
  112. #define BRCMF_FWS_STATE_OPEN 1
  113. #define BRCMF_FWS_STATE_CLOSE 2
  114. #define BRCMF_FWS_FCMODE_NONE 0
  115. #define BRCMF_FWS_FCMODE_IMPLIED_CREDIT 1
  116. #define BRCMF_FWS_FCMODE_EXPLICIT_CREDIT 2
  117. #define BRCMF_FWS_MAC_DESC_TABLE_SIZE 32
  118. #define BRCMF_FWS_MAX_IFNUM 16
  119. #define BRCMF_FWS_MAC_DESC_ID_INVALID 0xff
  120. #define BRCMF_FWS_HOSTIF_FLOWSTATE_OFF 0
  121. #define BRCMF_FWS_HOSTIF_FLOWSTATE_ON 1
  122. #define BRCMF_FWS_PSQ_PREC_COUNT ((NL80211_NUM_ACS + 1) * 2)
  123. #define BRCMF_FWS_PSQ_LEN 256
  124. /**
  125. * struct brcmf_fws_mac_descriptor - firmware signalling data per node/interface
  126. *
  127. * @occupied: slot is in use.
  128. * @mac_handle: handle for mac entry determined by firmware.
  129. * @interface_id: interface index.
  130. * @state: current state.
  131. * @ac_bitmap: ac queue bitmap.
  132. * @requested_credit: credits requested by firmware.
  133. * @ea: ethernet address.
  134. * @psq: power-save queue.
  135. */
  136. struct brcmf_fws_mac_descriptor {
  137. u8 occupied;
  138. u8 mac_handle;
  139. u8 interface_id;
  140. u8 state;
  141. u8 ac_bitmap;
  142. u8 requested_credit;
  143. u8 ea[ETH_ALEN];
  144. struct pktq psq;
  145. };
  146. /**
  147. * FWFC packet identifier
  148. *
  149. * 32-bit packet identifier used in PKTTAG tlv from host to dongle.
  150. *
  151. * - Generated at the host (e.g. dhd)
  152. * - Seen as a generic sequence number by wlc except the flags field
  153. *
  154. * Generation : b[31] => generation number for this packet [host->fw]
  155. * OR, current generation number [fw->host]
  156. * Flags : b[30:27] => command, status flags
  157. * FIFO-AC : b[26:24] => AC-FIFO id
  158. * h-slot : b[23:8] => hanger-slot
  159. * freerun : b[7:0] => A free running counter
  160. */
  161. #define BRCMF_FWS_PKTTAG_GENERATION_MASK 0x80000000
  162. #define BRCMF_FWS_PKTTAG_GENERATION_SHIFT 31
  163. #define BRCMF_FWS_PKTTAG_FLAGS_MASK 0x78000000
  164. #define BRCMF_FWS_PKTTAG_FLAGS_SHIFT 27
  165. #define BRCMF_FWS_PKTTAG_FIFO_MASK 0x07000000
  166. #define BRCMF_FWS_PKTTAG_FIFO_SHIFT 24
  167. #define BRCMF_FWS_PKTTAG_HSLOT_MASK 0x00ffff00
  168. #define BRCMF_FWS_PKTTAG_HSLOT_SHIFT 8
  169. #define BRCMF_FWS_PKTTAG_FREERUN_MASK 0x000000ff
  170. #define BRCMF_FWS_PKTTAG_FREERUN_SHIFT 0
  171. #define brcmf_fws_pkttag_set_field(var, field, value) \
  172. brcmu_maskset32((var), BRCMF_FWS_PKTTAG_ ## field ## _MASK, \
  173. BRCMF_FWS_PKTTAG_ ## field ## _SHIFT, (value))
  174. #define brcmf_fws_pkttag_get_field(var, field) \
  175. brcmu_maskget32((var), BRCMF_FWS_PKTTAG_ ## field ## _MASK, \
  176. BRCMF_FWS_PKTTAG_ ## field ## _SHIFT)
  177. struct brcmf_fws_info {
  178. struct brcmf_pub *drvr;
  179. struct brcmf_fws_stats stats;
  180. struct brcmf_fws_mac_descriptor nodes[BRCMF_FWS_MAC_DESC_TABLE_SIZE];
  181. int fifo_credit[NL80211_NUM_ACS+1+1];
  182. };
  183. /**
  184. * brcmf_fws_get_tlv_len() - returns defined length for given tlv id.
  185. */
  186. #define BRCMF_FWS_TLV_DEF(name, id, len) \
  187. case BRCMF_FWS_TYPE_ ## name: \
  188. return len;
  189. static int brcmf_fws_get_tlv_len(struct brcmf_fws_info *fws,
  190. enum brcmf_fws_tlv_type id)
  191. {
  192. switch (id) {
  193. BRCMF_FWS_TLV_DEFLIST
  194. default:
  195. brcmf_err("invalid tlv id: %d\n", id);
  196. fws->stats.tlv_invalid_type++;
  197. break;
  198. }
  199. return -EINVAL;
  200. }
  201. #undef BRCMF_FWS_TLV_DEF
  202. static void brcmf_fws_init_mac_descriptor(struct brcmf_fws_mac_descriptor *desc,
  203. u8 *addr, u8 ifidx)
  204. {
  205. brcmf_dbg(TRACE, "enter: ea=%pM, ifidx=%u\n", addr, ifidx);
  206. desc->occupied = 1;
  207. desc->state = BRCMF_FWS_STATE_OPEN;
  208. desc->requested_credit = 0;
  209. /* depending on use may need ifp->bssidx instead */
  210. desc->interface_id = ifidx;
  211. desc->ac_bitmap = 0xff; /* update this when handling APSD */
  212. memcpy(&desc->ea[0], addr, ETH_ALEN);
  213. }
  214. static
  215. void brcmf_fws_clear_mac_descriptor(struct brcmf_fws_mac_descriptor *desc)
  216. {
  217. brcmf_dbg(TRACE,
  218. "enter: ea=%pM, ifidx=%u\n", desc->ea, desc->interface_id);
  219. desc->occupied = 0;
  220. desc->state = BRCMF_FWS_STATE_CLOSE;
  221. desc->requested_credit = 0;
  222. }
  223. static struct brcmf_fws_mac_descriptor *
  224. brcmf_fws_mac_descriptor_lookup(struct brcmf_fws_info *fws, u8 *ea)
  225. {
  226. struct brcmf_fws_mac_descriptor *entry;
  227. int i;
  228. brcmf_dbg(TRACE, "enter: ea=%pM\n", ea);
  229. if (ea == NULL)
  230. return ERR_PTR(-EINVAL);
  231. entry = &fws->nodes[0];
  232. for (i = 0; i < ARRAY_SIZE(fws->nodes); i++) {
  233. if (entry->occupied && !memcmp(entry->ea, ea, ETH_ALEN))
  234. return entry;
  235. entry++;
  236. }
  237. return ERR_PTR(-ENOENT);
  238. }
  239. static int brcmf_fws_rssi_indicate(struct brcmf_fws_info *fws, s8 rssi)
  240. {
  241. brcmf_dbg(CTL, "rssi %d\n", rssi);
  242. return 0;
  243. }
  244. static
  245. int brcmf_fws_macdesc_indicate(struct brcmf_fws_info *fws, u8 type, u8 *data)
  246. {
  247. struct brcmf_fws_mac_descriptor *entry, *existing;
  248. u8 mac_handle;
  249. u8 ifidx;
  250. u8 *addr;
  251. mac_handle = *data++;
  252. ifidx = *data++;
  253. addr = data;
  254. entry = &fws->nodes[mac_handle & 0x1F];
  255. if (type == BRCMF_FWS_TYPE_MACDESC_DEL) {
  256. brcmf_dbg(TRACE, "deleting mac %pM idx %d\n", addr, ifidx);
  257. if (entry->occupied) {
  258. entry->occupied = 0;
  259. entry->state = BRCMF_FWS_STATE_CLOSE;
  260. entry->requested_credit = 0;
  261. } else {
  262. fws->stats.mac_update_failed++;
  263. }
  264. return 0;
  265. }
  266. brcmf_dbg(TRACE, "add mac %pM idx %d\n", addr, ifidx);
  267. existing = brcmf_fws_mac_descriptor_lookup(fws, addr);
  268. if (IS_ERR(existing)) {
  269. if (!entry->occupied) {
  270. entry->mac_handle = mac_handle;
  271. brcmf_fws_init_mac_descriptor(entry, addr, ifidx);
  272. brcmu_pktq_init(&entry->psq, BRCMF_FWS_PSQ_PREC_COUNT,
  273. BRCMF_FWS_PSQ_LEN);
  274. } else {
  275. fws->stats.mac_update_failed++;
  276. }
  277. } else {
  278. if (entry != existing) {
  279. brcmf_dbg(TRACE, "relocate mac\n");
  280. memcpy(entry, existing,
  281. offsetof(struct brcmf_fws_mac_descriptor, psq));
  282. entry->mac_handle = mac_handle;
  283. brcmf_fws_clear_mac_descriptor(existing);
  284. } else {
  285. brcmf_dbg(TRACE, "use existing\n");
  286. WARN_ON(entry->mac_handle != mac_handle);
  287. /* TODO: what should we do here: continue, reinit, .. */
  288. }
  289. }
  290. return 0;
  291. }
  292. static int brcmf_fws_dbg_seqnum_check(struct brcmf_fws_info *fws, u8 *data)
  293. {
  294. __le32 timestamp;
  295. memcpy(&timestamp, &data[2], sizeof(timestamp));
  296. brcmf_dbg(INFO, "received: seq %d, timestamp %d\n", data[1],
  297. le32_to_cpu(timestamp));
  298. return 0;
  299. }
  300. /* using macro so sparse checking does not complain
  301. * about locking imbalance.
  302. */
  303. #define brcmf_fws_lock(drvr, flags) \
  304. do { \
  305. flags = 0; \
  306. spin_lock_irqsave(&((drvr)->fws_spinlock), (flags)); \
  307. } while (0)
  308. /* using macro so sparse checking does not complain
  309. * about locking imbalance.
  310. */
  311. #define brcmf_fws_unlock(drvr, flags) \
  312. spin_unlock_irqrestore(&((drvr)->fws_spinlock), (flags))
  313. static int brcmf_fws_notify_credit_map(struct brcmf_if *ifp,
  314. const struct brcmf_event_msg *e,
  315. void *data)
  316. {
  317. struct brcmf_fws_info *fws = ifp->drvr->fws;
  318. int i;
  319. ulong flags;
  320. u8 *credits = data;
  321. brcmf_fws_lock(ifp->drvr, flags);
  322. for (i = 0; i < ARRAY_SIZE(fws->fifo_credit); i++)
  323. fws->fifo_credit[i] = *credits++;
  324. brcmf_fws_unlock(ifp->drvr, flags);
  325. return 0;
  326. }
  327. int brcmf_fws_init(struct brcmf_pub *drvr)
  328. {
  329. u32 tlv = 0;
  330. int rc;
  331. /* enable rssi signals */
  332. if (drvr->fw_signals)
  333. tlv = BRCMF_FWS_FLAGS_RSSI_SIGNALS |
  334. BRCMF_FWS_FLAGS_XONXOFF_SIGNALS;
  335. spin_lock_init(&drvr->fws_spinlock);
  336. drvr->fws = kzalloc(sizeof(*(drvr->fws)), GFP_KERNEL);
  337. if (!drvr->fws) {
  338. rc = -ENOMEM;
  339. goto fail;
  340. }
  341. /* enable proptxtstatus signaling by default */
  342. rc = brcmf_fil_iovar_int_set(drvr->iflist[0], "tlv", tlv);
  343. if (rc < 0) {
  344. brcmf_err("failed to set bdcv2 tlv signaling\n");
  345. goto fail;
  346. }
  347. if (brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP,
  348. brcmf_fws_notify_credit_map)) {
  349. brcmf_err("register credit map handler failed\n");
  350. goto fail;
  351. }
  352. /* set linkage back */
  353. drvr->fws->drvr = drvr;
  354. /* create debugfs file for statistics */
  355. brcmf_debugfs_create_fws_stats(drvr, &drvr->fws->stats);
  356. /* TODO: remove upon feature delivery */
  357. brcmf_err("%s bdcv2 tlv signaling [%x]\n",
  358. drvr->fw_signals ? "enabled" : "disabled", tlv);
  359. return 0;
  360. fail:
  361. /* disable flow control entirely */
  362. drvr->fw_signals = false;
  363. brcmf_fws_deinit(drvr);
  364. return rc;
  365. }
  366. void brcmf_fws_deinit(struct brcmf_pub *drvr)
  367. {
  368. /* free top structure */
  369. kfree(drvr->fws);
  370. drvr->fws = NULL;
  371. }
  372. int brcmf_fws_hdrpull(struct brcmf_pub *drvr, int ifidx, s16 signal_len,
  373. struct sk_buff *skb)
  374. {
  375. struct brcmf_fws_info *fws = drvr->fws;
  376. ulong flags;
  377. u8 *signal_data;
  378. s16 data_len;
  379. u8 type;
  380. u8 len;
  381. u8 *data;
  382. brcmf_dbg(TRACE, "enter: ifidx %d, skblen %u, sig %d\n",
  383. ifidx, skb->len, signal_len);
  384. WARN_ON(signal_len > skb->len);
  385. /* if flow control disabled, skip to packet data and leave */
  386. if (!signal_len || !drvr->fw_signals) {
  387. skb_pull(skb, signal_len);
  388. return 0;
  389. }
  390. /* lock during tlv parsing */
  391. brcmf_fws_lock(drvr, flags);
  392. fws->stats.header_pulls++;
  393. data_len = signal_len;
  394. signal_data = skb->data;
  395. while (data_len > 0) {
  396. /* extract tlv info */
  397. type = signal_data[0];
  398. /* FILLER type is actually not a TLV, but
  399. * a single byte that can be skipped.
  400. */
  401. if (type == BRCMF_FWS_TYPE_FILLER) {
  402. signal_data += 1;
  403. data_len -= 1;
  404. continue;
  405. }
  406. len = signal_data[1];
  407. data = signal_data + 2;
  408. /* abort parsing when length invalid */
  409. if (data_len < len + 2)
  410. break;
  411. if (len != brcmf_fws_get_tlv_len(fws, type))
  412. break;
  413. brcmf_dbg(INFO, "tlv type=%d (%s), len=%d\n", type,
  414. brcmf_fws_get_tlv_name(type), len);
  415. switch (type) {
  416. case BRCMF_FWS_TYPE_MAC_OPEN:
  417. case BRCMF_FWS_TYPE_MAC_CLOSE:
  418. case BRCMF_FWS_TYPE_MAC_REQUEST_CREDIT:
  419. case BRCMF_FWS_TYPE_TXSTATUS:
  420. case BRCMF_FWS_TYPE_PKTTAG:
  421. case BRCMF_FWS_TYPE_INTERFACE_OPEN:
  422. case BRCMF_FWS_TYPE_INTERFACE_CLOSE:
  423. case BRCMF_FWS_TYPE_FIFO_CREDITBACK:
  424. case BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP:
  425. case BRCMF_FWS_TYPE_MAC_REQUEST_PACKET:
  426. case BRCMF_FWS_TYPE_HOST_REORDER_RXPKTS:
  427. case BRCMF_FWS_TYPE_COMP_TXSTATUS:
  428. break;
  429. case BRCMF_FWS_TYPE_MACDESC_ADD:
  430. case BRCMF_FWS_TYPE_MACDESC_DEL:
  431. brcmf_fws_macdesc_indicate(fws, type, data);
  432. break;
  433. case BRCMF_FWS_TYPE_RSSI:
  434. brcmf_fws_rssi_indicate(fws, *data);
  435. break;
  436. case BRCMF_FWS_TYPE_TRANS_ID:
  437. brcmf_fws_dbg_seqnum_check(fws, data);
  438. break;
  439. default:
  440. fws->stats.tlv_invalid_type++;
  441. break;
  442. }
  443. signal_data += len + 2;
  444. data_len -= len + 2;
  445. }
  446. if (data_len != 0)
  447. fws->stats.tlv_parse_failed++;
  448. /* signalling processing result does
  449. * not affect the actual ethernet packet.
  450. */
  451. skb_pull(skb, signal_len);
  452. /* this may be a signal-only packet
  453. */
  454. if (skb->len == 0)
  455. fws->stats.header_only_pkt++;
  456. brcmf_fws_unlock(drvr, flags);
  457. return 0;
  458. }
  459. void brcmf_fws_reset_interface(struct brcmf_if *ifp)
  460. {
  461. struct brcmf_fws_mac_descriptor *entry = ifp->fws_desc;
  462. brcmf_dbg(TRACE, "enter: idx=%d\n", ifp->bssidx);
  463. if (!entry)
  464. return;
  465. brcmf_fws_init_mac_descriptor(entry, ifp->mac_addr, ifp->ifidx);
  466. }
  467. void brcmf_fws_add_interface(struct brcmf_if *ifp)
  468. {
  469. struct brcmf_fws_mac_descriptor *entry;
  470. brcmf_dbg(TRACE, "enter: idx=%d, mac=%pM\n",
  471. ifp->bssidx, ifp->mac_addr);
  472. if (!ifp->drvr->fw_signals)
  473. return;
  474. entry = kzalloc(sizeof(*entry), GFP_ATOMIC);
  475. if (entry) {
  476. ifp->fws_desc = entry;
  477. brcmf_fws_init_mac_descriptor(entry, ifp->mac_addr, ifp->ifidx);
  478. brcmu_pktq_init(&entry->psq, BRCMF_FWS_PSQ_PREC_COUNT,
  479. BRCMF_FWS_PSQ_LEN);
  480. } else {
  481. brcmf_err("no firmware signalling\n");
  482. }
  483. }
  484. void brcmf_fws_del_interface(struct brcmf_if *ifp)
  485. {
  486. struct brcmf_fws_mac_descriptor *entry = ifp->fws_desc;
  487. brcmf_dbg(TRACE, "enter: idx=%d\n", ifp->bssidx);
  488. if (!entry)
  489. return;
  490. ifp->fws_desc = NULL;
  491. brcmf_fws_clear_mac_descriptor(entry);
  492. kfree(entry);
  493. }