nfs4idmap.c 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650
  1. /*
  2. * Mapping of UID/GIDs to name and vice versa.
  3. *
  4. * Copyright (c) 2002, 2003 The Regents of the University of
  5. * Michigan. All rights reserved.
  6. *
  7. * Marius Aamodt Eriksen <marius@umich.edu>
  8. *
  9. * Redistribution and use in source and binary forms, with or without
  10. * modification, are permitted provided that the following conditions
  11. * are met:
  12. *
  13. * 1. Redistributions of source code must retain the above copyright
  14. * notice, this list of conditions and the following disclaimer.
  15. * 2. Redistributions in binary form must reproduce the above copyright
  16. * notice, this list of conditions and the following disclaimer in the
  17. * documentation and/or other materials provided with the distribution.
  18. * 3. Neither the name of the University nor the names of its
  19. * contributors may be used to endorse or promote products derived
  20. * from this software without specific prior written permission.
  21. *
  22. * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
  23. * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  24. * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  25. * DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
  26. * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  27. * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  28. * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
  29. * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
  30. * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
  31. * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  32. * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  33. */
  34. #include <linux/module.h>
  35. #include <linux/seq_file.h>
  36. #include <linux/sched.h>
  37. #include <linux/slab.h>
  38. #include <linux/sunrpc/svc_xprt.h>
  39. #include <net/net_namespace.h>
  40. #include "idmap.h"
  41. #include "nfsd.h"
  42. #include "netns.h"
  43. /*
  44. * Turn off idmapping when using AUTH_SYS.
  45. */
  46. static bool nfs4_disable_idmapping = true;
  47. module_param(nfs4_disable_idmapping, bool, 0644);
  48. MODULE_PARM_DESC(nfs4_disable_idmapping,
  49. "Turn off server's NFSv4 idmapping when using 'sec=sys'");
  50. /*
  51. * Cache entry
  52. */
  53. /*
  54. * XXX we know that IDMAP_NAMESZ < PAGE_SIZE, but it's ugly to rely on
  55. * that.
  56. */
  57. #define IDMAP_TYPE_USER 0
  58. #define IDMAP_TYPE_GROUP 1
  59. struct ent {
  60. struct cache_head h;
  61. int type; /* User / Group */
  62. uid_t id;
  63. char name[IDMAP_NAMESZ];
  64. char authname[IDMAP_NAMESZ];
  65. };
  66. /* Common entry handling */
  67. #define ENT_HASHBITS 8
  68. #define ENT_HASHMAX (1 << ENT_HASHBITS)
  69. static void
  70. ent_init(struct cache_head *cnew, struct cache_head *citm)
  71. {
  72. struct ent *new = container_of(cnew, struct ent, h);
  73. struct ent *itm = container_of(citm, struct ent, h);
  74. new->id = itm->id;
  75. new->type = itm->type;
  76. strlcpy(new->name, itm->name, sizeof(new->name));
  77. strlcpy(new->authname, itm->authname, sizeof(new->name));
  78. }
  79. static void
  80. ent_put(struct kref *ref)
  81. {
  82. struct ent *map = container_of(ref, struct ent, h.ref);
  83. kfree(map);
  84. }
  85. static struct cache_head *
  86. ent_alloc(void)
  87. {
  88. struct ent *e = kmalloc(sizeof(*e), GFP_KERNEL);
  89. if (e)
  90. return &e->h;
  91. else
  92. return NULL;
  93. }
  94. /*
  95. * ID -> Name cache
  96. */
  97. static uint32_t
  98. idtoname_hash(struct ent *ent)
  99. {
  100. uint32_t hash;
  101. hash = hash_str(ent->authname, ENT_HASHBITS);
  102. hash = hash_long(hash ^ ent->id, ENT_HASHBITS);
  103. /* Flip LSB for user/group */
  104. if (ent->type == IDMAP_TYPE_GROUP)
  105. hash ^= 1;
  106. return hash;
  107. }
  108. static void
  109. idtoname_request(struct cache_detail *cd, struct cache_head *ch, char **bpp,
  110. int *blen)
  111. {
  112. struct ent *ent = container_of(ch, struct ent, h);
  113. char idstr[11];
  114. qword_add(bpp, blen, ent->authname);
  115. snprintf(idstr, sizeof(idstr), "%u", ent->id);
  116. qword_add(bpp, blen, ent->type == IDMAP_TYPE_GROUP ? "group" : "user");
  117. qword_add(bpp, blen, idstr);
  118. (*bpp)[-1] = '\n';
  119. }
  120. static int
  121. idtoname_upcall(struct cache_detail *cd, struct cache_head *ch)
  122. {
  123. return sunrpc_cache_pipe_upcall(cd, ch, idtoname_request);
  124. }
  125. static int
  126. idtoname_match(struct cache_head *ca, struct cache_head *cb)
  127. {
  128. struct ent *a = container_of(ca, struct ent, h);
  129. struct ent *b = container_of(cb, struct ent, h);
  130. return (a->id == b->id && a->type == b->type &&
  131. strcmp(a->authname, b->authname) == 0);
  132. }
  133. static int
  134. idtoname_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h)
  135. {
  136. struct ent *ent;
  137. if (h == NULL) {
  138. seq_puts(m, "#domain type id [name]\n");
  139. return 0;
  140. }
  141. ent = container_of(h, struct ent, h);
  142. seq_printf(m, "%s %s %u", ent->authname,
  143. ent->type == IDMAP_TYPE_GROUP ? "group" : "user",
  144. ent->id);
  145. if (test_bit(CACHE_VALID, &h->flags))
  146. seq_printf(m, " %s", ent->name);
  147. seq_printf(m, "\n");
  148. return 0;
  149. }
  150. static void
  151. warn_no_idmapd(struct cache_detail *detail, int has_died)
  152. {
  153. printk("nfsd: nfsv4 idmapping failing: has idmapd %s?\n",
  154. has_died ? "died" : "not been started");
  155. }
  156. static int idtoname_parse(struct cache_detail *, char *, int);
  157. static struct ent *idtoname_lookup(struct cache_detail *, struct ent *);
  158. static struct ent *idtoname_update(struct cache_detail *, struct ent *,
  159. struct ent *);
  160. static struct cache_detail idtoname_cache_template = {
  161. .owner = THIS_MODULE,
  162. .hash_size = ENT_HASHMAX,
  163. .name = "nfs4.idtoname",
  164. .cache_put = ent_put,
  165. .cache_upcall = idtoname_upcall,
  166. .cache_parse = idtoname_parse,
  167. .cache_show = idtoname_show,
  168. .warn_no_listener = warn_no_idmapd,
  169. .match = idtoname_match,
  170. .init = ent_init,
  171. .update = ent_init,
  172. .alloc = ent_alloc,
  173. };
  174. static int
  175. idtoname_parse(struct cache_detail *cd, char *buf, int buflen)
  176. {
  177. struct ent ent, *res;
  178. char *buf1, *bp;
  179. int len;
  180. int error = -EINVAL;
  181. if (buf[buflen - 1] != '\n')
  182. return (-EINVAL);
  183. buf[buflen - 1]= '\0';
  184. buf1 = kmalloc(PAGE_SIZE, GFP_KERNEL);
  185. if (buf1 == NULL)
  186. return (-ENOMEM);
  187. memset(&ent, 0, sizeof(ent));
  188. /* Authentication name */
  189. if (qword_get(&buf, buf1, PAGE_SIZE) <= 0)
  190. goto out;
  191. memcpy(ent.authname, buf1, sizeof(ent.authname));
  192. /* Type */
  193. if (qword_get(&buf, buf1, PAGE_SIZE) <= 0)
  194. goto out;
  195. ent.type = strcmp(buf1, "user") == 0 ?
  196. IDMAP_TYPE_USER : IDMAP_TYPE_GROUP;
  197. /* ID */
  198. if (qword_get(&buf, buf1, PAGE_SIZE) <= 0)
  199. goto out;
  200. ent.id = simple_strtoul(buf1, &bp, 10);
  201. if (bp == buf1)
  202. goto out;
  203. /* expiry */
  204. ent.h.expiry_time = get_expiry(&buf);
  205. if (ent.h.expiry_time == 0)
  206. goto out;
  207. error = -ENOMEM;
  208. res = idtoname_lookup(cd, &ent);
  209. if (!res)
  210. goto out;
  211. /* Name */
  212. error = -EINVAL;
  213. len = qword_get(&buf, buf1, PAGE_SIZE);
  214. if (len < 0)
  215. goto out;
  216. if (len == 0)
  217. set_bit(CACHE_NEGATIVE, &ent.h.flags);
  218. else if (len >= IDMAP_NAMESZ)
  219. goto out;
  220. else
  221. memcpy(ent.name, buf1, sizeof(ent.name));
  222. error = -ENOMEM;
  223. res = idtoname_update(cd, &ent, res);
  224. if (res == NULL)
  225. goto out;
  226. cache_put(&res->h, cd);
  227. error = 0;
  228. out:
  229. kfree(buf1);
  230. return error;
  231. }
  232. static struct ent *
  233. idtoname_lookup(struct cache_detail *cd, struct ent *item)
  234. {
  235. struct cache_head *ch = sunrpc_cache_lookup(cd, &item->h,
  236. idtoname_hash(item));
  237. if (ch)
  238. return container_of(ch, struct ent, h);
  239. else
  240. return NULL;
  241. }
  242. static struct ent *
  243. idtoname_update(struct cache_detail *cd, struct ent *new, struct ent *old)
  244. {
  245. struct cache_head *ch = sunrpc_cache_update(cd, &new->h, &old->h,
  246. idtoname_hash(new));
  247. if (ch)
  248. return container_of(ch, struct ent, h);
  249. else
  250. return NULL;
  251. }
  252. /*
  253. * Name -> ID cache
  254. */
  255. static inline int
  256. nametoid_hash(struct ent *ent)
  257. {
  258. return hash_str(ent->name, ENT_HASHBITS);
  259. }
  260. static void
  261. nametoid_request(struct cache_detail *cd, struct cache_head *ch, char **bpp,
  262. int *blen)
  263. {
  264. struct ent *ent = container_of(ch, struct ent, h);
  265. qword_add(bpp, blen, ent->authname);
  266. qword_add(bpp, blen, ent->type == IDMAP_TYPE_GROUP ? "group" : "user");
  267. qword_add(bpp, blen, ent->name);
  268. (*bpp)[-1] = '\n';
  269. }
  270. static int
  271. nametoid_upcall(struct cache_detail *cd, struct cache_head *ch)
  272. {
  273. return sunrpc_cache_pipe_upcall(cd, ch, nametoid_request);
  274. }
  275. static int
  276. nametoid_match(struct cache_head *ca, struct cache_head *cb)
  277. {
  278. struct ent *a = container_of(ca, struct ent, h);
  279. struct ent *b = container_of(cb, struct ent, h);
  280. return (a->type == b->type && strcmp(a->name, b->name) == 0 &&
  281. strcmp(a->authname, b->authname) == 0);
  282. }
  283. static int
  284. nametoid_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h)
  285. {
  286. struct ent *ent;
  287. if (h == NULL) {
  288. seq_puts(m, "#domain type name [id]\n");
  289. return 0;
  290. }
  291. ent = container_of(h, struct ent, h);
  292. seq_printf(m, "%s %s %s", ent->authname,
  293. ent->type == IDMAP_TYPE_GROUP ? "group" : "user",
  294. ent->name);
  295. if (test_bit(CACHE_VALID, &h->flags))
  296. seq_printf(m, " %u", ent->id);
  297. seq_printf(m, "\n");
  298. return 0;
  299. }
  300. static struct ent *nametoid_lookup(struct cache_detail *, struct ent *);
  301. static struct ent *nametoid_update(struct cache_detail *, struct ent *,
  302. struct ent *);
  303. static int nametoid_parse(struct cache_detail *, char *, int);
  304. static struct cache_detail nametoid_cache_template = {
  305. .owner = THIS_MODULE,
  306. .hash_size = ENT_HASHMAX,
  307. .name = "nfs4.nametoid",
  308. .cache_put = ent_put,
  309. .cache_upcall = nametoid_upcall,
  310. .cache_parse = nametoid_parse,
  311. .cache_show = nametoid_show,
  312. .warn_no_listener = warn_no_idmapd,
  313. .match = nametoid_match,
  314. .init = ent_init,
  315. .update = ent_init,
  316. .alloc = ent_alloc,
  317. };
  318. static int
  319. nametoid_parse(struct cache_detail *cd, char *buf, int buflen)
  320. {
  321. struct ent ent, *res;
  322. char *buf1;
  323. int error = -EINVAL;
  324. if (buf[buflen - 1] != '\n')
  325. return (-EINVAL);
  326. buf[buflen - 1]= '\0';
  327. buf1 = kmalloc(PAGE_SIZE, GFP_KERNEL);
  328. if (buf1 == NULL)
  329. return (-ENOMEM);
  330. memset(&ent, 0, sizeof(ent));
  331. /* Authentication name */
  332. if (qword_get(&buf, buf1, PAGE_SIZE) <= 0)
  333. goto out;
  334. memcpy(ent.authname, buf1, sizeof(ent.authname));
  335. /* Type */
  336. if (qword_get(&buf, buf1, PAGE_SIZE) <= 0)
  337. goto out;
  338. ent.type = strcmp(buf1, "user") == 0 ?
  339. IDMAP_TYPE_USER : IDMAP_TYPE_GROUP;
  340. /* Name */
  341. error = qword_get(&buf, buf1, PAGE_SIZE);
  342. if (error <= 0 || error >= IDMAP_NAMESZ)
  343. goto out;
  344. memcpy(ent.name, buf1, sizeof(ent.name));
  345. /* expiry */
  346. ent.h.expiry_time = get_expiry(&buf);
  347. if (ent.h.expiry_time == 0)
  348. goto out;
  349. /* ID */
  350. error = get_int(&buf, &ent.id);
  351. if (error == -EINVAL)
  352. goto out;
  353. if (error == -ENOENT)
  354. set_bit(CACHE_NEGATIVE, &ent.h.flags);
  355. error = -ENOMEM;
  356. res = nametoid_lookup(cd, &ent);
  357. if (res == NULL)
  358. goto out;
  359. res = nametoid_update(cd, &ent, res);
  360. if (res == NULL)
  361. goto out;
  362. cache_put(&res->h, cd);
  363. error = 0;
  364. out:
  365. kfree(buf1);
  366. return (error);
  367. }
  368. static struct ent *
  369. nametoid_lookup(struct cache_detail *cd, struct ent *item)
  370. {
  371. struct cache_head *ch = sunrpc_cache_lookup(cd, &item->h,
  372. nametoid_hash(item));
  373. if (ch)
  374. return container_of(ch, struct ent, h);
  375. else
  376. return NULL;
  377. }
  378. static struct ent *
  379. nametoid_update(struct cache_detail *cd, struct ent *new, struct ent *old)
  380. {
  381. struct cache_head *ch = sunrpc_cache_update(cd, &new->h, &old->h,
  382. nametoid_hash(new));
  383. if (ch)
  384. return container_of(ch, struct ent, h);
  385. else
  386. return NULL;
  387. }
  388. /*
  389. * Exported API
  390. */
  391. int
  392. nfsd_idmap_init(struct net *net)
  393. {
  394. int rv;
  395. struct nfsd_net *nn = net_generic(net, nfsd_net_id);
  396. nn->idtoname_cache = cache_create_net(&idtoname_cache_template, net);
  397. if (IS_ERR(nn->idtoname_cache))
  398. return PTR_ERR(nn->idtoname_cache);
  399. rv = cache_register_net(nn->idtoname_cache, net);
  400. if (rv)
  401. goto destroy_idtoname_cache;
  402. nn->nametoid_cache = cache_create_net(&nametoid_cache_template, net);
  403. if (IS_ERR(nn->nametoid_cache)) {
  404. rv = PTR_ERR(nn->idtoname_cache);
  405. goto unregister_idtoname_cache;
  406. }
  407. rv = cache_register_net(nn->nametoid_cache, net);
  408. if (rv)
  409. goto destroy_nametoid_cache;
  410. return 0;
  411. destroy_nametoid_cache:
  412. cache_destroy_net(nn->nametoid_cache, net);
  413. unregister_idtoname_cache:
  414. cache_unregister_net(nn->idtoname_cache, net);
  415. destroy_idtoname_cache:
  416. cache_destroy_net(nn->idtoname_cache, net);
  417. return rv;
  418. }
  419. void
  420. nfsd_idmap_shutdown(struct net *net)
  421. {
  422. struct nfsd_net *nn = net_generic(net, nfsd_net_id);
  423. cache_unregister_net(nn->idtoname_cache, net);
  424. cache_unregister_net(nn->nametoid_cache, net);
  425. cache_destroy_net(nn->idtoname_cache, net);
  426. cache_destroy_net(nn->nametoid_cache, net);
  427. }
  428. static int
  429. idmap_lookup(struct svc_rqst *rqstp,
  430. struct ent *(*lookup_fn)(struct cache_detail *, struct ent *),
  431. struct ent *key, struct cache_detail *detail, struct ent **item)
  432. {
  433. int ret;
  434. *item = lookup_fn(detail, key);
  435. if (!*item)
  436. return -ENOMEM;
  437. retry:
  438. ret = cache_check(detail, &(*item)->h, &rqstp->rq_chandle);
  439. if (ret == -ETIMEDOUT) {
  440. struct ent *prev_item = *item;
  441. *item = lookup_fn(detail, key);
  442. if (*item != prev_item)
  443. goto retry;
  444. cache_put(&(*item)->h, detail);
  445. }
  446. return ret;
  447. }
  448. static char *
  449. rqst_authname(struct svc_rqst *rqstp)
  450. {
  451. struct auth_domain *clp;
  452. clp = rqstp->rq_gssclient ? rqstp->rq_gssclient : rqstp->rq_client;
  453. return clp->name;
  454. }
  455. static __be32
  456. idmap_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namelen,
  457. uid_t *id)
  458. {
  459. struct ent *item, key = {
  460. .type = type,
  461. };
  462. int ret;
  463. struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id);
  464. if (namelen + 1 > sizeof(key.name))
  465. return nfserr_badowner;
  466. memcpy(key.name, name, namelen);
  467. key.name[namelen] = '\0';
  468. strlcpy(key.authname, rqst_authname(rqstp), sizeof(key.authname));
  469. ret = idmap_lookup(rqstp, nametoid_lookup, &key, nn->nametoid_cache, &item);
  470. if (ret == -ENOENT)
  471. return nfserr_badowner;
  472. if (ret)
  473. return nfserrno(ret);
  474. *id = item->id;
  475. cache_put(&item->h, nn->nametoid_cache);
  476. return 0;
  477. }
  478. static int
  479. idmap_id_to_name(struct svc_rqst *rqstp, int type, uid_t id, char *name)
  480. {
  481. struct ent *item, key = {
  482. .id = id,
  483. .type = type,
  484. };
  485. int ret;
  486. struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id);
  487. strlcpy(key.authname, rqst_authname(rqstp), sizeof(key.authname));
  488. ret = idmap_lookup(rqstp, idtoname_lookup, &key, nn->idtoname_cache, &item);
  489. if (ret == -ENOENT)
  490. return sprintf(name, "%u", id);
  491. if (ret)
  492. return ret;
  493. ret = strlen(item->name);
  494. BUG_ON(ret > IDMAP_NAMESZ);
  495. memcpy(name, item->name, ret);
  496. cache_put(&item->h, nn->idtoname_cache);
  497. return ret;
  498. }
  499. static bool
  500. numeric_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namelen, uid_t *id)
  501. {
  502. int ret;
  503. char buf[11];
  504. if (namelen + 1 > sizeof(buf))
  505. /* too long to represent a 32-bit id: */
  506. return false;
  507. /* Just to make sure it's null-terminated: */
  508. memcpy(buf, name, namelen);
  509. buf[namelen] = '\0';
  510. ret = kstrtouint(name, 10, id);
  511. return ret == 0;
  512. }
  513. static __be32
  514. do_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namelen, uid_t *id)
  515. {
  516. if (nfs4_disable_idmapping && rqstp->rq_cred.cr_flavor < RPC_AUTH_GSS)
  517. if (numeric_name_to_id(rqstp, type, name, namelen, id))
  518. return 0;
  519. /*
  520. * otherwise, fall through and try idmapping, for
  521. * backwards compatibility with clients sending names:
  522. */
  523. return idmap_name_to_id(rqstp, type, name, namelen, id);
  524. }
  525. static int
  526. do_id_to_name(struct svc_rqst *rqstp, int type, uid_t id, char *name)
  527. {
  528. if (nfs4_disable_idmapping && rqstp->rq_cred.cr_flavor < RPC_AUTH_GSS)
  529. return sprintf(name, "%u", id);
  530. return idmap_id_to_name(rqstp, type, id, name);
  531. }
  532. __be32
  533. nfsd_map_name_to_uid(struct svc_rqst *rqstp, const char *name, size_t namelen,
  534. __u32 *id)
  535. {
  536. return do_name_to_id(rqstp, IDMAP_TYPE_USER, name, namelen, id);
  537. }
  538. __be32
  539. nfsd_map_name_to_gid(struct svc_rqst *rqstp, const char *name, size_t namelen,
  540. __u32 *id)
  541. {
  542. return do_name_to_id(rqstp, IDMAP_TYPE_GROUP, name, namelen, id);
  543. }
  544. int
  545. nfsd_map_uid_to_name(struct svc_rqst *rqstp, __u32 id, char *name)
  546. {
  547. return do_id_to_name(rqstp, IDMAP_TYPE_USER, id, name);
  548. }
  549. int
  550. nfsd_map_gid_to_name(struct svc_rqst *rqstp, __u32 id, char *name)
  551. {
  552. return do_id_to_name(rqstp, IDMAP_TYPE_GROUP, id, name);
  553. }