tps6586x.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593
  1. /*
  2. * Core driver for TI TPS6586x PMIC family
  3. *
  4. * Copyright (c) 2010 CompuLab Ltd.
  5. * Mike Rapoport <mike@compulab.co.il>
  6. *
  7. * Based on da903x.c.
  8. * Copyright (C) 2008 Compulab, Ltd.
  9. * Mike Rapoport <mike@compulab.co.il>
  10. * Copyright (C) 2006-2008 Marvell International Ltd.
  11. * Eric Miao <eric.miao@marvell.com>
  12. *
  13. * This program is free software; you can redistribute it and/or modify
  14. * it under the terms of the GNU General Public License version 2 as
  15. * published by the Free Software Foundation.
  16. */
  17. #include <linux/interrupt.h>
  18. #include <linux/irq.h>
  19. #include <linux/kernel.h>
  20. #include <linux/module.h>
  21. #include <linux/mutex.h>
  22. #include <linux/slab.h>
  23. #include <linux/err.h>
  24. #include <linux/i2c.h>
  25. #include <linux/regmap.h>
  26. #include <linux/regulator/of_regulator.h>
  27. #include <linux/regulator/machine.h>
  28. #include <linux/mfd/core.h>
  29. #include <linux/mfd/tps6586x.h>
  30. #define TPS6586X_SUPPLYENE 0x14
  31. #define EXITSLREQ_BIT BIT(1)
  32. #define SLEEP_MODE_BIT BIT(3)
  33. /* interrupt control registers */
  34. #define TPS6586X_INT_ACK1 0xb5
  35. #define TPS6586X_INT_ACK2 0xb6
  36. #define TPS6586X_INT_ACK3 0xb7
  37. #define TPS6586X_INT_ACK4 0xb8
  38. /* interrupt mask registers */
  39. #define TPS6586X_INT_MASK1 0xb0
  40. #define TPS6586X_INT_MASK2 0xb1
  41. #define TPS6586X_INT_MASK3 0xb2
  42. #define TPS6586X_INT_MASK4 0xb3
  43. #define TPS6586X_INT_MASK5 0xb4
  44. /* device id */
  45. #define TPS6586X_VERSIONCRC 0xcd
  46. /* Maximum register */
  47. #define TPS6586X_MAX_REGISTER (TPS6586X_VERSIONCRC + 1)
  48. struct tps6586x_irq_data {
  49. u8 mask_reg;
  50. u8 mask_mask;
  51. };
  52. #define TPS6586X_IRQ(_reg, _mask) \
  53. { \
  54. .mask_reg = (_reg) - TPS6586X_INT_MASK1, \
  55. .mask_mask = (_mask), \
  56. }
  57. static const struct tps6586x_irq_data tps6586x_irqs[] = {
  58. [TPS6586X_INT_PLDO_0] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 0),
  59. [TPS6586X_INT_PLDO_1] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 1),
  60. [TPS6586X_INT_PLDO_2] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 2),
  61. [TPS6586X_INT_PLDO_3] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 3),
  62. [TPS6586X_INT_PLDO_4] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 4),
  63. [TPS6586X_INT_PLDO_5] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 5),
  64. [TPS6586X_INT_PLDO_6] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 6),
  65. [TPS6586X_INT_PLDO_7] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 7),
  66. [TPS6586X_INT_COMP_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 1 << 0),
  67. [TPS6586X_INT_ADC] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 1),
  68. [TPS6586X_INT_PLDO_8] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 2),
  69. [TPS6586X_INT_PLDO_9] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 3),
  70. [TPS6586X_INT_PSM_0] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 4),
  71. [TPS6586X_INT_PSM_1] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 5),
  72. [TPS6586X_INT_PSM_2] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 6),
  73. [TPS6586X_INT_PSM_3] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 7),
  74. [TPS6586X_INT_RTC_ALM1] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 4),
  75. [TPS6586X_INT_ACUSB_OVP] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 0x03),
  76. [TPS6586X_INT_USB_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 2),
  77. [TPS6586X_INT_AC_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 3),
  78. [TPS6586X_INT_BAT_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK3, 1 << 0),
  79. [TPS6586X_INT_CHG_STAT] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 0xfc),
  80. [TPS6586X_INT_CHG_TEMP] = TPS6586X_IRQ(TPS6586X_INT_MASK3, 0x06),
  81. [TPS6586X_INT_PP] = TPS6586X_IRQ(TPS6586X_INT_MASK3, 0xf0),
  82. [TPS6586X_INT_RESUME] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 5),
  83. [TPS6586X_INT_LOW_SYS] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 6),
  84. [TPS6586X_INT_RTC_ALM2] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 1 << 1),
  85. };
  86. static struct mfd_cell tps6586x_cell[] = {
  87. {
  88. .name = "tps6586x-gpio",
  89. },
  90. {
  91. .name = "tps6586x-rtc",
  92. },
  93. {
  94. .name = "tps6586x-onkey",
  95. },
  96. };
  97. struct tps6586x {
  98. struct device *dev;
  99. struct i2c_client *client;
  100. struct regmap *regmap;
  101. struct irq_chip irq_chip;
  102. struct mutex irq_lock;
  103. int irq_base;
  104. u32 irq_en;
  105. u8 mask_reg[5];
  106. };
  107. static inline struct tps6586x *dev_to_tps6586x(struct device *dev)
  108. {
  109. return i2c_get_clientdata(to_i2c_client(dev));
  110. }
  111. int tps6586x_write(struct device *dev, int reg, uint8_t val)
  112. {
  113. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  114. return regmap_write(tps6586x->regmap, reg, val);
  115. }
  116. EXPORT_SYMBOL_GPL(tps6586x_write);
  117. int tps6586x_writes(struct device *dev, int reg, int len, uint8_t *val)
  118. {
  119. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  120. return regmap_bulk_write(tps6586x->regmap, reg, val, len);
  121. }
  122. EXPORT_SYMBOL_GPL(tps6586x_writes);
  123. int tps6586x_read(struct device *dev, int reg, uint8_t *val)
  124. {
  125. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  126. unsigned int rval;
  127. int ret;
  128. ret = regmap_read(tps6586x->regmap, reg, &rval);
  129. if (!ret)
  130. *val = rval;
  131. return ret;
  132. }
  133. EXPORT_SYMBOL_GPL(tps6586x_read);
  134. int tps6586x_reads(struct device *dev, int reg, int len, uint8_t *val)
  135. {
  136. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  137. return regmap_bulk_read(tps6586x->regmap, reg, val, len);
  138. }
  139. EXPORT_SYMBOL_GPL(tps6586x_reads);
  140. int tps6586x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
  141. {
  142. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  143. return regmap_update_bits(tps6586x->regmap, reg, bit_mask, bit_mask);
  144. }
  145. EXPORT_SYMBOL_GPL(tps6586x_set_bits);
  146. int tps6586x_clr_bits(struct device *dev, int reg, uint8_t bit_mask)
  147. {
  148. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  149. return regmap_update_bits(tps6586x->regmap, reg, bit_mask, 0);
  150. }
  151. EXPORT_SYMBOL_GPL(tps6586x_clr_bits);
  152. int tps6586x_update(struct device *dev, int reg, uint8_t val, uint8_t mask)
  153. {
  154. struct tps6586x *tps6586x = dev_to_tps6586x(dev);
  155. return regmap_update_bits(tps6586x->regmap, reg, mask, val);
  156. }
  157. EXPORT_SYMBOL_GPL(tps6586x_update);
  158. static int __remove_subdev(struct device *dev, void *unused)
  159. {
  160. platform_device_unregister(to_platform_device(dev));
  161. return 0;
  162. }
  163. static int tps6586x_remove_subdevs(struct tps6586x *tps6586x)
  164. {
  165. return device_for_each_child(tps6586x->dev, NULL, __remove_subdev);
  166. }
  167. static void tps6586x_irq_lock(struct irq_data *data)
  168. {
  169. struct tps6586x *tps6586x = irq_data_get_irq_chip_data(data);
  170. mutex_lock(&tps6586x->irq_lock);
  171. }
  172. static void tps6586x_irq_enable(struct irq_data *irq_data)
  173. {
  174. struct tps6586x *tps6586x = irq_data_get_irq_chip_data(irq_data);
  175. unsigned int __irq = irq_data->irq - tps6586x->irq_base;
  176. const struct tps6586x_irq_data *data = &tps6586x_irqs[__irq];
  177. tps6586x->mask_reg[data->mask_reg] &= ~data->mask_mask;
  178. tps6586x->irq_en |= (1 << __irq);
  179. }
  180. static void tps6586x_irq_disable(struct irq_data *irq_data)
  181. {
  182. struct tps6586x *tps6586x = irq_data_get_irq_chip_data(irq_data);
  183. unsigned int __irq = irq_data->irq - tps6586x->irq_base;
  184. const struct tps6586x_irq_data *data = &tps6586x_irqs[__irq];
  185. tps6586x->mask_reg[data->mask_reg] |= data->mask_mask;
  186. tps6586x->irq_en &= ~(1 << __irq);
  187. }
  188. static void tps6586x_irq_sync_unlock(struct irq_data *data)
  189. {
  190. struct tps6586x *tps6586x = irq_data_get_irq_chip_data(data);
  191. int i;
  192. for (i = 0; i < ARRAY_SIZE(tps6586x->mask_reg); i++) {
  193. int ret;
  194. ret = tps6586x_write(tps6586x->dev,
  195. TPS6586X_INT_MASK1 + i,
  196. tps6586x->mask_reg[i]);
  197. WARN_ON(ret);
  198. }
  199. mutex_unlock(&tps6586x->irq_lock);
  200. }
  201. static irqreturn_t tps6586x_irq(int irq, void *data)
  202. {
  203. struct tps6586x *tps6586x = data;
  204. u32 acks;
  205. int ret = 0;
  206. ret = tps6586x_reads(tps6586x->dev, TPS6586X_INT_ACK1,
  207. sizeof(acks), (uint8_t *)&acks);
  208. if (ret < 0) {
  209. dev_err(tps6586x->dev, "failed to read interrupt status\n");
  210. return IRQ_NONE;
  211. }
  212. acks = le32_to_cpu(acks);
  213. while (acks) {
  214. int i = __ffs(acks);
  215. if (tps6586x->irq_en & (1 << i))
  216. handle_nested_irq(tps6586x->irq_base + i);
  217. acks &= ~(1 << i);
  218. }
  219. return IRQ_HANDLED;
  220. }
  221. static int __devinit tps6586x_irq_init(struct tps6586x *tps6586x, int irq,
  222. int irq_base)
  223. {
  224. int i, ret;
  225. u8 tmp[4];
  226. if (!irq_base) {
  227. dev_warn(tps6586x->dev, "No interrupt support on IRQ base\n");
  228. return -EINVAL;
  229. }
  230. mutex_init(&tps6586x->irq_lock);
  231. for (i = 0; i < 5; i++) {
  232. tps6586x->mask_reg[i] = 0xff;
  233. tps6586x_write(tps6586x->dev, TPS6586X_INT_MASK1 + i, 0xff);
  234. }
  235. tps6586x_reads(tps6586x->dev, TPS6586X_INT_ACK1, sizeof(tmp), tmp);
  236. tps6586x->irq_base = irq_base;
  237. tps6586x->irq_chip.name = "tps6586x";
  238. tps6586x->irq_chip.irq_enable = tps6586x_irq_enable;
  239. tps6586x->irq_chip.irq_disable = tps6586x_irq_disable;
  240. tps6586x->irq_chip.irq_bus_lock = tps6586x_irq_lock;
  241. tps6586x->irq_chip.irq_bus_sync_unlock = tps6586x_irq_sync_unlock;
  242. for (i = 0; i < ARRAY_SIZE(tps6586x_irqs); i++) {
  243. int __irq = i + tps6586x->irq_base;
  244. irq_set_chip_data(__irq, tps6586x);
  245. irq_set_chip_and_handler(__irq, &tps6586x->irq_chip,
  246. handle_simple_irq);
  247. irq_set_nested_thread(__irq, 1);
  248. #ifdef CONFIG_ARM
  249. set_irq_flags(__irq, IRQF_VALID);
  250. #endif
  251. }
  252. ret = request_threaded_irq(irq, NULL, tps6586x_irq, IRQF_ONESHOT,
  253. "tps6586x", tps6586x);
  254. if (!ret) {
  255. device_init_wakeup(tps6586x->dev, 1);
  256. enable_irq_wake(irq);
  257. }
  258. return ret;
  259. }
  260. static int __devinit tps6586x_add_subdevs(struct tps6586x *tps6586x,
  261. struct tps6586x_platform_data *pdata)
  262. {
  263. struct tps6586x_subdev_info *subdev;
  264. struct platform_device *pdev;
  265. int i, ret = 0;
  266. for (i = 0; i < pdata->num_subdevs; i++) {
  267. subdev = &pdata->subdevs[i];
  268. pdev = platform_device_alloc(subdev->name, subdev->id);
  269. if (!pdev) {
  270. ret = -ENOMEM;
  271. goto failed;
  272. }
  273. pdev->dev.parent = tps6586x->dev;
  274. pdev->dev.platform_data = subdev->platform_data;
  275. pdev->dev.of_node = subdev->of_node;
  276. ret = platform_device_add(pdev);
  277. if (ret) {
  278. platform_device_put(pdev);
  279. goto failed;
  280. }
  281. }
  282. return 0;
  283. failed:
  284. tps6586x_remove_subdevs(tps6586x);
  285. return ret;
  286. }
  287. #ifdef CONFIG_OF
  288. static struct of_regulator_match tps6586x_matches[] = {
  289. { .name = "sys", .driver_data = (void *)TPS6586X_ID_SYS },
  290. { .name = "sm0", .driver_data = (void *)TPS6586X_ID_SM_0 },
  291. { .name = "sm1", .driver_data = (void *)TPS6586X_ID_SM_1 },
  292. { .name = "sm2", .driver_data = (void *)TPS6586X_ID_SM_2 },
  293. { .name = "ldo0", .driver_data = (void *)TPS6586X_ID_LDO_0 },
  294. { .name = "ldo1", .driver_data = (void *)TPS6586X_ID_LDO_1 },
  295. { .name = "ldo2", .driver_data = (void *)TPS6586X_ID_LDO_2 },
  296. { .name = "ldo3", .driver_data = (void *)TPS6586X_ID_LDO_3 },
  297. { .name = "ldo4", .driver_data = (void *)TPS6586X_ID_LDO_4 },
  298. { .name = "ldo5", .driver_data = (void *)TPS6586X_ID_LDO_5 },
  299. { .name = "ldo6", .driver_data = (void *)TPS6586X_ID_LDO_6 },
  300. { .name = "ldo7", .driver_data = (void *)TPS6586X_ID_LDO_7 },
  301. { .name = "ldo8", .driver_data = (void *)TPS6586X_ID_LDO_8 },
  302. { .name = "ldo9", .driver_data = (void *)TPS6586X_ID_LDO_9 },
  303. { .name = "ldo_rtc", .driver_data = (void *)TPS6586X_ID_LDO_RTC },
  304. };
  305. static struct tps6586x_platform_data *tps6586x_parse_dt(struct i2c_client *client)
  306. {
  307. const unsigned int num = ARRAY_SIZE(tps6586x_matches);
  308. struct device_node *np = client->dev.of_node;
  309. struct tps6586x_platform_data *pdata;
  310. struct tps6586x_subdev_info *devs;
  311. struct device_node *regs;
  312. const char *sys_rail_name = NULL;
  313. unsigned int count;
  314. unsigned int i, j;
  315. int err;
  316. regs = of_find_node_by_name(np, "regulators");
  317. if (!regs)
  318. return NULL;
  319. err = of_regulator_match(&client->dev, regs, tps6586x_matches, num);
  320. if (err < 0) {
  321. of_node_put(regs);
  322. return NULL;
  323. }
  324. of_node_put(regs);
  325. count = err;
  326. devs = devm_kzalloc(&client->dev, count * sizeof(*devs), GFP_KERNEL);
  327. if (!devs)
  328. return NULL;
  329. for (i = 0, j = 0; i < num && j < count; i++) {
  330. struct regulator_init_data *reg_idata;
  331. if (!tps6586x_matches[i].init_data)
  332. continue;
  333. reg_idata = tps6586x_matches[i].init_data;
  334. devs[j].name = "tps6586x-regulator";
  335. devs[j].platform_data = tps6586x_matches[i].init_data;
  336. devs[j].id = (int)tps6586x_matches[i].driver_data;
  337. if (devs[j].id == TPS6586X_ID_SYS)
  338. sys_rail_name = reg_idata->constraints.name;
  339. if ((devs[j].id == TPS6586X_ID_LDO_5) ||
  340. (devs[j].id == TPS6586X_ID_LDO_RTC))
  341. reg_idata->supply_regulator = sys_rail_name;
  342. devs[j].of_node = tps6586x_matches[i].of_node;
  343. j++;
  344. }
  345. pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
  346. if (!pdata)
  347. return NULL;
  348. pdata->num_subdevs = count;
  349. pdata->subdevs = devs;
  350. pdata->gpio_base = -1;
  351. pdata->irq_base = -1;
  352. pdata->pm_off = of_property_read_bool(np, "ti,system-power-controller");
  353. return pdata;
  354. }
  355. static struct of_device_id tps6586x_of_match[] = {
  356. { .compatible = "ti,tps6586x", },
  357. { },
  358. };
  359. #else
  360. static struct tps6586x_platform_data *tps6586x_parse_dt(struct i2c_client *client)
  361. {
  362. return NULL;
  363. }
  364. #endif
  365. static bool is_volatile_reg(struct device *dev, unsigned int reg)
  366. {
  367. /* Cache all interrupt mask register */
  368. if ((reg >= TPS6586X_INT_MASK1) && (reg <= TPS6586X_INT_MASK5))
  369. return false;
  370. return true;
  371. }
  372. static const struct regmap_config tps6586x_regmap_config = {
  373. .reg_bits = 8,
  374. .val_bits = 8,
  375. .max_register = TPS6586X_MAX_REGISTER - 1,
  376. .volatile_reg = is_volatile_reg,
  377. .cache_type = REGCACHE_RBTREE,
  378. };
  379. static struct device *tps6586x_dev;
  380. static void tps6586x_power_off(void)
  381. {
  382. if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
  383. return;
  384. tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SLEEP_MODE_BIT);
  385. }
  386. static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
  387. const struct i2c_device_id *id)
  388. {
  389. struct tps6586x_platform_data *pdata = client->dev.platform_data;
  390. struct tps6586x *tps6586x;
  391. int ret;
  392. if (!pdata && client->dev.of_node)
  393. pdata = tps6586x_parse_dt(client);
  394. if (!pdata) {
  395. dev_err(&client->dev, "tps6586x requires platform data\n");
  396. return -ENOTSUPP;
  397. }
  398. ret = i2c_smbus_read_byte_data(client, TPS6586X_VERSIONCRC);
  399. if (ret < 0) {
  400. dev_err(&client->dev, "Chip ID read failed: %d\n", ret);
  401. return -EIO;
  402. }
  403. dev_info(&client->dev, "VERSIONCRC is %02x\n", ret);
  404. tps6586x = devm_kzalloc(&client->dev, sizeof(*tps6586x), GFP_KERNEL);
  405. if (tps6586x == NULL) {
  406. dev_err(&client->dev, "memory for tps6586x alloc failed\n");
  407. return -ENOMEM;
  408. }
  409. tps6586x->client = client;
  410. tps6586x->dev = &client->dev;
  411. i2c_set_clientdata(client, tps6586x);
  412. tps6586x->regmap = devm_regmap_init_i2c(client,
  413. &tps6586x_regmap_config);
  414. if (IS_ERR(tps6586x->regmap)) {
  415. ret = PTR_ERR(tps6586x->regmap);
  416. dev_err(&client->dev, "regmap init failed: %d\n", ret);
  417. return ret;
  418. }
  419. if (client->irq) {
  420. ret = tps6586x_irq_init(tps6586x, client->irq,
  421. pdata->irq_base);
  422. if (ret) {
  423. dev_err(&client->dev, "IRQ init failed: %d\n", ret);
  424. return ret;
  425. }
  426. }
  427. ret = mfd_add_devices(tps6586x->dev, -1,
  428. tps6586x_cell, ARRAY_SIZE(tps6586x_cell),
  429. NULL, 0, NULL);
  430. if (ret < 0) {
  431. dev_err(&client->dev, "mfd_add_devices failed: %d\n", ret);
  432. goto err_mfd_add;
  433. }
  434. ret = tps6586x_add_subdevs(tps6586x, pdata);
  435. if (ret) {
  436. dev_err(&client->dev, "add devices failed: %d\n", ret);
  437. goto err_add_devs;
  438. }
  439. if (pdata->pm_off && !pm_power_off) {
  440. tps6586x_dev = &client->dev;
  441. pm_power_off = tps6586x_power_off;
  442. }
  443. return 0;
  444. err_add_devs:
  445. mfd_remove_devices(tps6586x->dev);
  446. err_mfd_add:
  447. if (client->irq)
  448. free_irq(client->irq, tps6586x);
  449. return ret;
  450. }
  451. static int __devexit tps6586x_i2c_remove(struct i2c_client *client)
  452. {
  453. struct tps6586x *tps6586x = i2c_get_clientdata(client);
  454. tps6586x_remove_subdevs(tps6586x);
  455. mfd_remove_devices(tps6586x->dev);
  456. if (client->irq)
  457. free_irq(client->irq, tps6586x);
  458. return 0;
  459. }
  460. static const struct i2c_device_id tps6586x_id_table[] = {
  461. { "tps6586x", 0 },
  462. { },
  463. };
  464. MODULE_DEVICE_TABLE(i2c, tps6586x_id_table);
  465. static struct i2c_driver tps6586x_driver = {
  466. .driver = {
  467. .name = "tps6586x",
  468. .owner = THIS_MODULE,
  469. .of_match_table = of_match_ptr(tps6586x_of_match),
  470. },
  471. .probe = tps6586x_i2c_probe,
  472. .remove = __devexit_p(tps6586x_i2c_remove),
  473. .id_table = tps6586x_id_table,
  474. };
  475. static int __init tps6586x_init(void)
  476. {
  477. return i2c_add_driver(&tps6586x_driver);
  478. }
  479. subsys_initcall(tps6586x_init);
  480. static void __exit tps6586x_exit(void)
  481. {
  482. i2c_del_driver(&tps6586x_driver);
  483. }
  484. module_exit(tps6586x_exit);
  485. MODULE_DESCRIPTION("TPS6586X core driver");
  486. MODULE_AUTHOR("Mike Rapoport <mike@compulab.co.il>");
  487. MODULE_LICENSE("GPL");