瀏覽代碼

[PATCH] fs: add a sanity check in d_free

Hi Al,

remember that debug session we did at KS? You suggested this patch back
then....

From 7751eaf30474b8cbfaea64795805a17eab05ac53 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Tue, 16 Sep 2008 16:51:17 -0700
Subject: [PATCH] fs: add a sanity check in d_free

we're seeing some corruption in the dentry->d_alias list that
appears like a free of an entry still on the list; this patch
adds a WARN_ON() to catch this scenario, as suggested by Al Viro

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Arjan van de Ven 16 年之前
父節點
當前提交
fd217f4d70
共有 1 個文件被更改,包括 1 次插入0 次删除
  1. 1 0
      fs/dcache.c

+ 1 - 0
fs/dcache.c

@@ -69,6 +69,7 @@ struct dentry_stat_t dentry_stat = {
 
 
 static void __d_free(struct dentry *dentry)
 static void __d_free(struct dentry *dentry)
 {
 {
+	WARN_ON(!list_empty(&dentry->d_alias));
 	if (dname_external(dentry))
 	if (dname_external(dentry))
 		kfree(dentry->d_name.name);
 		kfree(dentry->d_name.name);
 	kmem_cache_free(dentry_cache, dentry); 
 	kmem_cache_free(dentry_cache, dentry);