Przeglądaj źródła

sh: Fix up clockevents broadcasting.

This fixes up the clockevents broadcasting code as detailed in commit
ee348d5a1d810bc9958cabb7c27302aab235d36e ("[ARM] realview: fix broadcast
tick support"). This saves us from having to do strange ordering things
with the broadcast clockevent device, relying on the rating instead.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Paul Mundt 15 lat temu
rodzic
commit
fc6191dd30

+ 2 - 0
arch/sh/kernel/cpu/sh4a/smp-shx3.c

@@ -57,6 +57,8 @@ void __init plat_prepare_cpus(unsigned int max_cpus)
 {
 {
 	int i;
 	int i;
 
 
+	local_timer_setup(0);
+
 	BUILD_BUG_ON(SMP_MSG_NR >= 8);
 	BUILD_BUG_ON(SMP_MSG_NR >= 8);
 
 
 	for (i = 0; i < SMP_MSG_NR; i++)
 	for (i = 0; i < SMP_MSG_NR; i++)

+ 7 - 2
arch/sh/kernel/localtimer.c

@@ -22,6 +22,7 @@
 #include <linux/jiffies.h>
 #include <linux/jiffies.h>
 #include <linux/percpu.h>
 #include <linux/percpu.h>
 #include <linux/clockchips.h>
 #include <linux/clockchips.h>
+#include <linux/hardirq.h>
 #include <linux/irq.h>
 #include <linux/irq.h>
 
 
 static DEFINE_PER_CPU(struct clock_event_device, local_clockevent);
 static DEFINE_PER_CPU(struct clock_event_device, local_clockevent);
@@ -33,7 +34,9 @@ void local_timer_interrupt(void)
 {
 {
 	struct clock_event_device *clk = &__get_cpu_var(local_clockevent);
 	struct clock_event_device *clk = &__get_cpu_var(local_clockevent);
 
 
+	irq_enter();
 	clk->event_handler(clk);
 	clk->event_handler(clk);
+	irq_exit();
 }
 }
 
 
 static void dummy_timer_set_mode(enum clock_event_mode mode,
 static void dummy_timer_set_mode(enum clock_event_mode mode,
@@ -46,8 +49,10 @@ void __cpuinit local_timer_setup(unsigned int cpu)
 	struct clock_event_device *clk = &per_cpu(local_clockevent, cpu);
 	struct clock_event_device *clk = &per_cpu(local_clockevent, cpu);
 
 
 	clk->name		= "dummy_timer";
 	clk->name		= "dummy_timer";
-	clk->features		= CLOCK_EVT_FEAT_DUMMY;
-	clk->rating		= 200;
+	clk->features		= CLOCK_EVT_FEAT_ONESHOT |
+				  CLOCK_EVT_FEAT_PERIODIC |
+				  CLOCK_EVT_FEAT_DUMMY;
+	clk->rating		= 400;
 	clk->mult		= 1;
 	clk->mult		= 1;
 	clk->set_mode		= dummy_timer_set_mode;
 	clk->set_mode		= dummy_timer_set_mode;
 	clk->broadcast		= smp_timer_broadcast;
 	clk->broadcast		= smp_timer_broadcast;

+ 0 - 4
arch/sh/kernel/time.c

@@ -119,9 +119,5 @@ void __init time_init(void)
 	set_normalized_timespec(&wall_to_monotonic,
 	set_normalized_timespec(&wall_to_monotonic,
 				-xtime.tv_sec, -xtime.tv_nsec);
 				-xtime.tv_sec, -xtime.tv_nsec);
 
 
-#ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST
-	local_timer_setup(smp_processor_id());
-#endif
-
 	late_time_init = sh_late_time_init;
 	late_time_init = sh_late_time_init;
 }
 }