Sfoglia il codice sorgente

[ICMP]: Fix extra dst release when ip_options_echo fails

When two ip_route_output_key lookups in icmp_send were combined I
forgot to change the error path for ip_options_echo to not drop the
dst reference since it now sits before the dst lookup.  To fix it we
simply jump past the ip_rt_put call.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Herbert Xu 19 anni fa
parent
commit
fa60cf7f64
1 ha cambiato i file con 1 aggiunte e 1 eliminazioni
  1. 1 1
      net/ipv4/icmp.c

+ 1 - 1
net/ipv4/icmp.c

@@ -524,7 +524,7 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, u32 info)
 					  iph->tos;
 					  iph->tos;
 
 
 	if (ip_options_echo(&icmp_param.replyopts, skb_in))
 	if (ip_options_echo(&icmp_param.replyopts, skb_in))
-		goto ende;
+		goto out_unlock;
 
 
 
 
 	/*
 	/*