瀏覽代碼

rt2x00: fix "buffer size not provably correct" build warning

rt2x00 debugfs interface doesn't check the size of the data coming
from userspace, leading to a build warning. Fix That.

v2: return EINVAL if input is too long

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Arnaud Patard (Rtp) 15 年之前
父節點
當前提交
f8d8b7a13d
共有 1 個文件被更改,包括 3 次插入0 次删除
  1. 3 0
      drivers/net/wireless/rt2x00/rt2x00debug.c

+ 3 - 0
drivers/net/wireless/rt2x00/rt2x00debug.c

@@ -480,6 +480,9 @@ static ssize_t rt2x00debug_write_##__name(struct file *file,	\
 	if (index >= debug->__name.word_count)			\
 		return -EINVAL;					\
 								\
+	if (length > sizeof(line))				\
+		return -EINVAL;					\
+								\
 	if (copy_from_user(line, buf, length))			\
 		return -EFAULT;					\
 								\