浏览代码

ALSA: hda - Don't access invalid substream in proc file

The commit e3303235209c0496b490e10ab131e72a9568c153
"ALSA: hda - proc - show which I/O NID is associated to PCM device"
introduces the access to substream pointer.  But, PCMs may have no
substreams in one or both directions, and this results in NULL
dereference.  Also, print the first substream number doesn't make
sense.

This patch removes the access to the substream pointer, and reformat
to fit to the standard coding style.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 15 年之前
父节点
当前提交
f8b7163529
共有 1 个文件被更改,包括 5 次插入5 次删除
  1. 5 5
      sound/pci/hda/hda_proc.c

+ 5 - 5
sound/pci/hda/hda_proc.c

@@ -316,11 +316,11 @@ static void print_audio_io(struct snd_info_buffer *buffer,
 		for (type = 0; type < 2; type++) {
 			if (cpcm->stream[type].nid != nid || cpcm->pcm == NULL)
 				continue;
-			snd_iprintf(buffer, "  Device: name=\"%s\", type=\"%s\", device=%i, substream=%i\n",
-				cpcm->name,
-				snd_hda_pcm_type_name[cpcm->pcm_type],
-				cpcm->pcm->device,
-				cpcm->pcm->streams[type].substream->number);
+			snd_iprintf(buffer, "  Device: name=\"%s\", "
+				    "type=\"%s\", device=%i\n",
+				    cpcm->name,
+				    snd_hda_pcm_type_name[cpcm->pcm_type],
+				    cpcm->pcm->device);
 		}
 	}
 	conv = snd_hda_codec_read(codec, nid, 0, AC_VERB_GET_CONV, 0);