瀏覽代碼

mfd: ab3100: world-writable debugfs *_priv files

Don't allow everybody to change device hardware registers.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Vasiliy Kulikov 14 年之前
父節點
當前提交
f8a0697722
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/mfd/ab3100-core.c

+ 2 - 2
drivers/mfd/ab3100-core.c

@@ -613,7 +613,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100)
 	ab3100_get_priv.ab3100 = ab3100;
 	ab3100_get_priv.ab3100 = ab3100;
 	ab3100_get_priv.mode = false;
 	ab3100_get_priv.mode = false;
 	ab3100_get_reg_file = debugfs_create_file("get_reg",
 	ab3100_get_reg_file = debugfs_create_file("get_reg",
-				S_IWUGO, ab3100_dir, &ab3100_get_priv,
+				S_IWUSR, ab3100_dir, &ab3100_get_priv,
 				&ab3100_get_set_reg_fops);
 				&ab3100_get_set_reg_fops);
 	if (!ab3100_get_reg_file) {
 	if (!ab3100_get_reg_file) {
 		err = -ENOMEM;
 		err = -ENOMEM;
@@ -623,7 +623,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100)
 	ab3100_set_priv.ab3100 = ab3100;
 	ab3100_set_priv.ab3100 = ab3100;
 	ab3100_set_priv.mode = true;
 	ab3100_set_priv.mode = true;
 	ab3100_set_reg_file = debugfs_create_file("set_reg",
 	ab3100_set_reg_file = debugfs_create_file("set_reg",
-				S_IWUGO, ab3100_dir, &ab3100_set_priv,
+				S_IWUSR, ab3100_dir, &ab3100_set_priv,
 				&ab3100_get_set_reg_fops);
 				&ab3100_get_set_reg_fops);
 	if (!ab3100_set_reg_file) {
 	if (!ab3100_set_reg_file) {
 		err = -ENOMEM;
 		err = -ENOMEM;