Browse Source

fealnx: Write outside array bounds

phy_idx is checked to be < 4, but np->phys[] is 2 elements long

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
roel kluin 16 years ago
parent
commit
f83284fe20
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/net/fealnx.c

+ 2 - 1
drivers/net/fealnx.c

@@ -584,7 +584,8 @@ static int __devinit fealnx_init_one(struct pci_dev *pdev,
 	if (np->flags == HAS_MII_XCVR) {
 	if (np->flags == HAS_MII_XCVR) {
 		int phy, phy_idx = 0;
 		int phy, phy_idx = 0;
 
 
-		for (phy = 1; phy < 32 && phy_idx < 4; phy++) {
+		for (phy = 1; phy < 32 && phy_idx < ARRAY_SIZE(np->phys);
+			       phy++) {
 			int mii_status = mdio_read(dev, phy, 1);
 			int mii_status = mdio_read(dev, phy, 1);
 
 
 			if (mii_status != 0xffff && mii_status != 0x0000) {
 			if (mii_status != 0xffff && mii_status != 0x0000) {