Browse Source

dmar: fix uninitialised 'ret' variable in dmar_parse_dev()

This was introduced by commit 1886e8a90a580f3ad343f2065c84c1b9e1dac9ef
("x64, x2apic/intr-remap: code re-structuring, to be used by both DMA
and Interrupt remapping"). It was causing bogus results to be returned
from dmar_parse_dev() when the first unit with the INCLUDE_ALL flag was
processed.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
David Woodhouse 16 years ago
parent
commit
f82851a8a4
1 changed files with 2 additions and 3 deletions
  1. 2 3
      drivers/pci/dmar.c

+ 2 - 3
drivers/pci/dmar.c

@@ -188,12 +188,11 @@ dmar_parse_one_drhd(struct acpi_dmar_header *header)
 	return 0;
 }
 
-static int __init
-dmar_parse_dev(struct dmar_drhd_unit *dmaru)
+static int __init dmar_parse_dev(struct dmar_drhd_unit *dmaru)
 {
 	struct acpi_dmar_hardware_unit *drhd;
 	static int include_all;
-	int ret;
+	int ret = 0;
 
 	drhd = (struct acpi_dmar_hardware_unit *) dmaru->hdr;