Browse Source

V4L/DVB: drivers/media/dvb/siano: Remove double test

The same expression is tested twice and the result is the same each time.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Julia Lawall 14 years ago
parent
commit
f78729b40a
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/media/dvb/siano/smscoreapi.c

+ 1 - 2
drivers/media/dvb/siano/smscoreapi.c

@@ -1504,8 +1504,7 @@ int smscore_gpio_set_level(struct smscore_device_t *coredev, u8 PinNum,
 		u32 msgData[3]; /* keep it 3 ! */
 		u32 msgData[3]; /* keep it 3 ! */
 	} *pMsg;
 	} *pMsg;
 
 
-	if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER) ||
-			(PinNum > MAX_GPIO_PIN_NUMBER))
+	if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER))
 		return -EINVAL;
 		return -EINVAL;
 
 
 	totalLen = sizeof(struct SmsMsgHdr_ST) +
 	totalLen = sizeof(struct SmsMsgHdr_ST) +