Home Explore Help
Register Sign In
phyus
/
linux-vybrid_public
8
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

fix endianness bug in inet_lro

all uses of and almost all assignments to lro_desc->tcp_ack assume that it's
net-endian; one converts net-endian to host-endian and sticks it in
lro_desc->tcp_ack.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Al Viro 17 years ago
parent
9df7c98a0f
commit
f53f4137ba
2 changed files with 2 additions and 2 deletions
Split View Show Diff Stats
  1. 1 1
      include/linux/inet_lro.h
  2. 1 1
      net/ipv4/inet_lro.c

+ 1 - 1
include/linux/inet_lro.h
View File 

@@ -54,7 +54,7 @@ struct net_lro_desc {
 
 	__wsum  data_csum;
 
 	__be32 tcp_rcv_tsecr;
 
 	__be32 tcp_rcv_tsval;
 
-	u32 tcp_ack;
 
+	__be32 tcp_ack;
 
 	u32 tcp_next_seq;
 
 	u32 skb_tot_frags_len;
 
 	u16 ip_tot_len;

+ 1 - 1
net/ipv4/inet_lro.c
View File 

@@ -159,7 +159,7 @@ static void lro_init_desc(struct net_lro_desc *lro_desc, struct sk_buff *skb,
 
 	lro_desc->iph = iph;
 
 	lro_desc->tcph = tcph;
 
 	lro_desc->tcp_next_seq = ntohl(tcph->seq) + tcp_data_len;
 
-	lro_desc->tcp_ack = ntohl(tcph->ack_seq);
 
+	lro_desc->tcp_ack = tcph->ack_seq;
 
 	lro_desc->tcp_window = tcph->window;
 
 
 	lro_desc->pkt_aggr_cnt = 1;