Преглед изворни кода

[PATCH] uml: fix critical typo for TT mode

Noticed this for a compilation-time warning, so I'm fixing it even for TT mode
- this is not put_user, but copy_to_user, so we need a pointer to sp, not sp
itself (we're trying to write the word pointed to by the "sp" var.).

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Paolo 'Blaisorblade' Giarrusso пре 19 година
родитељ
комит
f53389d8af
2 измењених фајлова са 2 додато и 2 уклоњено
  1. 1 1
      arch/um/sys-i386/signal.c
  2. 1 1
      arch/um/sys-x86_64/signal.c

+ 1 - 1
arch/um/sys-i386/signal.c

@@ -147,7 +147,7 @@ int copy_sc_to_user_tt(struct sigcontext *to, struct _fpstate __user *fp,
 	 * delivery.  The sp passed in is the original, and this needs
 	 * delivery.  The sp passed in is the original, and this needs
 	 * to be restored, so we stick it in separately.
 	 * to be restored, so we stick it in separately.
 	 */
 	 */
-	err |= copy_to_user(&SC_SP(to), sp, sizeof(sp));
+	err |= copy_to_user(&SC_SP(to), &sp, sizeof(sp));
 
 
 	if(from_fp != NULL){
 	if(from_fp != NULL){
 		err |= copy_to_user(&to->fpstate, &to_fp, sizeof(to->fpstate));
 		err |= copy_to_user(&to->fpstate, &to_fp, sizeof(to->fpstate));

+ 1 - 1
arch/um/sys-x86_64/signal.c

@@ -137,7 +137,7 @@ int copy_sc_to_user_tt(struct sigcontext *to, struct _fpstate *fp,
 	 * delivery.  The sp passed in is the original, and this needs
 	 * delivery.  The sp passed in is the original, and this needs
 	 * to be restored, so we stick it in separately.
 	 * to be restored, so we stick it in separately.
 	 */
 	 */
-	err |= copy_to_user(&SC_SP(to), sp, sizeof(sp));
+	err |= copy_to_user(&SC_SP(to), &sp, sizeof(sp));
 
 
 	if(from_fp != NULL){
 	if(from_fp != NULL){
 		err |= copy_to_user(&to->fpstate, &to_fp, sizeof(to->fpstate));
 		err |= copy_to_user(&to->fpstate, &to_fp, sizeof(to->fpstate));