Browse Source

Bluetooth: mgmt: Fix updating EIR when updating the name

Whenever we update the local device name the EIR data also needs to be
updated to reflect this. The update_eir() function in mgmt.c depends on
hdev->dev_name to be up to date so the patch also makes sure that the
mgmt function is called from hci_event.c after the update has happened.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Johan Hedberg 13 years ago
parent
commit
f51d5b2489
2 changed files with 4 additions and 3 deletions
  1. 3 3
      net/bluetooth/hci_event.c
  2. 1 0
      net/bluetooth/mgmt.c

+ 3 - 3
net/bluetooth/hci_event.c

@@ -209,12 +209,12 @@ static void hci_cc_write_local_name(struct hci_dev *hdev, struct sk_buff *skb)
 
 
 	hci_dev_lock(hdev);
 	hci_dev_lock(hdev);
 
 
-	if (test_bit(HCI_MGMT, &hdev->dev_flags))
-		mgmt_set_local_name_complete(hdev, sent, status);
-
 	if (status == 0)
 	if (status == 0)
 		memcpy(hdev->dev_name, sent, HCI_MAX_NAME_LENGTH);
 		memcpy(hdev->dev_name, sent, HCI_MAX_NAME_LENGTH);
 
 
+	if (test_bit(HCI_MGMT, &hdev->dev_flags))
+		mgmt_set_local_name_complete(hdev, sent, status);
+
 	hci_dev_unlock(hdev);
 	hci_dev_unlock(hdev);
 }
 }
 
 

+ 1 - 0
net/bluetooth/mgmt.c

@@ -3561,6 +3561,7 @@ int mgmt_set_local_name_complete(struct hci_dev *hdev, u8 *name, u8 status)
 send_event:
 send_event:
 	err = mgmt_event(MGMT_EV_LOCAL_NAME_CHANGED, hdev, &ev, sizeof(ev),
 	err = mgmt_event(MGMT_EV_LOCAL_NAME_CHANGED, hdev, &ev, sizeof(ev),
 							cmd ? cmd->sk : NULL);
 							cmd ? cmd->sk : NULL);
+	update_eir(hdev);
 
 
 failed:
 failed:
 	if (cmd)
 	if (cmd)