Quellcode durchsuchen

i915: snprintf returns large values

snprintf() returns the number of bytes which would have been used if
there was enough space.  It can be larger than the size of the buffer.
Obviously in this case the buffer is large enough but everyone just
copy and pastes this code so it's better to limit it and set a good
example.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Dan Carpenter vor 14 Jahren
Ursprung
Commit
f4433a8d5d
1 geänderte Dateien mit 3 neuen und 0 gelöschten Zeilen
  1. 3 0
      drivers/gpu/drm/i915/i915_debugfs.c

+ 3 - 0
drivers/gpu/drm/i915/i915_debugfs.c

@@ -886,6 +886,9 @@ i915_wedged_read(struct file *filp,
 		       "wedged :  %d\n",
 		       "wedged :  %d\n",
 		       atomic_read(&dev_priv->mm.wedged));
 		       atomic_read(&dev_priv->mm.wedged));
 
 
+	if (len > sizeof (buf))
+		len = sizeof (buf);
+
 	return simple_read_from_buffer(ubuf, max, ppos, buf, len);
 	return simple_read_from_buffer(ubuf, max, ppos, buf, len);
 }
 }