浏览代码

isdn: cleanup: make buffer smaller

This showed up in my audit because we use strcpy() to copy "ds" into a
32 character buffer inside the isdn_tty_dial() function.  But it turns
out that we only ever use the first 32 characters so it's OK.  I have
changed the declaration to make the static checkers happy.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 14 年之前
父节点
当前提交
f417f5e4ba
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/isdn/i4l/isdn_tty.c

+ 2 - 2
drivers/isdn/i4l/isdn_tty.c

@@ -3515,7 +3515,7 @@ isdn_tty_parse_at(modem_info * info)
 {
 {
 	atemu *m = &info->emu;
 	atemu *m = &info->emu;
 	char *p;
 	char *p;
-	char ds[40];
+	char ds[ISDN_MSNLEN];
 
 
 #ifdef ISDN_DEBUG_AT
 #ifdef ISDN_DEBUG_AT
 	printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);
 	printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);
@@ -3594,7 +3594,7 @@ isdn_tty_parse_at(modem_info * info)
 						break;
 						break;
 					case '3':
 					case '3':
                                                 p++;
                                                 p++;
-                                                sprintf(ds, "\r\n%d", info->emu.charge);
+                                                snprintf(ds, sizeof(ds), "\r\n%d", info->emu.charge);
                                                 isdn_tty_at_cout(ds, info);
                                                 isdn_tty_at_cout(ds, info);
                                                 break;
                                                 break;
 					default:;
 					default:;