Browse Source

[PATCH] PCI: fix potential resource leak in drivers/pci/msi.c

The coverity checker spotted (as entry #599) that we might leak `entry' in
drivers/pci/msi.c::msix_capability_init()
This patch should take care of that.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jesper Juhl 19 years ago
parent
commit
f01f418259
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/pci/msi.c

+ 3 - 1
drivers/pci/msi.c

@@ -793,8 +793,10 @@ static int msix_capability_init(struct pci_dev *dev,
 		if (!entry)
 		if (!entry)
 			break;
 			break;
 		vector = get_msi_vector(dev);
 		vector = get_msi_vector(dev);
-		if (vector < 0)
+		if (vector < 0) {
+			kmem_cache_free(msi_cachep, entry);
 			break;
 			break;
+		}
 
 
  		j = entries[i].entry;
  		j = entries[i].entry;
  		entries[i].vector = vector;
  		entries[i].vector = vector;