Selaa lähdekoodia

seq_file: fix big-enough lseek() + read()

lseek() further than length of the file will leave stale ->index
(second-to-last during iteration). Next seq_read() will not notice
that ->f_pos is big enough to return 0, but will print last item
as if ->f_pos is pointing to it.

Introduced in commit cb510b8172602a66467f3551b4be1911f5a7c8c2
aka "seq_file: more atomicity in traverse()".

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Alexey Dobriyan 16 vuotta sitten
vanhempi
commit
f01d1d546a
1 muutettua tiedostoa jossa 1 lisäystä ja 0 poistoa
  1. 1 0
      fs/seq_file.c

+ 1 - 0
fs/seq_file.c

@@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset)
 		p = m->op->next(m, p, &index);
 		p = m->op->next(m, p, &index);
 	}
 	}
 	m->op->stop(m, p);
 	m->op->stop(m, p);
+	m->index = index;
 	return error;
 	return error;
 
 
 Eoverflow:
 Eoverflow: