浏览代码

9p: do no return 0 from ->check_acl without actually checking

If we do not want to use ACLs we at least need to perform normal Unix
permission checks.  From the comment I'm not quite sure that's what
is intended, but if 0p wants to do permission checks entirely on the
server it needs to do so in ->permission, not in ->check_acl.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Christoph Hellwig 14 年之前
父节点
当前提交
ebbb0ef287
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/9p/acl.c

+ 1 - 1
fs/9p/acl.c

@@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask)
 		 * On access = client  and acl = on mode get the acl
 		 * On access = client  and acl = on mode get the acl
 		 * values from the server
 		 * values from the server
 		 */
 		 */
-		return 0;
+		return -EAGAIN;
 	}
 	}
 	acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);
 	acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);