Browse Source

media: move omap24xxcam's probe function to .devinit.text

A pointer to omap24xxcam_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
Acked-by: Trilok Soni <soni.trilok@gmail.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Uwe Kleine-König 15 years ago
parent
commit
ea180ca4d6
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/media/video/omap24xxcam.c

+ 1 - 1
drivers/media/video/omap24xxcam.c

@@ -1735,7 +1735,7 @@ static struct v4l2_int_device omap24xxcam = {
  *
  *
  */
  */
 
 
-static int __init omap24xxcam_probe(struct platform_device *pdev)
+static int __devinit omap24xxcam_probe(struct platform_device *pdev)
 {
 {
 	struct omap24xxcam_device *cam;
 	struct omap24xxcam_device *cam;
 	struct resource *mem;
 	struct resource *mem;