Browse Source

SUNRPC: Add address family field to svc_serv data structure

Introduce and initialize an address family field in the svc_serv structure.

This field will determine what family to use for the service's listener
sockets and what families are advertised via the local rpcbind daemon.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Chuck Lever 17 years ago
parent
commit
e851db5b05
5 changed files with 15 additions and 11 deletions
  1. 1 1
      fs/lockd/svc.c
  2. 2 1
      fs/nfs/callback.c
  3. 1 0
      fs/nfsd/nfssvc.c
  4. 5 4
      include/linux/sunrpc/svc.h
  5. 6 5
      net/sunrpc/svc.c

+ 1 - 1
fs/lockd/svc.c

@@ -266,7 +266,7 @@ lockd_up(int proto) /* Maybe add a 'family' option when IPv6 is supported ?? */
 			"lockd_up: no pid, %d users??\n", nlmsvc_users);
 			"lockd_up: no pid, %d users??\n", nlmsvc_users);
 
 
 	error = -ENOMEM;
 	error = -ENOMEM;
-	serv = svc_create(&nlmsvc_program, LOCKD_BUFSIZE, NULL);
+	serv = svc_create(&nlmsvc_program, LOCKD_BUFSIZE, AF_INET, NULL);
 	if (!serv) {
 	if (!serv) {
 		printk(KERN_WARNING "lockd_up: create service failed\n");
 		printk(KERN_WARNING "lockd_up: create service failed\n");
 		goto out;
 		goto out;

+ 2 - 1
fs/nfs/callback.c

@@ -105,7 +105,8 @@ int nfs_callback_up(void)
 	mutex_lock(&nfs_callback_mutex);
 	mutex_lock(&nfs_callback_mutex);
 	if (nfs_callback_info.users++ || nfs_callback_info.task != NULL)
 	if (nfs_callback_info.users++ || nfs_callback_info.task != NULL)
 		goto out;
 		goto out;
-	serv = svc_create(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, NULL);
+	serv = svc_create(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE,
+				AF_INET, NULL);
 	ret = -ENOMEM;
 	ret = -ENOMEM;
 	if (!serv)
 	if (!serv)
 		goto out_err;
 		goto out_err;

+ 1 - 0
fs/nfsd/nfssvc.c

@@ -229,6 +229,7 @@ int nfsd_create_serv(void)
 
 
 	atomic_set(&nfsd_busy, 0);
 	atomic_set(&nfsd_busy, 0);
 	nfsd_serv = svc_create_pooled(&nfsd_program, nfsd_max_blksize,
 	nfsd_serv = svc_create_pooled(&nfsd_program, nfsd_max_blksize,
+				      AF_INET,
 				      nfsd_last_thread, nfsd, THIS_MODULE);
 				      nfsd_last_thread, nfsd, THIS_MODULE);
 	if (nfsd_serv == NULL)
 	if (nfsd_serv == NULL)
 		err = -ENOMEM;
 		err = -ENOMEM;

+ 5 - 4
include/linux/sunrpc/svc.h

@@ -66,6 +66,7 @@ struct svc_serv {
 	struct list_head	sv_tempsocks;	/* all temporary sockets */
 	struct list_head	sv_tempsocks;	/* all temporary sockets */
 	int			sv_tmpcnt;	/* count of temporary sockets */
 	int			sv_tmpcnt;	/* count of temporary sockets */
 	struct timer_list	sv_temptimer;	/* timer for aging temporary sockets */
 	struct timer_list	sv_temptimer;	/* timer for aging temporary sockets */
+	sa_family_t		sv_family;	/* listener's address family */
 
 
 	char *			sv_name;	/* service name */
 	char *			sv_name;	/* service name */
 
 
@@ -381,14 +382,14 @@ struct svc_procedure {
 /*
 /*
  * Function prototypes.
  * Function prototypes.
  */
  */
-struct svc_serv *  svc_create(struct svc_program *, unsigned int,
-			      void (*shutdown)(struct svc_serv*));
+struct svc_serv *svc_create(struct svc_program *, unsigned int, sa_family_t,
+			    void (*shutdown)(struct svc_serv *));
 struct svc_rqst *svc_prepare_thread(struct svc_serv *serv,
 struct svc_rqst *svc_prepare_thread(struct svc_serv *serv,
 					struct svc_pool *pool);
 					struct svc_pool *pool);
 void		   svc_exit_thread(struct svc_rqst *);
 void		   svc_exit_thread(struct svc_rqst *);
 struct svc_serv *  svc_create_pooled(struct svc_program *, unsigned int,
 struct svc_serv *  svc_create_pooled(struct svc_program *, unsigned int,
-			void (*shutdown)(struct svc_serv*), svc_thread_fn,
-			struct module *);
+			sa_family_t, void (*shutdown)(struct svc_serv *),
+			svc_thread_fn, struct module *);
 int		   svc_set_num_threads(struct svc_serv *, struct svc_pool *, int);
 int		   svc_set_num_threads(struct svc_serv *, struct svc_pool *, int);
 void		   svc_destroy(struct svc_serv *);
 void		   svc_destroy(struct svc_serv *);
 int		   svc_process(struct svc_rqst *);
 int		   svc_process(struct svc_rqst *);

+ 6 - 5
net/sunrpc/svc.c

@@ -357,7 +357,7 @@ svc_pool_for_cpu(struct svc_serv *serv, int cpu)
  */
  */
 static struct svc_serv *
 static struct svc_serv *
 __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
 __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
-	   void (*shutdown)(struct svc_serv *serv))
+	   sa_family_t family, void (*shutdown)(struct svc_serv *serv))
 {
 {
 	struct svc_serv	*serv;
 	struct svc_serv	*serv;
 	unsigned int vers;
 	unsigned int vers;
@@ -366,6 +366,7 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
 
 
 	if (!(serv = kzalloc(sizeof(*serv), GFP_KERNEL)))
 	if (!(serv = kzalloc(sizeof(*serv), GFP_KERNEL)))
 		return NULL;
 		return NULL;
+	serv->sv_family    = family;
 	serv->sv_name      = prog->pg_name;
 	serv->sv_name      = prog->pg_name;
 	serv->sv_program   = prog;
 	serv->sv_program   = prog;
 	serv->sv_nrthreads = 1;
 	serv->sv_nrthreads = 1;
@@ -425,21 +426,21 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
 
 
 struct svc_serv *
 struct svc_serv *
 svc_create(struct svc_program *prog, unsigned int bufsize,
 svc_create(struct svc_program *prog, unsigned int bufsize,
-		void (*shutdown)(struct svc_serv *serv))
+		sa_family_t family, void (*shutdown)(struct svc_serv *serv))
 {
 {
-	return __svc_create(prog, bufsize, /*npools*/1, shutdown);
+	return __svc_create(prog, bufsize, /*npools*/1, family, shutdown);
 }
 }
 EXPORT_SYMBOL(svc_create);
 EXPORT_SYMBOL(svc_create);
 
 
 struct svc_serv *
 struct svc_serv *
 svc_create_pooled(struct svc_program *prog, unsigned int bufsize,
 svc_create_pooled(struct svc_program *prog, unsigned int bufsize,
-		void (*shutdown)(struct svc_serv *serv),
+		  sa_family_t family, void (*shutdown)(struct svc_serv *serv),
 		  svc_thread_fn func, struct module *mod)
 		  svc_thread_fn func, struct module *mod)
 {
 {
 	struct svc_serv *serv;
 	struct svc_serv *serv;
 	unsigned int npools = svc_pool_map_get();
 	unsigned int npools = svc_pool_map_get();
 
 
-	serv = __svc_create(prog, bufsize, npools, shutdown);
+	serv = __svc_create(prog, bufsize, npools, family, shutdown);
 
 
 	if (serv != NULL) {
 	if (serv != NULL) {
 		serv->sv_function = func;
 		serv->sv_function = func;