Browse Source

tty: serial: Samsung: Fix return value

Return the value returned by the failing function instead
of -1 (which does not convey the right error information).

Fixes the following smatch warning:
drivers/tty/serial/samsung.c:1687 s3c24xx_serial_modinit() info:
why not propagate 'ret' from uart_register_driver() instead of -1?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat 12 years ago
parent
commit
e740d8f1a0
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/tty/serial/samsung.c

+ 1 - 1
drivers/tty/serial/samsung.c

@@ -1684,7 +1684,7 @@ static int __init s3c24xx_serial_modinit(void)
 	ret = uart_register_driver(&s3c24xx_uart_drv);
 	if (ret < 0) {
 		pr_err("Failed to register Samsung UART driver\n");
-		return -1;
+		return ret;
 	}
 
 	return platform_driver_register(&samsung_serial_driver);