Explorar o código

USB: sisusbvga: Fix bug

drivers/usb/misc/sisusbvga/sisusb.c: In function sisusb_open
drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: sisusb is used uninitialized in this function

is a genuine bug (which will cause oops). We cannot use "sisusb" in
error path for (!interface), because sisusb will itself be derived
from "interface" later.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Satyam Sharma %!s(int64=17) %!d(string=hai) anos
pai
achega
e6d42f0e96
Modificáronse 1 ficheiros con 1 adicións e 3 borrados
  1. 1 3
      drivers/usb/misc/sisusbvga/sisusb.c

+ 1 - 3
drivers/usb/misc/sisusbvga/sisusb.c

@@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct file *file)
 	struct usb_interface *interface;
 	struct usb_interface *interface;
 	int subminor = iminor(inode);
 	int subminor = iminor(inode);
 
 
-	if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
-		dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface\n");
+	if (!(interface = usb_find_interface(&sisusb_driver, subminor)))
 		return -ENODEV;
 		return -ENODEV;
-	}
 
 
 	if (!(sisusb = usb_get_intfdata(interface)))
 	if (!(sisusb = usb_get_intfdata(interface)))
 		return -ENODEV;
 		return -ENODEV;