浏览代码

btrfs: Go readonly on bad extent refs in update_ref_for_cow()

update_ref_for_cow() will BUG_ON() after it's call to
btrfs_lookup_extent_info() if no existing references are found.  Since refs
are computed directly from disk, this should be treated as a corruption
instead of a logic error.

Signed-off-by: Mark Fasheh <mfasheh@suse.de>
Mark Fasheh 14 年之前
父节点
当前提交
e5df957328
共有 1 个文件被更改,包括 5 次插入1 次删除
  1. 5 1
      fs/btrfs/ctree.c

+ 5 - 1
fs/btrfs/ctree.c

@@ -333,7 +333,11 @@ static noinline int update_ref_for_cow(struct btrfs_trans_handle *trans,
 					       buf->len, &refs, &flags);
 					       buf->len, &refs, &flags);
 		if (ret)
 		if (ret)
 			return ret;
 			return ret;
-		BUG_ON(refs == 0);
+		if (refs == 0) {
+			ret = -EROFS;
+			btrfs_std_error(root->fs_info, ret);
+			return ret;
+		}
 	} else {
 	} else {
 		refs = 1;
 		refs = 1;
 		if (root->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID ||
 		if (root->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID ||