Browse Source

[SCSI] libfc:prevent dereferencing ERR_PTR in fc_tm_done()

If we goto out, then it tries to call kfree_skb() on an ERR_PTR which
will oops.  Just return directly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Dan Carpenter 14 years ago
parent
commit
e4a9a98289
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/scsi/libfc/fc_fcp.c

+ 1 - 1
drivers/scsi/libfc/fc_fcp.c

@@ -1323,7 +1323,7 @@ static void fc_tm_done(struct fc_seq *seq, struct fc_frame *fp, void *arg)
 		 *
 		 *
 		 * scsi-eh will escalate for when either happens.
 		 * scsi-eh will escalate for when either happens.
 		 */
 		 */
-		goto out;
+		return;
 	}
 	}
 
 
 	if (fc_fcp_lock_pkt(fsp))
 	if (fc_fcp_lock_pkt(fsp))