Selaa lähdekoodia

WMI: return error if wmi_create_device() fails

The break resets the retval to 0 but we want to return an error code.
This was introduced in c64eefd48c4 "WMI: embed struct device directly
into wmi_block"

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Dan Carpenter 14 vuotta sitten
vanhempi
commit
e1e0dacba5
1 muutettua tiedostoa jossa 1 lisäystä ja 1 poistoa
  1. 1 1
      drivers/platform/x86/wmi.c

+ 1 - 1
drivers/platform/x86/wmi.c

@@ -820,7 +820,7 @@ static acpi_status parse_wdg(acpi_handle handle)
 			retval = wmi_create_device(&gblock[i], wblock, handle);
 			if (retval) {
 				wmi_free_devices();
-				break;
+				goto out_free_pointer;
 			}
 		}