Sfoglia il codice sorgente

staging: iio: adc: max1363: prevent buffer overflow

ring->access.read_last() reads the entire datum from
the ring including padding and time stamp.

Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich 14 anni fa
parent
commit
e1517c00da
1 ha cambiato i file con 1 aggiunte e 2 eliminazioni
  1. 1 2
      drivers/staging/iio/adc/max1363_ring.c

+ 1 - 2
drivers/staging/iio/adc/max1363_ring.c

@@ -38,9 +38,8 @@ int max1363_single_channel_from_ring(long mask, struct max1363_state *st)
 		ret = -EBUSY;
 		goto error_ret;
 	}
-	numvals = hweight_long(st->current_mode->modemask);
 
-	ring_data = kmalloc(numvals*2, GFP_KERNEL);
+	ring_data = kmalloc(ring->access.get_bytes_per_datum(ring), GFP_KERNEL);
 	if (ring_data == NULL) {
 		ret = -ENOMEM;
 		goto error_ret;