Просмотр исходного кода

pata_it8213: fix UDMA handling

Driver should program the cycle timing not the mode number
(doing the latter results in wrong timings being used).

There shouldn't be any problems with it as IDE it8213 host driver
has been doing it this way for years.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Bartlomiej Zolnierkiewicz 15 лет назад
Родитель
Сommit
e0ee792b75
1 измененных файлов с 2 добавлено и 2 удалено
  1. 2 2
      drivers/ata/pata_it8213.c

+ 2 - 2
drivers/ata/pata_it8213.c

@@ -173,10 +173,10 @@ static void it8213_set_dmamode (struct ata_port *ap, struct ata_device *adev)
 
 
 		udma_enable |= (1 << devid);
 		udma_enable |= (1 << devid);
 
 
-		/* Load the UDMA mode number */
+		/* Load the UDMA cycle time */
 		pci_read_config_word(dev, 0x4A, &udma_timing);
 		pci_read_config_word(dev, 0x4A, &udma_timing);
 		udma_timing &= ~(3 << (4 * devid));
 		udma_timing &= ~(3 << (4 * devid));
-		udma_timing |= (udma & 3) << (4 * devid);
+		udma_timing |= u_speed << (4 * devid);
 		pci_write_config_word(dev, 0x4A, udma_timing);
 		pci_write_config_word(dev, 0x4A, udma_timing);
 
 
 		/* Load the clock selection */
 		/* Load the clock selection */