Browse Source

iwl4965: correctly validate temperature value

In some cases we can read wrong temperature value. If after that
temperature value will not be updated to good one, we badly configure
tx power parameters and device is unable to send a data.

Resolves:
https://bugzilla.kernel.org/show_bug.cgi?id=35932

Cc: stable@kernel.org # 2.6.39+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Stanislaw Gruszka 14 years ago
parent
commit
dfe21582ac
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/wireless/iwlegacy/iwl-4965.c

+ 1 - 1
drivers/net/wireless/iwlegacy/iwl-4965.c

@@ -1543,7 +1543,7 @@ static void iwl4965_temperature_calib(struct iwl_priv *priv)
 	s32 temp;
 	s32 temp;
 
 
 	temp = iwl4965_hw_get_temperature(priv);
 	temp = iwl4965_hw_get_temperature(priv);
-	if (temp < 0)
+	if (IWL_TX_POWER_TEMPERATURE_OUT_OF_RANGE(temp))
 		return;
 		return;
 
 
 	if (priv->temperature != temp) {
 	if (priv->temperature != temp) {