Browse Source

staging: ozwpan: Fix wrong error check.

schedule_work() returns true if succeeded & false on failure,
error check was doing exactly reverse.
Also removes extra variable.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare 12 years ago
parent
commit
dfc065f19f
1 changed files with 1 additions and 5 deletions
  1. 1 5
      drivers/staging/ozwpan/ozpd.c

+ 1 - 5
drivers/staging/ozwpan/ozpd.c

@@ -261,17 +261,13 @@ void oz_pd_free(struct work_struct *work)
  */
 void oz_pd_destroy(struct oz_pd *pd)
 {
-	int ret;
-
 	if (hrtimer_active(&pd->timeout))
 		hrtimer_cancel(&pd->timeout);
 	if (hrtimer_active(&pd->heartbeat))
 		hrtimer_cancel(&pd->heartbeat);
 
 	INIT_WORK(&pd->workitem, oz_pd_free);
-	ret = schedule_work(&pd->workitem);
-
-	if (ret)
+	if (!schedule_work(&pd->workitem))
 		oz_pd_dbg(pd, ON, "failed to schedule workitem\n");
 }