浏览代码

IB/iser: Remove unused "write-only" variables

Remove variables that are set but then never looked at in the iSER
initiator.  These cleanups came from David Binderman's list of "set
but never used" warnings from icc.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
Roland Dreier 18 年之前
父节点
当前提交
dee234f48a
共有 2 个文件被更改,包括 1 次插入6 次删除
  1. 0 4
      drivers/infiniband/ulp/iser/iser_initiator.c
  2. 1 2
      drivers/infiniband/ulp/iser/iser_memory.c

+ 0 - 4
drivers/infiniband/ulp/iser/iser_initiator.c

@@ -487,10 +487,8 @@ int iser_send_control(struct iscsi_conn *conn,
 	struct iscsi_iser_conn *iser_conn = conn->dd_data;
 	struct iscsi_iser_conn *iser_conn = conn->dd_data;
 	struct iser_desc *mdesc = mtask->dd_data;
 	struct iser_desc *mdesc = mtask->dd_data;
 	struct iser_dto *send_dto = NULL;
 	struct iser_dto *send_dto = NULL;
-	unsigned int itt;
 	unsigned long data_seg_len;
 	unsigned long data_seg_len;
 	int err = 0;
 	int err = 0;
-	unsigned char opcode;
 	struct iser_regd_buf *regd_buf;
 	struct iser_regd_buf *regd_buf;
 	struct iser_device *device;
 	struct iser_device *device;
 
 
@@ -512,8 +510,6 @@ int iser_send_control(struct iscsi_conn *conn,
 
 
 	iser_reg_single(device, send_dto->regd[0], DMA_TO_DEVICE);
 	iser_reg_single(device, send_dto->regd[0], DMA_TO_DEVICE);
 
 
-	itt = ntohl(mtask->hdr->itt);
-	opcode = mtask->hdr->opcode & ISCSI_OPCODE_MASK;
 	data_seg_len = ntoh24(mtask->hdr->dlength);
 	data_seg_len = ntoh24(mtask->hdr->dlength);
 
 
 	if (data_seg_len > 0) {
 	if (data_seg_len > 0) {

+ 1 - 2
drivers/infiniband/ulp/iser/iser_memory.c

@@ -235,7 +235,7 @@ static int iser_sg_to_page_vec(struct iser_data_buf *data,
 {
 {
 	struct scatterlist *sg = (struct scatterlist *)data->buf;
 	struct scatterlist *sg = (struct scatterlist *)data->buf;
 	dma_addr_t first_addr, last_addr, page;
 	dma_addr_t first_addr, last_addr, page;
-	int start_aligned, end_aligned;
+	int end_aligned;
 	unsigned int cur_page = 0;
 	unsigned int cur_page = 0;
 	unsigned long total_sz = 0;
 	unsigned long total_sz = 0;
 	int i;
 	int i;
@@ -249,7 +249,6 @@ static int iser_sg_to_page_vec(struct iser_data_buf *data,
 		first_addr = sg_dma_address(&sg[i]);
 		first_addr = sg_dma_address(&sg[i]);
 		last_addr  = first_addr + sg_dma_len(&sg[i]);
 		last_addr  = first_addr + sg_dma_len(&sg[i]);
 
 
-		start_aligned = !(first_addr & ~MASK_4K);
 		end_aligned   = !(last_addr  & ~MASK_4K);
 		end_aligned   = !(last_addr  & ~MASK_4K);
 
 
 		/* continue to collect page fragments till aligned or SG ends */
 		/* continue to collect page fragments till aligned or SG ends */