Browse Source

staging: xgifb: fail the probe if no supported LCD video mode found

Fail the probe if the LCD resolution described in card firmware does
not match any of the supported modes.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen 14 years ago
parent
commit
de736dbb22
1 changed files with 6 additions and 1 deletions
  1. 6 1
      drivers/staging/xgifb/XGI_main_26.c

+ 6 - 1
drivers/staging/xgifb/XGI_main_26.c

@@ -449,7 +449,7 @@ static int XGIfb_GetXG21DefaultLVDSModeIdx(void)
 		XGIfb_mode_idx++;
 	}
 	if (!found_mode)
-		XGIfb_mode_idx = 0;
+		XGIfb_mode_idx = -1;
 
 	return XGIfb_mode_idx;
 }
@@ -2313,6 +2313,11 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
 		}
 	}
 
+	if (xgifb_mode_idx < 0) {
+		dev_err(&pdev->dev, "no supported video mode found\n");
+		goto error_1;
+	}
+
 	if (xgi21_drvlcdcaplist) {
 		int m;