Browse Source

ALSA: cs46xx - signedness bug in snd_cs46xx_codec_read()

This function returns its own error codes instead of normal negative
error codes.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Dan Carpenter 13 years ago
parent
commit
de64c0ee7d
1 changed files with 1 additions and 1 deletions
  1. 1 1
      sound/pci/cs46xx/cs46xx_lib.c

+ 1 - 1
sound/pci/cs46xx/cs46xx_lib.c

@@ -94,7 +94,7 @@ static unsigned short snd_cs46xx_codec_read(struct snd_cs46xx *chip,
 
 	if (snd_BUG_ON(codec_index != CS46XX_PRIMARY_CODEC_INDEX &&
 		       codec_index != CS46XX_SECONDARY_CODEC_INDEX))
-		return -EINVAL;
+		return 0xffff;
 
 	chip->active_ctrl(chip, 1);