Sfoglia il codice sorgente

[LogFS] Plug memory leak on error paths

Spotted by Dan Carpenter.
Joern Engel 15 anni fa
parent
commit
ddfd1f04b7
1 ha cambiato i file con 6 aggiunte e 2 eliminazioni
  1. 6 2
      fs/logfs/dir.c

+ 6 - 2
fs/logfs/dir.c

@@ -224,10 +224,14 @@ static int logfs_unlink(struct inode *dir, struct dentry *dentry)
 	inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME;
 
 	page = logfs_get_dd_page(dir, dentry);
-	if (!page)
+	if (!page) {
+		kfree(ta);
 		return -ENOENT;
-	if (IS_ERR(page))
+	}
+	if (IS_ERR(page)) {
+		kfree(ta);
 		return PTR_ERR(page);
+	}
 	index = page->index;
 	page_cache_release(page);