Browse Source

staging: comedi: unionxx5: allocate 'usp' before using it

As reported by the kbuild test robot, the 'usp' pointer needs to be
allocated before being used.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten 12 years ago
parent
commit
dd671a3948
1 changed files with 4 additions and 4 deletions
  1. 4 4
      drivers/staging/comedi/drivers/unioxx5.c

+ 4 - 4
drivers/staging/comedi/drivers/unioxx5.c

@@ -375,15 +375,15 @@ static int __unioxx5_subdev_init(struct comedi_device *dev,
 	int i, to, ndef_flag = 0;
 	int ret;
 
+	usp = kzalloc(sizeof(*usp), GFP_KERNEL);
+	if (usp == NULL)
+		return -ENOMEM;
+
 	ret = __comedi_request_region(dev, iobase, UNIOXX5_SIZE);
 	if (ret)
 		return ret;
 	usp->usp_iobase = iobase;
 
-	usp = kzalloc(sizeof(*usp), GFP_KERNEL);
-	if (usp == NULL)
-		return -ENOMEM;
-
 	/* defining modules types */
 	for (i = 0; i < 12; i++) {
 		to = 10000;