Browse Source

drm: vmwgfx: fix information leak to userland

Structure drm_vmw_fence_rep is copied to userland with field "pad64"
uninitialized.  It leads to leaking of contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Kulikov Vasiliy 14 years ago
parent
commit
dccb2a952b
1 changed files with 1 additions and 0 deletions
  1. 1 0
      drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

+ 1 - 0
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

@@ -691,6 +691,7 @@ int vmw_execbuf_ioctl(struct drm_device *dev, void *data,
 
 
 	fence_rep.error = ret;
 	fence_rep.error = ret;
 	fence_rep.fence_seq = (uint64_t) sequence;
 	fence_rep.fence_seq = (uint64_t) sequence;
+	fence_rep.pad64 = 0;
 
 
 	user_fence_rep = (struct drm_vmw_fence_rep __user *)
 	user_fence_rep = (struct drm_vmw_fence_rep __user *)
 	    (unsigned long)arg->fence_rep;
 	    (unsigned long)arg->fence_rep;