Ver Fonte

mac80211: mesh hwmp locking fixes

This fixes missing unlocks noticed by sparse.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Johannes Berg há 17 anos atrás
pai
commit
dc0b0f7d1e
1 ficheiros alterados com 4 adições e 1 exclusões
  1. 4 1
      net/mac80211/mesh_hwmp.c

+ 4 - 1
net/mac80211/mesh_hwmp.c

@@ -264,8 +264,10 @@ static u32 hwmp_route_info_get(struct net_device *dev,
 
 	rcu_read_lock();
 	sta = sta_info_get(local, mgmt->sa);
-	if (!sta)
+	if (!sta) {
+		rcu_read_unlock();
 		return 0;
+	}
 
 	last_hop_metric = airtime_link_metric_get(local, sta);
 	/* Update and check originator routing info */
@@ -293,6 +295,7 @@ static u32 hwmp_route_info_get(struct net_device *dev,
 		break;
 	default:
 		sta_info_put(sta);
+		rcu_read_unlock();
 		return 0;
 	}
 	new_metric = orig_metric + last_hop_metric;