Procházet zdrojové kódy

[SCSI] qla2xxx: Correct qla2x00_eh_wait_on_command() to wait correctly.

Original code would break-out of loop after only one iteration.

Signed-off-by: Lalit Chandivade <lalit.chandivade@qlogic.com>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Lalit Chandivade před 16 roky
rodič
revize
d970432c48
1 změnil soubory, kde provedl 1 přidání a 4 odebrání
  1. 1 4
      drivers/scsi/qla2xxx/qla_os.c

+ 1 - 4
drivers/scsi/qla2xxx/qla_os.c

@@ -568,11 +568,8 @@ qla2x00_eh_wait_on_command(struct scsi_cmnd *cmd)
 	unsigned long wait_iter = ABORT_WAIT_ITER;
 	unsigned long wait_iter = ABORT_WAIT_ITER;
 	int ret = QLA_SUCCESS;
 	int ret = QLA_SUCCESS;
 
 
-	while (CMD_SP(cmd)) {
+	while (CMD_SP(cmd) && wait_iter--) {
 		msleep(ABORT_POLLING_PERIOD);
 		msleep(ABORT_POLLING_PERIOD);
-
-		if (--wait_iter)
-			break;
 	}
 	}
 	if (CMD_SP(cmd))
 	if (CMD_SP(cmd))
 		ret = QLA_FUNCTION_FAILED;
 		ret = QLA_FUNCTION_FAILED;