Просмотр исходного кода

drivers/ieee1394/raw1394.c: fix a NULL pointer

The coverity checker spotted that this was a NULL pointer dereference in
the "if (copy_from_user(...))" case since the next step is to
kfree(cache->filled_head).

There's no need to free cache at this point, and it's getting free'd
later.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jody McIntyre <scjody@modernduck.com>
Adrian Bunk 19 лет назад
Родитель
Сommit
d734f92b0d
1 измененных файлов с 0 добавлено и 1 удалено
  1. 0 1
      drivers/ieee1394/raw1394.c

+ 0 - 1
drivers/ieee1394/raw1394.c

@@ -2131,7 +2131,6 @@ static int modify_config_rom(struct file_info *fi, struct pending_request *req)
 			   req->req.length)) {
 		csr1212_release_keyval(fi->csr1212_dirs[dr]);
 		fi->csr1212_dirs[dr] = NULL;
-		CSR1212_FREE(cache);
 		ret = -EFAULT;
 	} else {
 		cache->len = req->req.length;