Browse Source

IPoIB/cm: Don't crash if remote side uses one QP for both directions

The IPoIB CM spec allows the use of a single connection in both
active->passive and passive->active directions.  The current Linux
code uses one connection for both directions, but if another node only
uses one connection for both directions, we oops when we try to look
up the passive connection.  Fix by checking that qp_context is
non-NULL before dereferencing it.

Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Michael S. Tsirkin 18 years ago
parent
commit
d6ef7d68f6
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/infiniband/ulp/ipoib/ipoib_cm.c

+ 1 - 1
drivers/infiniband/ulp/ipoib/ipoib_cm.c

@@ -370,7 +370,7 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
 
 
 	if (!likely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {
 	if (!likely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {
 		p = wc->qp->qp_context;
 		p = wc->qp->qp_context;
-		if (time_after_eq(jiffies, p->jiffies + IPOIB_CM_RX_UPDATE_TIME)) {
+		if (p && time_after_eq(jiffies, p->jiffies + IPOIB_CM_RX_UPDATE_TIME)) {
 			spin_lock_irqsave(&priv->lock, flags);
 			spin_lock_irqsave(&priv->lock, flags);
 			p->jiffies = jiffies;
 			p->jiffies = jiffies;
 			/* Move this entry to list head, but do
 			/* Move this entry to list head, but do